From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Gf0BEcewsWlmCCQAWB0awg (envelope-from ) for ; Wed, 11 Mar 2026 14:13:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 418871E089; Wed, 11 Mar 2026 14:13:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C374F1E089 for ; Wed, 11 Mar 2026 14:13:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4DE934BB58EB for ; Wed, 11 Mar 2026 18:13:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DE934BB58EB Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 14B444BB3BD6 for ; Wed, 11 Mar 2026 18:12:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14B444BB3BD6 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14B444BB3BD6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252750; cv=none; b=vTe9r7rjoaMocjZzYC91v169vyVHW/NPkKThEHu3WIVZDx6C9eudlVgNx6JjVCnl3/dngQ05ATIAhFIxk1uv6ioYzh2JHWICej7crV4qMXiynyl13uf0rFqa/My5lkszabv3GpWHA2xhXzYfZXMHOY8kEJFdAZlqqoy3Y+G/IE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252750; c=relaxed/simple; bh=Ibzy+z6N2Fetc09Te0Td6Y5SNRFmpD09b3QnC8lqcQA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=o2+LkTLfDW6HzR/U5Hu/pqGdebX3NtrqSWC30T/Quo8O+Zfy2/CW7JNR04+O6FhLbbNPDT8cbaEoPgTy377JXYukUGlO/Okp1VvXj6bMrnsRMJmDVkgrxj5GC+WRvX8onF1UvIN9DXaFxJCENaqRuF2yaAH0IDDBtvKN2/0Z8EM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14B444BB3BD6 Received: by simark.ca (Postfix) id A536F1E0E7; Wed, 11 Mar 2026 14:12:29 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 20/23] gdb/dwarf: change dwarf2_frame_ops to return bool Date: Wed, 11 Mar 2026 14:05:45 -0400 Message-ID: <20260311180825.720803-21-simon.marchi@efficios.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260311180825.720803-1-simon.marchi@efficios.com> References: <20260311180825.720803-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Change-Id: I0531b413823b1edc419be8f4977e9baa9efe3833 --- gdb/dwarf2/frame.h | 2 +- gdb/i386-darwin-tdep.c | 2 +- gdb/i386-darwin-tdep.h | 2 +- gdb/i386-linux-tdep.c | 12 +++++------- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/gdb/dwarf2/frame.h b/gdb/dwarf2/frame.h index c3bbfcc03f59..6ecd5d0d6563 100644 --- a/gdb/dwarf2/frame.h +++ b/gdb/dwarf2/frame.h @@ -200,7 +200,7 @@ struct dwarf2_frame_state using init_reg_ftype = void (gdbarch *, int, dwarf2_frame_state_reg *, const frame_info_ptr &); -using signal_frame_p_ftype = int (gdbarch *, const frame_info_ptr &); +using signal_frame_p_ftype = bool (gdbarch *, const frame_info_ptr &); using adjust_regnum_ftype = int (gdbarch *, int, int); /* If DWARF supoprt was requested, create the real prototype for the diff --git a/gdb/i386-darwin-tdep.c b/gdb/i386-darwin-tdep.c index 76617a97a64e..b9ea7cb3f362 100644 --- a/gdb/i386-darwin-tdep.c +++ b/gdb/i386-darwin-tdep.c @@ -97,7 +97,7 @@ i386_darwin_sigcontext_addr (const frame_info_ptr &this_frame) Without this function, the frame is recognized as a normal frame which is not expected. */ -int +bool darwin_dwarf_signal_frame_p (struct gdbarch *gdbarch, const frame_info_ptr &this_frame) { diff --git a/gdb/i386-darwin-tdep.h b/gdb/i386-darwin-tdep.h index a0f88b39c280..1496e2829c19 100644 --- a/gdb/i386-darwin-tdep.h +++ b/gdb/i386-darwin-tdep.h @@ -27,6 +27,6 @@ extern int i386_darwin_thread_state_reg_offset[]; extern const int i386_darwin_thread_state_num_regs; -int darwin_dwarf_signal_frame_p (struct gdbarch *, const frame_info_ptr &); +bool darwin_dwarf_signal_frame_p (struct gdbarch *, const frame_info_ptr &); #endif /* GDB_I386_DARWIN_TDEP_H */ diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 4a4daabbeaa9..dae4a7b7eeba 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -250,10 +250,10 @@ i386_linux_sigtramp_p (const frame_info_ptr &this_frame) || strcmp ("__restore_rt", name) == 0); } -/* Return one if the PC of THIS_FRAME is in a signal trampoline which +/* Return true if the PC of THIS_FRAME is in a signal trampoline which may have DWARF-2 CFI. */ -static int +static bool i386_linux_dwarf_signal_frame_p (struct gdbarch *gdbarch, const frame_info_ptr &this_frame) { @@ -264,11 +264,9 @@ i386_linux_dwarf_signal_frame_p (struct gdbarch *gdbarch, /* If a vsyscall DSO is in use, the signal trampolines may have these names. */ - if (name && (strcmp (name, "__kernel_sigreturn") == 0 - || strcmp (name, "__kernel_rt_sigreturn") == 0)) - return 1; - - return 0; + return (name != nullptr + && (streq (name, "__kernel_sigreturn") + || streq (name, "__kernel_rt_sigreturn"))); } /* Offset to struct sigcontext in ucontext, from . */ -- 2.53.0