From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0SL+CamwsWlmCCQAWB0awg (envelope-from ) for ; Wed, 11 Mar 2026 14:12:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 21F991E0E7; Wed, 11 Mar 2026 14:12:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E39061E089 for ; Wed, 11 Mar 2026 14:12:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6AEE04BB5919 for ; Wed, 11 Mar 2026 18:12:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AEE04BB5919 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D39FF4BAD171 for ; Wed, 11 Mar 2026 18:12:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D39FF4BAD171 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D39FF4BAD171 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252749; cv=none; b=f3aWSM1a9MjxJ9+5zi4Xc8z3DXkVl8KRzG3APiorSHYkmwLTejqAMibxx65SRZOhIaIUSOhsuEOuBIIncmdPx4EwYKsPS+Drpl3UvK2CriPiDzPnvzwF0uFhttkBWg/4oN+8w49MItc6r9qZ0U7PiYBgA+GP2gSppkcM5NkHUaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252749; c=relaxed/simple; bh=yJYhe7pA8DUrxqLKGXgbVUcIo7FtahJ4V74XXwtnzVQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WgnuOh65UycspkrYf7IJ+OZUn0QKx2eXP7NBFCOUZcp+4h5ug7jIV12Ye8kFWq9QMQ0p6qdEJUy6xNPdLdK9oUnJZI/NlmhmGaAtqpMGkWm/Hu5pYGJQ8yKlM1QgdyP4onTgVPZNQ253xsPK/0M2KPSG7MgyQql0I9XpEXN0CCE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D39FF4BAD171 Received: by simark.ca (Postfix) id 4D49E1E089; Wed, 11 Mar 2026 14:12:29 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 16/23] gdb/dwarf: change base_types_equal_p to return bool Date: Wed, 11 Mar 2026 14:05:41 -0400 Message-ID: <20260311180825.720803-17-simon.marchi@efficios.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260311180825.720803-1-simon.marchi@efficios.com> References: <20260311180825.720803-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Change-Id: I66f13baf8fe2b15fa2bab9f3dcb60c3ad9e91d6a --- gdb/dwarf2/expr.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index c253460ba34c..a5ea43e0bcc4 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -1353,13 +1353,15 @@ dwarf_expr_require_composition (const gdb_byte *op_ptr, const gdb_byte *op_end, checks that might reasonably be needed to compare DWARF base types. */ -static int +static bool base_types_equal_p (struct type *t1, struct type *t2) { if (t1->code () != t2->code ()) - return 0; + return false; + if (t1->is_unsigned () != t2->is_unsigned ()) - return 0; + return false; + return t1->length () == t2->length (); } @@ -2050,7 +2052,7 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr, first = fetch (0); pop (); - if (! base_types_equal_p (first->type (), second->type ())) + if (!base_types_equal_p (first->type (), second->type ())) error (_("Incompatible types on DWARF stack")); switch (op) -- 2.53.0