From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Mb1kF3awsWnHBSQAWB0awg (envelope-from ) for ; Wed, 11 Mar 2026 14:12:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 5BD391E0DD; Wed, 11 Mar 2026 14:12:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C9C61E089 for ; Wed, 11 Mar 2026 14:12:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C55874BAD146 for ; Wed, 11 Mar 2026 18:12:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C55874BAD146 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1A9ED4BAD171 for ; Wed, 11 Mar 2026 18:10:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A9ED4BAD171 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A9ED4BAD171 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252630; cv=none; b=Eo2Hxj/O4phsnuAIIBYtPqzHdhkKmdxPhHu/UGs4vq4njmSV0FSqtifIgZloc5o2A8flahlp+prA51nTu9Vxt5C+JXJuAWhUK/GF43XD5xT1GHPc2ALdHj6nT72s0erSnmCDzB7THSHAxhPX/Ans6pDx0HyBdtC6uJ4/ocaW5EU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773252630; c=relaxed/simple; bh=axdmrjPnjfPpDdEIpMuNKs2toGcZ5MVrmwPANe5i9js=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SQy0WAas0AFcrHfpRS9xjkZ3Nyz2fJK6+mBT/Rl0S3+W3Vuksfqwunoy/rJtpI5tMNl2lIqjXhuw9ILC1u9fdQ0KNlY25mJ0Lk7dGOpwo0ISCoK+gc32G6ofNli4Bobcx0CPToknnpB9VHL+8V5gPO0dlEpMROU98brc2I+a17c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A9ED4BAD171 Received: by simark.ca (Postfix) id BB19F1E09A; Wed, 11 Mar 2026 14:10:28 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 09/23] gdb/dwarf: change dwarf2_ranges_process to return bool Date: Wed, 11 Mar 2026 14:05:34 -0400 Message-ID: <20260311180825.720803-10-simon.marchi@efficios.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260311180825.720803-1-simon.marchi@efficios.com> References: <20260311180825.720803-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Change-Id: I7472405cf276a336247fd47bf1126eaf21b05b92 --- gdb/dwarf2/read.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 514f562e5aba..6861b6ad4cde 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -8387,12 +8387,15 @@ dwarf_fixup_empty_range (struct dwarf2_cu *cu, dwarf_tag tag) return tag == DW_TAG_inlined_subroutine && cu->producer_is_gcc (); } -/* Call CALLBACK from DW_AT_ranges attribute value OFFSET - reading .debug_rnglists. +/* Call CALLBACK from DW_AT_ranges attribute value OFFSET reading + .debug_rnglists. + Callback's type should be: - void (CORE_ADDR range_beginning, CORE_ADDR range_end) - Return true if the attributes are present and valid, otherwise, - return false. */ + + void (CORE_ADDR range_beginning, CORE_ADDR range_end) + + Return true if the attributes are present and valid, otherwise return + false. */ template static bool @@ -8599,11 +8602,14 @@ dwarf2_rnglists_process (unsigned offset, struct dwarf2_cu *cu, /* Call CALLBACK from DW_AT_ranges attribute value OFFSET reading .debug_ranges. Callback's type should be: - void (unrelocated_addr range_beginning, unrelocated_addr range_end) - Return 1 if the attributes are present and valid, otherwise, return 0. */ + + void (unrelocated_addr range_beginning, unrelocated_addr range_end) + + Return true if the attributes are present and valid, otherwise return + false. */ template -static int +static bool dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag, Callback &&callback) { @@ -8628,7 +8634,7 @@ dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag, { complaint (_("Offset %d out of bounds for DW_AT_ranges attribute"), offset); - return 0; + return false; } buffer = per_objfile->per_bfd->ranges.buffer + offset; @@ -8664,14 +8670,14 @@ dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag, /* We have no valid base address for the ranges data. */ complaint (_("Invalid .debug_ranges data (no base address)")); - return 0; + return false; } if (range_beginning > range_end) { /* Inverted range entries are invalid. */ complaint (_("Invalid .debug_ranges data (inverted range)")); - return 0; + return false; } /* Empty range entries have no effect. */ @@ -8701,7 +8707,7 @@ dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag, callback (range_beginning, range_end); } - return 1; + return true; } /* See read.h. */ @@ -8714,7 +8720,7 @@ dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return, int low_set = 0; unrelocated_addr low = {}; unrelocated_addr high = {}; - int retval; + bool retval; retval = dwarf2_ranges_process (offset, cu, tag, [&] (unrelocated_addr range_beginning, unrelocated_addr range_end) -- 2.53.0