From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rfocFC+5sGkq2SIAWB0awg (envelope-from ) for ; Tue, 10 Mar 2026 20:37:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P98OqpcL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E7CC1E089; Tue, 10 Mar 2026 20:37:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7E9C1E089 for ; Tue, 10 Mar 2026 20:37:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 308F64BAE7DB for ; Wed, 11 Mar 2026 00:36:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 308F64BAE7DB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P98OqpcL Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 66D964BAD157 for ; Wed, 11 Mar 2026 00:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66D964BAD157 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66D964BAD157 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773189389; cv=none; b=r7lrSCEnqKdDbCMPK99hsfiA1e3QGQ73G1zb3nFFtjG78HYcRfL97s1QcE0rwqf2Yt6Weo2HFMHBjcIQ5nt9KitJUQJtfhiAt4ywZrXTrqXdCJ1T/Hp65HecKC0XqrkBVfOwrwytSgjpXBPAjL4LzeWfoXheYWfJ7q+o2Wsf34Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773189389; c=relaxed/simple; bh=Lp1MegZE1xj5nOGfN2zFMXCDI4HXPBjVkPKGFu/keRI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=HEKjMpZ6GfPjb9mgd/+Kwv72SgqsBRIwiwrwD3h/N86IG5e1z5dNqExXgyYoeMJKCyuhR+nca3jQpSZ/aNaou2Yq0paCNScI0LZAvv19vh/hJzJOdBQc8yPkP5qv/b3iYlOn2s9i4sesVgQeW9pFocU5cgc0K4zc7cxi4OZgLkg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 66D964BAD157 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773189388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yyr4R5K3E2WofmK3h4vaIFpNWUxnzsKUg36B0SsgY1I=; b=P98OqpcLmlkz4LeesaoFnWrY+grHcnBHdm5BkRULp01yPMsR34j6RcKjLo+F9LNMnhbINI 6I6cWTeA+WlC8Tn1wTf2rQkfXTyWkT2VBclPKJUqXwmLo8m7//F6eRoKVEmSzpSQC4xF+L Cx3i1FWN5qR9lwXqXgnniBmQI689TX4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-JOer_3N4MqK6a-QJ2yGGpA-1; Tue, 10 Mar 2026 20:36:25 -0400 X-MC-Unique: JOer_3N4MqK6a-QJ2yGGpA-1 X-Mimecast-MFC-AGG-ID: JOer_3N4MqK6a-QJ2yGGpA_1773189384 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20D34195608A; Wed, 11 Mar 2026 00:36:24 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.88.47]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41C3D1800361; Wed, 11 Mar 2026 00:36:23 +0000 (UTC) Date: Tue, 10 Mar 2026 17:36:20 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom de Vries Subject: Re: [PATCH] gdb/testsuite: Skip gdb.base/watchpoint-unaligned.exp on s390x Message-ID: <20260310173620.26fce84a@f42-zbm-amd> In-Reply-To: <8f572769-fb70-4250-8f31-6d0c6c166f92@suse.de> References: <20260303221842.488050-1-kevinb@redhat.com> <8f572769-fb70-4250-8f31-6d0c6c166f92@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BQu6h3UYX2NZpB8uuvSX0AaYf2MiasKMhVhBn2QWXYs_1773189384 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 4 Mar 2026 07:40:18 +0100 Tom de Vries wrote: > While indeed the comment at the top mentions read watchpoints, the > test-case contains some hardcoded downgrading to regular watchpoints for > [istarget "s390*-*-*"], and consequently most of the test-case passes on > s390x. > > It's only the last bit (which runs size8twice) that fails, so moving the > check here: > ... > + if {![allow_hw_watchpoint_access_tests]} { > + continue > + } > set cmd "rwatch" > ... > is a more minimal fix, in the sense that it only skips the failing test. > > Approved-By: Tom de Vries Agreed; that is a better way to do it. After testing, this is what I pushed: gdb/testsuite: Skip rwatch in watchpoint-unaligned.exp on s390x The watchpoint-unaligned.exp test requires both read and write hardware watchpoints. s390x only supports write watchpoints, causing one test failure when the rwatch command fails with "Target does not support this type of hardware watchpoint." This commit causes the test using the rwatch command in this file to be skipped when allow_hw_watchpoint_access_tests is false. Co-Authored-By: Tom de Vries Approved-By: Tom de Vries diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp index d3bba6ae010..8b929e5de4e 100644 --- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp +++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp @@ -219,6 +219,9 @@ foreach_with_prefix fun { write_size8twice read_size8twice } { if { $fun == "write_size8twice" } { set cmd "watch" } else { + if {![allow_hw_watchpoint_access_tests]} { + continue + } set cmd "rwatch" } foreach_with_prefix offset { 0 1 } {