From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KTKfLshVsGn6+SEAWB0awg (envelope-from ) for ; Tue, 10 Mar 2026 13:32:56 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=uApqfItD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B9C3E1E0DD; Tue, 10 Mar 2026 13:32:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2EBD61E089 for ; Tue, 10 Mar 2026 13:32:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B2E7B4B9DB50 for ; Tue, 10 Mar 2026 17:32:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2E7B4B9DB50 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=uApqfItD Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AED7D4B9DB74 for ; Tue, 10 Mar 2026 17:31:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AED7D4B9DB74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AED7D4B9DB74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773163872; cv=none; b=ZX1kGUsXx7jseKrwteXAoFz58j38CxmcNM7HgIB9gfZZJH920QghWS6HRRCLe40DvkJ4wjauUTVtW3mBr96Go6gomFLsNPWIZiwghgsvwdeqk9vs+MmUm0VZ0kLuU5B/UJiu3G9CShTPEK8Ib++R9uKBoxDVS0vyMzPHg2STWtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773163872; c=relaxed/simple; bh=QDcFFjYTP5dtbMxcLUFcX9j3yQs/mVa4149e5VYfeOw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UdY5as0wOKikz4BwpFOvEDRxczX9psllCvhgPtjQAEPFYx/JZ4SvhhdpmJTWNecbe/aZ3dyI3CMM9L+uInloRcv4TK8YhfBLvS2rJ1zhfx2WXtzHAj9qHOnQZZTqZWgamp/oXuIn1lpP9bWsXTvlbU8Ufv6msbY5TY28VyXeAlU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AED7D4B9DB74 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 62AHV6Aj140207 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Mar 2026 13:31:11 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 62AHV6Aj140207 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1773163871; bh=mb8fhxGmwOD23863lpK4EkGmBzp7jYUmH9y4s/NuAyA=; h=From:To:Cc:Subject:Date:From; b=uApqfItDjmIXOuEcRmmCylxlZUoyn+I54/0OzGpYgfY0ST8SS8BanW48Qv37js869 ArAmhk3U35lF1kBZucCrG1U+ezYVdE+fxYN1ZGgfzk+gBE3vpVWjjEesYjeeH8AuYI p8sUAqAqXL6Gz9CwAgwWPj5wS7bi1uBI/z3MWeJ5ra4ezfnFfhvi6M1jry/KRE9w2r ctw3AE+kM1Qw/qV4KVx596efLX1NXxzOXw73iYCykGpWBJPxD8WDuXmCzTsMEphjD4 LcI64q1VionLkzQAZIGdW40PDqJFDWscY1SWeMrHPxvOIz4NTtY+ixSNL5dxVMFMJ5 R+5f2uCNCqMdA== Received: by simark.ca (Postfix) id 40BEA1E089; Tue, 10 Mar 2026 13:31:05 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/5] gdb/linux-tdep: check return value of linux_find_memory_region_ftype callback Date: Tue, 10 Mar 2026 13:30:32 -0400 Message-ID: <20260310173104.676640-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 10 Mar 2026 17:31:06 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi I noticed that linux_find_memory_regions_full did not check the return value of the linux_find_memory_region_ftype callback. I think this is a mistake. When called from linux_find_memory_regions, the find_memory_region_ftype callback could return false, in which case we should stop iterating. This probably didn't matter in practice, as these callbacks generally don't return false (only in error cases that never happen). Change-Id: Iafc5a9aae3d955454420d700a23f18de6f0bc267 --- gdb/linux-tdep.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 495dd0680384..53ee6d9579cc 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1637,15 +1637,12 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch, for (const struct smaps_data &map : smaps) { /* Invoke the callback function to create the corefile segment. */ - if (should_dump_mapping_p (filterflags, map)) - { - func (map.start_address, map.end_address - map.start_address, - map.offset, map.read, map.write, map.exec, - true, /* MODIFIED is true because we want to dump - the mapping. */ - map.vmflags.memory_tagging != 0, - map.filename, obfd); - } + if (should_dump_mapping_p (filterflags, map) + && !func (map.start_address, map.end_address - map.start_address, + map.offset, map.read, map.write, map.exec, + /* MODIFIED is true because we want to dump the mapping. */ + true, map.vmflags.memory_tagging != 0, map.filename, obfd)) + return false; } return true; base-commit: 1add703e09f0f8d073cde4af9d11cd59996e9763 -- 2.53.0