From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sYq7HR+7rmmBoR8AWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 08:20:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=11sECsBy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AJoE301b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lRCwznCR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+wNC/p+9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 697601E0DD; Mon, 09 Mar 2026 08:20:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BB871E08D for ; Mon, 09 Mar 2026 08:20:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0BADE4BA23D3 for ; Mon, 9 Mar 2026 12:20:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0BADE4BA23D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=11sECsBy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AJoE301b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lRCwznCR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+wNC/p+9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B0C0D4BA23C7 for ; Mon, 9 Mar 2026 12:19:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0C0D4BA23C7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0C0D4BA23C7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773058777; cv=none; b=AjQ8bPtSFAuDlMREOJ7uHacSIjkz9xIB/WueNz9Tw0egvc37w7AkoLu+Q/qJ5fpVlv4mT4RlSf/8jRhpeL7PVX1hqYkYYo1tBpZRswl3epY8lmpvys69bZdpoOoWWkRtqS1GLjfTDF9NuTbMEAdGqCcbmbUVCY+2nUaIXz/3glQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773058777; c=relaxed/simple; bh=7CEjkz4bxqULJnvfDIvjM9Pm6TxXBKjKYHzeO7bUqb4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=jTFo1qZjyNlgMXA4AbDzoEy9e7NKu65yd5fqzM7SQAwSNv0fbVSnmPpI2RlXYQInx39C5WTOIYwnD5eGxOnrUjTwNyfL2YNi998Ecw7ewx3jb8vgg4OkbiWizpEWD9OLxOi+K/vsDlL/JoZam8FJB1gdE8qsc1SUKgRRTy2Th5g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0C0D4BA23C7 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ECA035BE2F for ; Mon, 9 Mar 2026 12:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773058771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwquNvnmJ9qXD26Sqzbq88oKRLbuuUiqLSHC5UBWlD4=; b=11sECsBy68W8o/MFBLXrSD4d94AlLg8vim/B+dflj2XMlMXntCdG1MP0aJW3asMNMy9ErD hryZ+50d8DLzGtAKgkezm5zErLbqHa90bP9iCM3q66FzqbwvCaX4UNpt0JEjqqGeWf2EIV GaipLL9lMPr9OoLOOZT6pMCjHJs+zWs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773058771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwquNvnmJ9qXD26Sqzbq88oKRLbuuUiqLSHC5UBWlD4=; b=AJoE301bYh/v7hHmKxWUSFf4wekW6HhvpFex6C+B5uyjcwp7eBi+mL+wnAcaIW+GDELP8h 72zOBF2iPxak74Cw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=lRCwznCR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="+wNC/p+9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773058770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwquNvnmJ9qXD26Sqzbq88oKRLbuuUiqLSHC5UBWlD4=; b=lRCwznCRrLTG9sNnCl6LuEAWTSAT4fsV+jCquC2867g4dllvg5+8OVELioWO/sYTdqYCWd ccxjCe2w56SfwsGx6DYVzgqE4kh/LThPqpy56r5fZLipdWHA2mRSWIyxwbNOjAf8unv6rx uPKq+hrxj/u5i586c2Z71D9uSLQGjLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773058770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwquNvnmJ9qXD26Sqzbq88oKRLbuuUiqLSHC5UBWlD4=; b=+wNC/p+9cEsbsdwECLMJ/AUMCMpHCRNugJGhVo/+ipeuBzYzsd/dBocWQj5ReCog9+6jjQ EDD1fh/66oJ0c9Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CFFF43EEC6 for ; Mon, 9 Mar 2026 12:19:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eM1qMdK6rmltMgAAD6G6ig (envelope-from ) for ; Mon, 09 Mar 2026 12:19:30 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 2/3] [gdb/contrib] Handle DW_FORM_data16 in dwarf-to-dwarf-assembler.py Date: Mon, 9 Mar 2026 13:19:29 +0100 Message-ID: <20260309121930.3098744-3-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260309121930.3098744-1-tdevries@suse.de> References: <20260309121930.3098744-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-2.99 / 50.00]; BAYES_HAM(-2.98)[99.91%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: ECA035BE2F X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I ran gdb/contrib/dwarf-to-dwarf-assembler.py on testsuite executable gdb.ada/task_bp/foo, and ran into: ... Traceback (most recent call last): File "dwarf-to-dwarf-assembler.py", line 660, in main(sys.argv) ~~~~^^^^^^^^^^ File "dwarf-to-dwarf-assembler.py", line 656, in main generator.generate() ~~~~~~~~~~~~~~~~~~^^ File "dwarf-to-dwarf-assembler.py", line 628, in generate self.generate_die(die, indent_count) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ File "dwarf-to-dwarf-assembler.py", line 607, in generate_die die_lines = die.format(self.dwarf_parser.offset_to_die, indent_count) File "dwarf-to-dwarf-assembler.py", line 297, in format return "\n".join(self.format_lines(offset_die_lookup, indent_count)) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "dwarf-to-dwarf-assembler.py", line 394, in format_lines inner_lines = super().format_lines(offset_die_lookup, indent_count + 1) File "dwarf-to-dwarf-assembler.py", line 285, in format_lines child_lines = child.format_lines( offset_die_lookup, indent_count=indent_count + 1 ) File "dwarf-to-dwarf-assembler.py", line 269, in format_lines attr_line = attr.format( offset_die_lookup, indent_count=indent_count + 1 ) File "dwarf-to-dwarf-assembler.py", line 219, in format s += self._format_value(offset_die_lookup) ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ File "dwarf-to-dwarf-assembler.py", line 173, in _format_value raise NotImplementedError(f"Unknown data type: {type(self.value)}") NotImplementedError: Unknown data type: ... when trying to print the DW_FORM_data16 constant for this upper bound: ... <1><3af88>: Abbrev Number: 47 (DW_TAG_subrange_type) <3af89> DW_AT_lower_bound : 0 <3af89> DW_AT_upper_bound : 0xffffffffffffffffffffffffffffffff <3af99> DW_AT_name : system__put_images__lll_integer_images__unsigned_typeXn ... Fix this by handling elftools.construct.lib.container.ListContainer. --- gdb/contrib/dwarf-to-dwarf-assembler.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/contrib/dwarf-to-dwarf-assembler.py b/gdb/contrib/dwarf-to-dwarf-assembler.py index ca4c7696835..91e868da998 100755 --- a/gdb/contrib/dwarf-to-dwarf-assembler.py +++ b/gdb/contrib/dwarf-to-dwarf-assembler.py @@ -48,6 +48,7 @@ from io import BytesIO, IOBase from logging import getLogger from typing import Annotated, Optional +from elftools.construct.lib.container import ListContainer from elftools.dwarf.compileunit import CompileUnit as RawCompileUnit from elftools.dwarf.die import DIE as RawDIE from elftools.dwarf.die import AttributeValue @@ -169,6 +170,8 @@ class DWARFAttribute: return self._format_str(self.value.decode("ascii")) elif isinstance(self.value, str): return self._format_str(self.value) + elif isinstance(self.value, ListContainer): + return "0x" + "".join(format(i, "x") for i in self.value) else: raise NotImplementedError(f"Unknown data type: {type(self.value)}") -- 2.51.0