From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GVvNMgPSrmnl3x8AWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 09:58:27 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YJY+DtRV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C17D51E08D; Mon, 09 Mar 2026 09:58:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 765DE1E08D for ; Mon, 09 Mar 2026 09:58:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9E1A54BA2E14 for ; Mon, 9 Mar 2026 13:58:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E1A54BA2E14 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=YJY+DtRV Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id C32944BA2E24 for ; Mon, 9 Mar 2026 13:56:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C32944BA2E24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C32944BA2E24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773064598; cv=none; b=FHu1tCXPHBkmkN5iNTArYBomG+gBKB5eSFdgO7PRyE8THk9vl6SoJsDOSLgsYVCxcZTqkuqDGQZld9LVN3RFtIrfQdqI/5DxdkQHAeSsUpvbOcVMzXhRYejSMJoLD6DnWxo59CLKFtOSws6LKLJZgwytB9l7xTeYVjx5QpBQfIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773064598; c=relaxed/simple; bh=JgdXheMqz3TWJFkTeuxPTdGOgHvYN393btGTDAIyACg=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=OgMGh5feoyd2nnTtoav0pxhHQmXPAyhZMASe7BhoI1t/7ZaOD03NywCUsN//s0417q3SwjJk5fXrCIKvjOOgAw3wQT5ZjOc+Ak/h7v62vLZD7kujuW3ut83SGHkTp4TvSygcPdIf3g60iEx8fORU8RLIW/AyUWFREGUzqGDTuUs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C32944BA2E24 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id zUbHvbc1waPqLzb64vU3vQ; Mon, 09 Mar 2026 13:56:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zb5xvHJoiN3K1zb5xv9RpT; Mon, 09 Mar 2026 13:56:30 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=69aed194 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=qBkgffJUJvWMVHuRaBwA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y+lZeM8hZ/N4wu0mV3ky1d7xZ/4uZ18yrDceQ/YJY5U=; b=YJY+DtRV5WbZLojHswK+EFFjLN avDpbTM5NnrieQZTdGS4fvL69PcAmc61bRs6c7yAPEgGFe6E/yGG6Sy2HombOZeyIrq6Kptb1koYk WKpfOOASY/e4ujcWUhVf8zheb; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:47764 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vzb5x-00000000NMz-1Kuw; Mon, 09 Mar 2026 07:56:29 -0600 From: Tom Tromey Date: Mon, 09 Mar 2026 07:56:27 -0600 Subject: [PATCH v2 2/2] Use store_unsigned_integer in findcmd.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260309-no-bfd-boolean-v2-2-640b6b81c96d@tromey.com> References: <20260309-no-bfd-boolean-v2-0-640b6b81c96d@tromey.com> In-Reply-To: <20260309-no-bfd-boolean-v2-0-640b6b81c96d@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vzb5x-00000000NMz-1Kuw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net ([192.168.122.1]) [75.166.225.82]:47764 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHGUCibn9OtjCfbjks0Kt2RxSpasQ0RPHCcuGKBa9zyrlA7DR15oq8MvY9oGkZZQZ/aYRNHubcFJ/aE3/rQODmiTUvaNWX7IJyb/Y5aN9AvWbdhjYIsg oOLd/6mWB1kFfOUbTjMQU+ZLaWMx4gCETfdQBTtujKpHP0e8+gVhaPqenAQg3rgR842WRLgshyre3p5FwEQO5MXGkQN/z6uz/lg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This rewrites findcmd.c:put_bits to use store_unsigned_integer, and to directly use the byte order. --- gdb/findcmd.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/gdb/findcmd.c b/gdb/findcmd.c index 1372c2ee348..b52c44d48d0 100644 --- a/gdb/findcmd.c +++ b/gdb/findcmd.c @@ -24,27 +24,20 @@ #include "cli/cli-utils.h" #include #include "gdbsupport/byte-vector.h" +#include "extract-store-integer.h" -/* Copied from bfd_put_bits. */ +/* Append DATA to BUF, writing only the specified number of bits, + using the given endian-ness. */ static void -put_bits (uint64_t data, gdb::byte_vector &buf, int bits, bool big_p) +put_bits (uint64_t data, gdb::byte_vector &buf, int bits, + bfd_endian byte_order) { - int i; - int bytes; - gdb_assert (bits % 8 == 0); - - bytes = bits / 8; + int bytes = bits / 8; size_t last = buf.size (); buf.resize (last + bytes); - for (i = 0; i < bytes; i++) - { - int index = big_p ? bytes - i - 1 : i; - - buf[last + index] = data & 0xff; - data >>= 8; - } + store_unsigned_integer (&buf[last], bytes, byte_order, data); } /* Subroutine of find_command to simplify it. @@ -53,7 +46,7 @@ put_bits (uint64_t data, gdb::byte_vector &buf, int bits, bool big_p) static gdb::byte_vector parse_find_args (const char *args, ULONGEST *max_countp, CORE_ADDR *start_addrp, ULONGEST *search_space_lenp, - bool big_p) + bfd_endian byte_order) { /* Default to using the specified type. */ char size = '\0'; @@ -171,13 +164,13 @@ parse_find_args (const char *args, ULONGEST *max_countp, pattern_buf.push_back (x); break; case 'h': - put_bits (x, pattern_buf, 16, big_p); + put_bits (x, pattern_buf, 16, byte_order); break; case 'w': - put_bits (x, pattern_buf, 32, big_p); + put_bits (x, pattern_buf, 32, byte_order); break; case 'g': - put_bits (x, pattern_buf, 64, big_p); + put_bits (x, pattern_buf, 64, byte_order); break; } } @@ -210,7 +203,7 @@ static void find_command (const char *args, int from_tty) { struct gdbarch *gdbarch = get_current_arch (); - bool big_p = gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG; + bfd_endian byte_order = gdbarch_byte_order (gdbarch); /* Command line parameters. These are initialized to avoid uninitialized warnings from -Wall. */ ULONGEST max_count = 0; @@ -223,7 +216,7 @@ find_command (const char *args, int from_tty) gdb::byte_vector pattern_buf = parse_find_args (args, &max_count, &start_addr, &search_space_len, - big_p); + byte_order); /* Perform the search. */ -- 2.49.0