From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +VllG9BsrGn5+BoAWB0awg (envelope-from ) for ; Sat, 07 Mar 2026 13:22:08 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qEzQGjas; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 501B71E09A; Sat, 07 Mar 2026 13:22:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CAA131E09A for ; Sat, 07 Mar 2026 13:22:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 821224BA23FC for ; Sat, 7 Mar 2026 18:22:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 821224BA23FC Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qEzQGjas Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id B66AB4BA2E1C for ; Sat, 7 Mar 2026 18:20:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B66AB4BA2E1C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B66AB4BA2E1C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772907654; cv=none; b=s8ywbx1DgdZPqvVBL42fR7+PQhsFE33lkcmDoWnGABqdgQACyMwEE+6KGKnX6umkujNUcgz2jj+zo/MSlyKY890fWmsVz9RN5lqyzt3fjj+m0Xslfdu7xwwh4P71gpa91zQhY3kT+5/LBaDmQIHHepX6hlXV9ppW5zRAyxr3IS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772907654; c=relaxed/simple; bh=iTGQcCUJU6Mbkyd3qhOYfj/er9oNTa2NKmPsvvxvSVA=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=f2O/JCAU3ZPlp8ccLc3quXTfptv8DTp3/oZNOnX3sPlKZX0Yk00FLdgINC+LqreutoxfZMXmarj03K4sraX/V4bih8otDOBOhj1rMA4xKKB7ee/e/ht1kVEj4xpHuxr82U5oXjLEFHvfJGakfkvEdfteX3ujop3MVElWhCKTDgY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B66AB4BA2E1C Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id ynW1v6NL8CxrGywGkv40qY; Sat, 07 Mar 2026 18:20:54 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ywGfvZGl0HSQMywGfvDkpP; Sat, 07 Mar 2026 18:20:49 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=69ac6c85 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=nscF7aoCVpejEc_GYnoA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pnibxg/LUH6cmCX7zYHZKVnqgM9n+AXTrgLg5OFuPDA=; b=qEzQGjas/R+66vPX/1/mlvHgql MRjQ+tQZC0oWvLMEz12AL2Y/WhooAnqnsLSDjn9yve99r7yfjouPClCOwHAqCZbLw/wpaE+Buh5Rs Jw3hd1raskFUvH39bze+Vljvt; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:53288 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vywGf-000000042Dr-1Aig; Sat, 07 Mar 2026 11:20:49 -0700 From: Tom Tromey Date: Sat, 07 Mar 2026 11:20:47 -0700 Subject: [PATCH 2/4] Don't use BFD TRUE/FALSE constants MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260307-no-bfd-boolean-v1-2-186424bf8238@tromey.com> References: <20260307-no-bfd-boolean-v1-0-186424bf8238@tromey.com> In-Reply-To: <20260307-no-bfd-boolean-v1-0-186424bf8238@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vywGf-000000042Dr-1Aig X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net ([192.168.122.1]) [75.166.225.82]:53288 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMYc73VHDhOl/FDm6Pj26U9KBCV7GCHCzxLfy+QiwRRAvcTY1wFXePwO6vuDo4EK6AVD27yc0BrpXPhS7gW15Ku2Gvq9z0odapoLR1oM9u0c/HYltQdH lTVxKoNpnuT5j2XqWNPKgCi/X5CnHNLdxkY5uYh5BUU23R6xXM7fGB8hiZfUI/HAr8pWLMcqszByQLExRyB6EjV02i4U6PKlIW8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch replaces uses of the BFD TRUE/FALSE constants with the corresponding C++ constants. Note that some uses of TRUE and FALSE remain: * Mach code (Darwin and Hurd). I don't know if this is typical and anyway I can't build this code. * Curses code * Windows code --- gdb/arc-linux-tdep.c | 6 +++--- gdb/compile/compile-object-load.c | 2 +- gdb/elfread.c | 2 +- gdb/machoread.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/arc-linux-tdep.c b/gdb/arc-linux-tdep.c index 207235d3732..ca3dbf5a5fa 100644 --- a/gdb/arc-linux-tdep.c +++ b/gdb/arc-linux-tdep.c @@ -212,18 +212,18 @@ arc_linux_is_sigtramp (const frame_info_ptr &this_frame) if (!safe_frame_unwind_memory (this_frame, pc, {buf, insns_sz})) { /* Failed to unwind frame. */ - return FALSE; + return false; } /* Is that code the sigtramp instruction sequence? */ if (memcmp (buf, arc_sigtramp_insns, insns_sz) == 0) - return TRUE; + return true; /* No - look one instruction earlier in the code... */ if (!safe_frame_unwind_memory (this_frame, pc - 4, {buf, insns_sz})) { /* Failed to unwind frame. */ - return FALSE; + return false; } return (memcmp (buf, arc_sigtramp_insns, insns_sz) == 0); diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index e31be539741..bbee2f7cc56 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -372,7 +372,7 @@ copy_section (bfd *abfd, asection *sect, sect_data_got = bfd_get_relocated_section_contents (abfd, &link_info, &link_order, - sect_data.get (), FALSE, + sect_data.get (), false, symbol_table.data ()); if (sect_data_got == NULL) diff --git a/gdb/elfread.c b/gdb/elfread.c index 7e38f623d12..7a647396f68 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -601,7 +601,7 @@ elf_rel_plt_read (minimal_symbol_reader &reader, if (relplt == NULL) return; - if (! bed->s->slurp_reloc_table (obfd, relplt, dyn_symbol_table, TRUE)) + if (! bed->s->slurp_reloc_table (obfd, relplt, dyn_symbol_table, true)) return; std::string string_buffer; diff --git a/gdb/machoread.c b/gdb/machoread.c index 334e3b41b6a..416eb6766fd 100644 --- a/gdb/machoread.c +++ b/gdb/machoread.c @@ -483,7 +483,7 @@ macho_add_oso_symfile (oso_el *oso, const gdb_bfd_ref_ptr &abfd, struct macho_sym_hash_entry *ent; ent = (struct macho_sym_hash_entry *) - bfd_hash_lookup (&table, sym->name, TRUE, FALSE); + bfd_hash_lookup (&table, sym->name, true, false); if (ent->sym != NULL) complaint (_("Duplicated symbol %s in symbol table"), sym->name); else @@ -548,7 +548,7 @@ macho_add_oso_symfile (oso_el *oso, const gdb_bfd_ref_ptr &abfd, struct macho_sym_hash_entry *ent; ent = (struct macho_sym_hash_entry *) - bfd_hash_lookup (&table, sym->name, FALSE, FALSE); + bfd_hash_lookup (&table, sym->name, false, false); if (ent != NULL) addr = bfd_asymbol_value (ent->sym); } -- 2.49.0