From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qXneBGRlqGmERxQAWB0awg (envelope-from ) for ; Wed, 04 Mar 2026 12:01:24 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=A+mUg0+4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0D6811E0DD; Wed, 04 Mar 2026 12:01:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 428071E089 for ; Wed, 04 Mar 2026 12:01:23 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9CA564B9DB44 for ; Wed, 4 Mar 2026 17:01:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CA564B9DB44 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=A+mUg0+4 Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id DBB944BA2E14 for ; Wed, 4 Mar 2026 17:00:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBB944BA2E14 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBB944BA2E14 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772643606; cv=none; b=a/1YEA2bx8WUFjEKxudy3eCkrP6AQf6kc1DeEsQ3/LtlpKUqkgqByDmNJLonVCkWI5qLYTqnnrdgtHl7y38ug/o62hxi4Bg62FCvDibl2kIULML9aisfx788/ySZGxchLBMFzCt34e+cs5kHNhZzoBdi4l6pYiv5f/Dc4DR/6MQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772643606; c=relaxed/simple; bh=mkEibajwdvOxVFh0xqQSjja4pQPSeOnxxUJjQf/PTyg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cmZa5vqQmPaTRX/UJ2V5qjkZVjankX+ooQ5+VIm4tFCLCnHabdxqrig+yuVpb2ZKMsBzw3W4OpmYkd8r499Ggk6A67NzL2Q8lYdNJREJVfyizQ5a9egd/iRuOaVRkloa63LkIw5FKyZws8LMMgxOvxqImgA8LgGcf3aa9A1YRvU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DBB944BA2E14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1772643605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ZZTr16UANZJ24vIDMP2rPDzD1MVm1MN6Cd6LYq3CFY=; b=A+mUg0+4IqyLAeaxuh4lVCc39FhZ7iA8I3dvsX4SMWC3FkXfB2vUgGXXp4hfBi+DiddBk4 hy69yNMtbh2ZE/VjgrRGfAmIjHPoj+L45n+es5SEGbL2FlgTPSSt0zR/5wrfTMm6eUi08F dpYWC87RRDuiAJULluuukyPabJPb3bY= Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11021143.outbound.protection.outlook.com [52.101.52.143]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-qPpHy_kcPlK3hSmmfTLhoA-1; Wed, 04 Mar 2026 12:00:03 -0500 X-MC-Unique: qPpHy_kcPlK3hSmmfTLhoA-1 X-Mimecast-MFC-AGG-ID: qPpHy_kcPlK3hSmmfTLhoA_1772643603 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by IA3PR17MB7264.namprd17.prod.outlook.com (2603:10b6:208:51c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Wed, 4 Mar 2026 17:00:01 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9654.022; Wed, 4 Mar 2026 17:00:01 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany , Tom Tromey Subject: [PATCH v2 2/7] gdb: update expanded_symbols_functions::find_pc_sect_compunit_symtab Date: Wed, 4 Mar 2026 16:59:09 +0000 Message-ID: <20260304165914.3209106-3-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304165914.3209106-1-jan.vrany@labware.com> References: <20260304165914.3209106-1-jan.vrany@labware.com> X-ClientProxiedBy: LO4P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::13) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|IA3PR17MB7264:EE_ X-MS-Office365-Filtering-Correlation-Id: add28f89-0233-4a8f-18ac-08de7a0f796e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014 X-Microsoft-Antispam-Message-Info: EhaD+ywbR54Jtj31/ogKKfFFon9dtdasvrNkspA/dMSUe5s7ajQUF2lwjm6nk2AZjhEa5IwkmBEHR0lBMAd7e/gmDSJ8A80VN73ObEWr5aPumCvF4V89yvFzhUXXtTVcKd4SYqbGncCQ/G6FyksIMt5HYC+sfGTryzckqCJbTIJ73QxdAR7q7OfzMuTuMQmo0X/C1d5ZKkquysyseMMLABuxdRbwmu7uOfHZWdpWp3c/lzyZPju4WOze0ioyqeTfT7oxAums8wNn0ZgicXlTFaxN6/SVNtbw4gECHloJEh+LKhKmQxNKKPJvHGUARqXNYWgJcIOPu7x2Pm56lKTWVC/tyFuM+r/kbSof4S/pPnpm3+YWcCakrWZSH/D4NPLQRH3e/NoclKlHrxQ+ZAXgqaJrfG05jXS3oCmI9cLh5SDfznu8UNC8ghPYGE9Kh4BKaCPm7d5Sfbegy0hHmDwUuUzalGJrfUxpyJFgxPDGAhPTRUw3XkqmYTfqNXoKGNfoRKvMeQ9gcrFAFg29t20vOsyVSz3WzfGx1JLPTmr60bBRyVQMD8G16/XmdKu1YjnkWbygCy8oRRO+hdW9kZFtAt9XadUGxV6p/fHkc1ZzssQVqek83vRaE2DlYTgD21BCC/SS233ohbgNKpyGprsFoIqRWTIYjgb+1pS3H6u8NeDBexZCdAqlpQdVE/6hDQeDqWlMr7pRmByF7RiLbaJbSmhTfCsx24koYpTjdwbxRkc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7gDfXe7nTrsRczXHd6OS444k/8XhFdBjIwmueJ8qFKU6K6CGCOyzZeRFCUrV?= =?us-ascii?Q?gRiURvgkSNhhDYqlXjeBLQE+bPhhGMWf4i6ebPVgf3zdZDiAZ44vmomNN3d8?= =?us-ascii?Q?32w14cAiqFl4jHFOlcpTsB8VM8p+yNdtefG/9YSlrGZ4/s4l6d7pSP6jD3J4?= =?us-ascii?Q?HXJKhwKn4TAv0SJSDRzWufJKFcVn1G/Mrx/1xWeTAv8zGut/aHB5YoBXAmv4?= =?us-ascii?Q?x+7qAa7YKF29j/s8uN0KYqqHullfpg/u4i6/0joIKB8EPBSkfIuqaxhhoVEK?= =?us-ascii?Q?wiNlIGXgx+mvp7v5ItkZMEzezRsaekFC+L/SpNnqZ1H/U6ftALVRy46B/3eA?= =?us-ascii?Q?wIjXMMbysZnf6NvdDxvT5s2J5TMBpwYTO4O0zKwS8OwA6+/dxZ1wdXk0cqNC?= =?us-ascii?Q?CYj9NY1g8jhVBdAoxAVtnpmpXad379UYscdncYS5vD7hX6Z+7ndX0GjKHwRP?= =?us-ascii?Q?2p3MAVfpIPwI6+Tq7ap0LmNY3WiVnVbaZpfwFMHnz1COH8HHsH1tO3ArEdec?= =?us-ascii?Q?cUnsrQNrgCFF+sR3wLeciaM/AI4a1/Wcs3PwNRJZyuxS9KHZKHWgT5SBk3Os?= =?us-ascii?Q?XqvBXGXK9oVZSeGH3G8M6pMgw3iQUuf4h/LTIBScCg5sMIbWngsAYOhDmUC0?= =?us-ascii?Q?jkfYOAPHFAILnZjISaHAb72lehOkhgKiEToYyUChVpnF3RHFSuVOBcvoWe2v?= =?us-ascii?Q?7e49zh+1oUk/O07CGkPCOcadi84EmI/Q/1vY3Q6v8oyYaANEJ5pS33Tg7VSU?= =?us-ascii?Q?291NM/BweOjWbssPrBP4+k9oIP62kMR4aF8YcWWS/hks3YZRnlmLIw2qmvzY?= =?us-ascii?Q?0T+z1rxLGTJ/zYwxbgxTQxdUt9MndjhX7mYD9LNdEB1Q1uVGhUaxqQ33r1CF?= =?us-ascii?Q?Oro1Tql1t5aBqBdm8qXuMN90MgPkde6SVtfQFO+4OyNc+B8wyo+vm7AWNuss?= =?us-ascii?Q?mhKUIfSbKqmMdvTDXfxym7BBQ1DT7skcpC+HzMGugra1JtxUfpIMq8bHvK3y?= =?us-ascii?Q?2j2RGtCrqmCPZvseGe24J4rWSFV4j/R09naDId+9qsga0kkxIGzjEtNsoxOB?= =?us-ascii?Q?Pgpwtd2l4nXJGR8P+VQux6MXpcewMb61kVotsAGUpNc7FH4O5R8xATrYLFIE?= =?us-ascii?Q?u+uoqKekS0F+2iETXr/glQYjEj9jnHAW50+8BgpjlaOjtDlzdFMs1YPBsAW0?= =?us-ascii?Q?V2fIlUQlX8XxT7VBpREb4tnEIzqm3sxNgyx9PRz6AzImGjKz3dAiocgYQiz4?= =?us-ascii?Q?UTsi9povpnNvqcKSOmdaK8YUab2Kdlz7XAIvT7Pycr6dPnf5S29UonFmsP1L?= =?us-ascii?Q?kO5To1oXfDVX3cxs1nfNq/ESWz9TNvG9D+MinQsnXr6+9raG1mSYqopzVkWC?= =?us-ascii?Q?xtc7JqNICVbxLbIW5ICoC1wFYgO0nwRy/ZgCt0LFx8Mn9ckPgGLQtr8mghK5?= =?us-ascii?Q?3/zLrNU/xVS1A5MYtZtFefg+CKSXy5EQmG4KGlvp+n6kbubt1sRi5W2O24tc?= =?us-ascii?Q?5Uf2rlutOlsNtyciJqImU4BxNfkHLqZq9eqChP8yDqA0dCUHmJdoF9AO23iu?= =?us-ascii?Q?OxRStGe4qyGEZXw6V7BJpK8bUzmZbd1wQ6t/GYMN6w1VRhubyx7SgM+jmNL9?= =?us-ascii?Q?faoDFUtkrgm5bsSip1bSLC1Q9//xDDdtPkXgAOc11VYNRR4yuEvsqShPo9ba?= =?us-ascii?Q?IGMnG185Jo/MrnVMZNRKXnb1LedfpQ5blEjoVPxIpEi+yhapKsHxlvFa8XfU?= =?us-ascii?Q?grf9tsAG5w=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: add28f89-0233-4a8f-18ac-08de7a0f796e X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2026 17:00:01.6932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMQxbN/RX+avLVrB52mIHWFCcSGW+wqkfkha+fvQwgmM5xTzn90k/SBI3X0DRc5JioUy6dTvVv2TGXGE8cjjnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR17MB7264 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C-ryl1X6_5aZn4-ZzhripTMlJtRptJkTGCFyPTIVLho_1772643603 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit updates expanded_symbols_functions::find_pc_sect_compunit_symta= b to search all compunits rather than just returning null. The original implementation (just return null) was based on reasoning that its would suffice since find_compunit_symtab_for_pc_sect walks all CUs anyway [1]. This commit is a preparation to simplify find_compunit_symtab_for_pc_sect by removing that code. Approved-By: Tom Tromey Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D33829 [1] https://inbox.sourceware.org/gdb-patches/874iqoogoa.fsf@tromey.com/ --- gdb/expanded-symbol.c | 18 ++++++++++++++++++ gdb/expanded-symbol.h | 8 +------- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/gdb/expanded-symbol.c b/gdb/expanded-symbol.c index 050608795f9..3c7f9019beb 100644 --- a/gdb/expanded-symbol.c +++ b/gdb/expanded-symbol.c @@ -18,6 +18,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . = */ =20 +#include "block.h" #include "objfiles.h" #include "symtab.h" #include "source.h" @@ -113,3 +114,20 @@ expanded_symbols_functions::find_symbol_by_address (ob= jfile *objfile, =20 return nullptr; } + +/* See expanded-symbol.h. */ + +compunit_symtab * +expanded_symbols_functions::find_pc_sect_compunit_symtab + (objfile *objfile, bound_minimal_symbol msymbol, CORE_ADDR pc, + obj_section *section, int warn_if_readin) +{ + for (compunit_symtab &symtab : objfile->compunits ()) + { + const blockvector *bv =3D symtab.blockvector (); + if (bv !=3D nullptr && bv->contains (pc)) +=09return &symtab; + } + + return nullptr; +} diff --git a/gdb/expanded-symbol.h b/gdb/expanded-symbol.h index c088d74f7e5..dc2e9814b3c 100644 --- a/gdb/expanded-symbol.h +++ b/gdb/expanded-symbol.h @@ -71,13 +71,7 @@ struct expanded_symbols_functions : public quick_symbol_= functions =20 compunit_symtab *find_pc_sect_compunit_symtab (objfile *objfile, bound_minimal_symbol msymbol, CORE_ADDR pc, - obj_section *section, int warn_if_readin) override - { - /* Simply returning NULL here is okay since the (only) caller - find_compunit_symtab_for_pc_sect iterates over existing CUs - anyway. */ - return nullptr; - } + obj_section *section, int warn_if_readin) override; =20 symbol *find_symbol_by_address (objfile *objfile, CORE_ADDR address) override; --=20 2.51.0