From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +X4sILAKp2m9pBIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 11:22:08 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NUwQtu7e; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NUwQtu7e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 76D7D1E0E1; Tue, 03 Mar 2026 11:22:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E5C861E09A for ; Tue, 03 Mar 2026 11:22:06 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 700ED4BA23CC for ; Tue, 3 Mar 2026 16:22:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 700ED4BA23CC Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NUwQtu7e; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=NUwQtu7e Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id 4F4304BA23C0 for ; Tue, 3 Mar 2026 16:19:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F4304BA23C0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4F4304BA23C0 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772554777; cv=pass; b=nrcUHsW6zwuTzaGLOnmwNrCYa6vqCpvF4NXkWlV3DheGBB/v9CY5V+taCfYDKSHc07ShDnmC2Q8isGU046MCDcvB9sdNSMpx7fTqR6+aodNG8gQT2w150bIVOHFMI/dALin9375qGeOYX78SLL8gT3mQ8nm2iCwZIHST3Ypmu94= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772554777; c=relaxed/simple; bh=AI0vGi+NZtl+AtmrFFh2wWgg9d+pLrjpOOzG1hGvmE0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BOnQIR3f7GdLWYeqjeihoAI5ZL6MYRBVhD2HE2FynTvPBqfyHBLROMaMFihLulmJsTMSstrbpEvoV0rz9XthkqwFK/Z22k5f3Ryujxe/93cGBFgyl2khzAurUMjCzp695q5jskZ7MOtwKptAjXM+UjzRY61RQ1pQcT6hDzhZ9rY= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F4304BA23C0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=QhMV4cF0BBRWO/eeV6dHmkX71s0x1auOFph4RXaKRvlf29TOJnHO1qXFlgR9qSJQxHNdo4jvCR4NKlNA0OKRZqSONt06Lhveyl42tRCf/TuwTbdYJGvyIueIVv/1Co3EtlYoR2hXYriMAgWvSpwGvsrhrwRYHjNbYhapQCe5Par70I/DSUMx66aR3Pkt5KvyZV8LPSi/PpTV5SLgyMy3aoNdrCCLbn7mvdFVZnjQ4l147O0XPgVjIZgRh7KW28WQRaLeJRx1va6EwPNXuVisKEN2sN6qJasloYcF4ywCBajfCaA4nkIRg79e0tUrxCGZvQSp4ASltRJPSMuXF/xrdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Np8gMxWsCBjj+4kCJZ98/MUo3wAnb/dmMeLIOUDOENw=; b=wo2NB+90HI91QvrJsZxwi2PU+F60I2zrW4vpRBqxXrRd2Q/1fj7hAXde658+GPbB+LsrEVQX1x8hLKmqXclYl+h7bTlVg2BFgzf79uA4tfGC9ArxyV2rOvyJwvfVhBMmbSse4QfQd/JLmSdBasKUJLGIujnjOzJiONG4Ur0sLF0joyGL/6pO2XSCG0P0uYYyRuF9H56ee8J/hM1JG3gkgTA+mb7BZVtGgE+v7W9iWlzQFFd78WCecI52Z2i5TqQxxCWLaep6JafRJqloz8LJWBC1fWJfjYIDoLezcf61sjWqFmql32QRJzEekWmejc34EFWKfpdLLqxQU/VXtyQkXw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Np8gMxWsCBjj+4kCJZ98/MUo3wAnb/dmMeLIOUDOENw=; b=NUwQtu7e5crzhOhjL1dYrBA0oNXhqJFMEw5k5shzW56YWIAX1GZRUVY+JctmXeA82IixNZR+Rq+aF3becqiN2sdn67Y1m7RPzxkjMQWuowRjLJeniQgpPZlvfZrTniuXH2jxvHRs8SIg+hP6EiKirOrf4VC1sLhKzSsE0Gjm+Tk= Received: from DUZPR01CA0032.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::11) by AS8PR08MB8803.eurprd08.prod.outlook.com (2603:10a6:20b:5bb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 16:19:32 +0000 Received: from DU2PEPF00028D07.eurprd03.prod.outlook.com (2603:10a6:10:468:cafe::88) by DUZPR01CA0032.outlook.office365.com (2603:10a6:10:468::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.22 via Frontend Transport; Tue, 3 Mar 2026 16:19:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF00028D07.mail.protection.outlook.com (10.167.242.167) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Tue, 3 Mar 2026 16:19:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DCAnjKvf/YeMcztLfelyWvkvH6AFBByVG0U70IXVq4UJ8IIuGbJwSfmD4UH4fu98c40U1nsm4OzXDgWTAs4+YskbrIi1XidVH4S0Ia0DVcy8Pyn9zqBQASPB0L6PnBO2rHAiBDjHkorkYtr1KHjj+r54aV0iv7xYGJXkwOkN8dtlAtV7tQLwW79JWL6XRHr+V4EIJD2dDvs8kwAGFLlYKO0HBU0LmW3N7gAwn/8WgFAxh4MN4658t17eArvc1E0BBDk2Tz24N0eU6rb+g4qZnA9XKQyy755PaJ7JGCILwVnsn4i2GnQzdnFQfbAxGZnYF9Yn9Nw2IRXqjiY/DWxN6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Np8gMxWsCBjj+4kCJZ98/MUo3wAnb/dmMeLIOUDOENw=; b=iQdFRqMJKIbbVGYqN+SrFHQY/o5SpJtWe9OC8pNXmZAv2Nys3buqqhU4CoTOybR2vJahQXwkZ+ofK0Lf198+eiRRn9Wtjy4tW4AJsxQIR6CHhj3Je9Tn/lJA86NDCfY3koSmXHDeqWS6AzXuIqIV1wxqcNDJbW4RR14nsBYmyKPFwJnlhpa5uw6L4H/BTaTiLWN68231T5z9Q8kFcJj/p3a3MYgsme9xrz+DhrprzSzk+2kKbSp1B04S/GxhD0kFBJ8A9nDWIaoR7p/wlW5ah6Gsr1av8FmNvhKDrb+Kg1YK74/HRvB3zEu0WMymfVSCgGM1U2d9fmX+Lvqt6JDT6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 172.205.89.229) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Np8gMxWsCBjj+4kCJZ98/MUo3wAnb/dmMeLIOUDOENw=; b=NUwQtu7e5crzhOhjL1dYrBA0oNXhqJFMEw5k5shzW56YWIAX1GZRUVY+JctmXeA82IixNZR+Rq+aF3becqiN2sdn67Y1m7RPzxkjMQWuowRjLJeniQgpPZlvfZrTniuXH2jxvHRs8SIg+hP6EiKirOrf4VC1sLhKzSsE0Gjm+Tk= Received: from PAZP264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:21::13) by FRZPR08MB11162.eurprd08.prod.outlook.com (2603:10a6:d10:13b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 16:18:26 +0000 Received: from AM4PEPF00025F9B.EURPRD83.prod.outlook.com (2603:10a6:102:21:cafe::ac) by PAZP264CA0008.outlook.office365.com (2603:10a6:102:21::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.21 via Frontend Transport; Tue, 3 Mar 2026 16:18:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 172.205.89.229) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 172.205.89.229 as permitted sender) receiver=protection.outlook.com; client-ip=172.205.89.229; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (172.205.89.229) by AM4PEPF00025F9B.mail.protection.outlook.com (10.167.16.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.0 via Frontend Transport; Tue, 3 Mar 2026 16:18:25 +0000 Received: from AZ-NEU-EX04.Arm.com (10.240.25.138) by AZ-NEU-EX04.Arm.com (10.240.25.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 3 Mar 2026 16:18:19 +0000 Received: from PF4S4363.arm.com (10.57.82.243) by mail.arm.com (10.240.25.138) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 3 Mar 2026 16:18:19 +0000 From: Matthieu Longo To: , Tom Tromey CC: Matthieu Longo Subject: [PATCH v2 7/9] gdb/python: accept gdbpy_ref in init helpers and return bool Date: Tue, 3 Mar 2026 16:16:57 +0000 Message-ID: <20260303161659.397427-8-matthieu.longo@arm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260303161659.397427-1-matthieu.longo@arm.com> References: <20260303161659.397427-1-matthieu.longo@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM4PEPF00025F9B:EE_|FRZPR08MB11162:EE_|DU2PEPF00028D07:EE_|AS8PR08MB8803:EE_ X-MS-Office365-Filtering-Correlation-Id: 19df50a5-b83f-47d4-d831-08de7940a718 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info-Original: ImtMC3dMDo7a4clmbG9QMUNED/SHbXHeOBEw+FmtwaM4kzS7u3SAhy/JO+j/49KAdSbhA0ggBcBMfjp/UVEMngnJYd5+4qes1l0V9doXn4G3UPKFDlPUsE6CujNU7rUkj4mlUCFVERsexkSX2FZsOrJnDeJdOLNzRRUgIj0PjYZNEL7CseQKAtGb79bdNgohzWTcVD/DnNLCHlCq8bHccoyKm6E2Fq/VGHNKKjUzn6XmsDOMluUY+8NT0WwACc9RTi5PEj9vOkvgnR+EzRbnnLtRXewQKmIJEnDSEuvQZxXp+6c1uMrT7kRcPrvQXrmJfz/T2xtmVV0UfICPWbrtGtz6tk7oLw+ZMIvYzjC7IKvK/ZyLcdXZbBeF0lcnukeGIL83pjeeKpqBOtl9L3pt5j0dFs6QzONQlD+oRfRr3EK+nVCosOz0BSP6iF/woF4NrONvtxZabxIDvz3z94pY59asbEttRKb4eJV8Rdipihe7sMpbY9tSDmTjVzFhWt53F0jmt/FBGgb1awW72NmqhKCxuPPhIyYAO4AmXuOmT23YUw1rDEjzt7ZeXpuY/kNdrrYr2M/hdcZOiLwu91qzph4bO0s8v/0sqM2+rHCBb6t5L2wjOSKX+UWrr+ANuZQFDldooMKesDFfdj6CgewYF1x6RKSvfnedsyUAUSrI818BxFV/1zD96NRejTe+tOoaA6sJfqKs0bnNxMEufmlZ323hvAYb7LKplVVfCiUoy4zpajcAYFMytntTN8gKx/J6U/KozDSbyOhFhmMFm2+PTgmTUoH54yYXUPEMJ+L45T1LbkQ/OgL9Hjfgh1A7J29TYHgpoGUuD/djNZHueWv/Yw== X-Forefront-Antispam-Report-Untrusted: CIP:172.205.89.229; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: vVgJHG+gdF9pHAj0eJ1rhvb2V0HEsqDDI8PY1Df9WPJhxXcjNXRkHRjs2uTAyMpNeGJOACiInXZ2un/nEiHfO/3ldrmtjCrCSgAqL+GhS7d0uyTx8ODSyraeeXPlb0F/v9Un1zuuLrUFA2MIFoXniwAqt8+t5jDj4xPhIoHBrvNA54ce8rzm5ceEQppazMoiRhOwwOXx6I5eCQGqHy6VC+Ty+DS37n9F7JDryGbCULBC6DJZ/0ZIYsVzveNo0djbIJ6IYZo0y5YmdIZMyXvnfUJyLiaswmB3Ft46n8Uph3i21F1GwePQuFPet139/jil8DEvCZIHPPdn8Ao79GBJ6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB11162 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D07.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 82f6714d-d608-4447-d8a7-08de79407f92 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|35042699022|376014|14060799003; X-Microsoft-Antispam-Message-Info: v7cbLkvMj4dunjXmfxIojed1KmtLfXQuO7vBNgAKaJYEzJUu/5FxUoXV4RteQV+YkdP/uzur8F52Z4X15nIESbqq9PyQ45PRIjp06SfHj+ezw2JgDXiP41bcTZO6vRn0frX9mkamyneLSj0jIVR2yLXzOzmzj3mq7+VdXGuXVQ4uqibguHIl5868T5w0XiYjukN5/T8eWlTMrvgoGGYN9bui91CTl4m41VduITIXgTkQ17Kgw4KrAEQtTw4l3ZyNTlD+/POd5HgnkJWNObo5WLM1ht4/JwjyAvK5qp1E1ZA04fK4IGgafk+8bK+ICwhhMxNm3zfH1UqY50DbF81f8CViLXmIWpx6/nhd4xnuBL7IiJauefEf8EtdCKCE+3Cm1Q57so3EnftdEc44oCGU0mMaDwX3fvCdKEkPu6ShC/gG946Cm3MnPgvRZYEr/CB9WoIoHHl+kp9rRBXXfnEDEXKiY5ZzbmE3rWH5whyews0jQ4wlJPju60V6YoSlj/6AuJgQDrMU+D72FMBJPPmgjK3f5pf9w4wuPPQSDwIjxckrL0yQhuqw35yMmS9x6tWk0TGukSP6XQ24WWWgDAK6uGDLhXcsrhgjihnWSFHmoy8rO/dGV8wj/WCQ5TvqAevg3lFhqfSgy4Z9DAdQ7PbpEX1SWMxxK1Bkub9LOaiRwzKMapCqDTY7aJFF04MVpR+hmEUK4QybegWS8NRd/k4HIwE+tIRJw4sVF+kez8PT6q47zn3dLnjvDczjuSBmfA6tAHaeKZQ4AckgA32juInX40MUnNZwSrYO41or3dVgOsyE7tvBveYdCp6gFQge5RSlvzHKNIW7JGLdI5gnjHYafg== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(35042699022)(376014)(14060799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Yoc/JHKumpLaxILuNJ9xM4zWEso7/vChWhw/uzXl5Rn88MC3bUJN0oj8lT2XwJX3QRt8EQ8YBjXQmz0mlc8uQIuqIM/wexAnqZZLCfvNv9Y5udKiyHgcsMW3rembueJiBc4Tyz1eHGCTzn/X8GCJ5sG/1LUT8NmgjHbyddKoTZOldhML8SOeNaopPttpwTJ4CBiqWnzrHD5vApV3x3RTnm+Y6MNa+OU3nakWOUP5jxY+6yyOEktzM4txBKHQXsBhBe6EA27x1AxJFbIwmEMx1qX9x0GrGCWjMQrWBjqLTnzEpo4ysgFLVBHEe/0HiALUcxXss/xWAceLYbuyFTAD5ksOwXr+OdwdVkPXW7XuzAkXvP94LjEAfkjFs4nVwt7YonAwJt32xiSmIDTNkpJVEoz6HHogUOwxTb7mDMISM7bYXbFxo9JStz2Aoa099++n X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 16:19:32.1004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19df50a5-b83f-47d4-d831-08de7940a718 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D07.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8803 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Passing 'gdbpy_ref<> &' instead of raw 'PyObject *' to init helpers makes ownership of PyObject clearer at call sites, and removes unnecessary '.get()' calls. Changing the return type from 'int' to 'bool' improves readability and better expresses the success/failure semantics. --- gdb/python/py-objfile.c | 27 ++++++++++++--------------- gdb/python/py-progspace.c | 22 +++++++++++----------- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c index 5d7cfe83ec2..feae62c32a8 100644 --- a/gdb/python/py-objfile.c +++ b/gdb/python/py-objfile.c @@ -198,36 +198,36 @@ objfpy_dealloc (PyObject *o) /* Initialize an objfile_object. The result is a boolean indicating success. */ -static int -objfpy_initialize (objfile_object *self) +static bool +objfpy_initialize (gdbpy_ref &self) { self->objfile = NULL; self->dict = PyDict_New (); if (self->dict == NULL) - return 0; + return false; self->printers = PyList_New (0); if (self->printers == NULL) - return 0; + return false; self->frame_filters = PyDict_New (); if (self->frame_filters == NULL) - return 0; + return false; self->frame_unwinders = PyList_New (0); if (self->frame_unwinders == NULL) - return 0; + return false; self->type_printers = PyList_New (0); if (self->type_printers == NULL) - return 0; + return false; self->xmethods = PyList_New (0); if (self->xmethods == NULL) - return 0; + return false; - return 1; + return true; } static PyObject * @@ -235,11 +235,8 @@ objfpy_new (PyTypeObject *type, PyObject *args, PyObject *keywords) { gdbpy_ref self ((objfile_object *) type->tp_alloc (type, 0)); - if (self != NULL) - { - if (!objfpy_initialize (self.get ())) - return NULL; - } + if (self != nullptr && ! objfpy_initialize (self)) + return nullptr; return (PyObject *) self.release (); } @@ -682,7 +679,7 @@ objfile_to_objfile_object (struct objfile *objfile) ((objfile_object *) PyObject_New (objfile_object, &objfile_object_type)); if (object == NULL) return NULL; - if (!objfpy_initialize (object.get ())) + if (! objfpy_initialize (object)) return NULL; object->objfile = objfile; diff --git a/gdb/python/py-progspace.c b/gdb/python/py-progspace.c index 146360d890d..15f7fbead65 100644 --- a/gdb/python/py-progspace.c +++ b/gdb/python/py-progspace.c @@ -166,40 +166,40 @@ pspy_dealloc (PyObject *self) /* Initialize a pspace_object. The result is a boolean indicating success. */ -static int -pspy_initialize (pspace_object *self) +static bool +pspy_initialize (gdbpy_ref &self) { self->pspace = NULL; self->dict = PyDict_New (); if (self->dict == NULL) - return 0; + return false; self->printers = PyList_New (0); if (self->printers == NULL) - return 0; + return false; self->frame_filters = PyDict_New (); if (self->frame_filters == NULL) - return 0; + return false; self->frame_unwinders = PyList_New (0); if (self->frame_unwinders == NULL) - return 0; + return false; self->type_printers = PyList_New (0); if (self->type_printers == NULL) - return 0; + return false; self->xmethods = PyList_New (0); if (self->xmethods == NULL) - return 0; + return false; self->missing_file_handlers = PyList_New (0); if (self->missing_file_handlers == nullptr) - return 0; + return false; - return 1; + return true; } PyObject * @@ -593,7 +593,7 @@ pspace_to_pspace_object (struct program_space *pspace) if (object == nullptr) return nullptr; - if (! pspy_initialize (object.get ())) + if (! pspy_initialize (object)) return nullptr; object->pspace = pspace; -- 2.53.0