From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lX/MGYC7pWmU8BAAWB0awg (envelope-from ) for ; Mon, 02 Mar 2026 11:32:00 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fovM2A7k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 550691E0DD; Mon, 02 Mar 2026 11:32:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 49CD11E089 for ; Mon, 02 Mar 2026 11:31:59 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A72A54BA23F2 for ; Mon, 2 Mar 2026 16:31:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A72A54BA23F2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=fovM2A7k Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 372294BA23C7 for ; Mon, 2 Mar 2026 16:31:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 372294BA23C7 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 372294BA23C7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772469093; cv=none; b=hb+H905eOGQ5+KeoHJ5ex1DklF8SS/KaGJyqOwQbIFugYEKFUc53ZacMQc8aI4Q0ZA71aGW5WsUnYCkNX1X2a78nCUrDQxrlbwb0uScj4n5bxZDAmotdCMk+ffnV4fMfdRRJ0B6G89xX/Wksb1A0LURb5BsCzLK2Y61Q+OCKKpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772469093; c=relaxed/simple; bh=ElCgJGnuiG/ueBB4hF+4RyYdHxrhbM+cDWGaOPlQo0A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TdAVcAr04yD5gxoUm325pqm5SGqiAWu2vyzRCnWSiwx54lPqer29SEY/Z4DZGlgqEMIWBBKzuAmXYcFuFbbUwqwy/iL9SraoaN6UBn+hcWJEQ2QrUBhNKOALhr1PFQkE4+1oGsL+eQnRUlDksjhY7qJEDAnaM9NKkPiTDXI9mcY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 372294BA23C7 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-7d4be7c4ebeso2248625a34.1 for ; Mon, 02 Mar 2026 08:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1772469092; x=1773073892; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3cnusIyy8GBRd6jpEVnHGlOatz+4htN4KCupbnTniK0=; b=fovM2A7kPJtC8z7XzO18D1rQM+DAng9/nUgKJJ0KabKOoiz5G5OIi/X25fIeqzBH2L lg5WQ/DBPAC4Uo7vls5NZ+EflPk56tb3m/QXHsU/3AOcU0e5il71vQaXzKgk39nop8ga iBhx7+7qQ0qk3+Z4ECo/B49l+SS2x2WJbIAYDJhQ/nU71/Ju0R7mkRdb32ADYqSeTYUi 4ncbYaOj54LesKno3MHTUNPyhxxITsMivCm7zE+tgao9Oo8LDNJWk1qMPhyqEprpuJ8B HBaSFRa0HTNg3piJyB7Xle0SwNw2+Hl2VWlCs4P+wihZoTttOx9zTDyePLg0E/gU+TP0 ezhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772469092; x=1773073892; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3cnusIyy8GBRd6jpEVnHGlOatz+4htN4KCupbnTniK0=; b=VKDsnvclblT7Bk39d1AoOJHb6VfDC6Czvz1tkUCOCIYENIf+ZH+YPrn64a5aMRPS+w ApoNH1IVYadX2mAjhMjFIvRc81nPWLSE6Eris0a2MfNOTeOqYqrQCumHoilfSOso8GIr 8Ng2hMZszCRzuaqRwsFAXGK6gBlYEi+vd7eM8sMhzHfDU2T5XSEf34ivTFHp9CO/EDx2 YpHEZGiZ+6Nw4FNauumZakRvIzyvMgUHQuEf7SWN1ptzwIK19gVOByTsStCbbsSmR81+ Pklg+3Nh1LcMi+ya1XRQ/seL3gpIgONvmhJ66C2YQm+Bq2WV/dJozG1SmU0Rg5dmr2+k tp0w== X-Gm-Message-State: AOJu0YyMT0GvkEbDAETWhwKAkzD5MpnelEQa0CesLE4CEFLpZEoddTCO U8ruWTz9ehL0ie/jFMz/S5GCm3Wwe2hwSxO3jUGOXZrO524GvVk5ZjHS+kgaoyeJtKxjWoVc37n qJEs= X-Gm-Gg: ATEYQzxdsWe59EWhkVhZY5zPptRNUmXDlTM+Pr6o5md4Ks+SzRm7nc4HaOWtKMyyJn8 OTQYmPvaAj1179dhZHeL9PLkZjBMtRttpPOdKWzBzpcKyZCadmmvk90QKvVLjch7SAEwSl+N+sA HG9t611hmI6cFk6gu1AFZgOmZte9bXIgyAJMNPrQGxQzuK2jXPFCo4a6czSRf2QTD96m+yEtuO7 A9TYa2nvnJaS+MJ08ZGxqtJnu6Gos25w/5+2HelAHb+/sp4IQalQlv53CYB5EAQXdYkfHq0KB09 JURInm5kjqjYhwYvRBdB/atuYmj3VHm7sXDwnF/hngRBXWVHYSUG/S/yKyd4hQu6SiOI4zoS+RL ofIhA0QLpEO/cqppVvjHTIr1pesx1mthfXcwJdu/nDeRfGa5YM21cGxuEi+1jWc0VpUTlsb7oAI 3QA3nm/ruWtDiszcdDLEBnDd3k2MsPZ7AA0m2QgwYc7B9qYg== X-Received: by 2002:a05:6830:67fe:b0:7c7:2e9d:aee1 with SMTP id 46e09a7af769-7d591bc1e17mr6656891a34.19.1772469092477; Mon, 02 Mar 2026 08:31:32 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d5866541e5sm11106525a34.20.2026.03.02.08.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 08:31:32 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use gdb_bfd_openr in corelow.c Date: Mon, 2 Mar 2026 09:31:29 -0700 Message-ID: <20260302163129.610391-1-tromey@adacore.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org corelow.c has a couple of calls to bfd_openr, each followed by a call to new_reference. It's cleaner to use the provided gdb_bfd_openr wrapper. --- gdb/corelow.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index a28a707c293..84f44bc680e 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -451,10 +451,7 @@ core_target::build_file_mappings () gdb_bfd_ref_ptr abfd; if (expanded_fname != nullptr && !build_id_mismatch) - { - struct bfd *b = bfd_openr (expanded_fname.get (), "binary"); - abfd = gdb_bfd_ref_ptr::new_reference (b); - } + abfd = gdb_bfd_openr (expanded_fname.get (), "binary"); if ((expanded_fname == nullptr || abfd == nullptr @@ -474,9 +471,8 @@ core_target::build_file_mappings () type. */ expanded_fname = make_unique_xstrdup (bfd_get_filename (abfd.get ())); - struct bfd *b = bfd_openr (expanded_fname.get (), "binary"); - gdb_assert (b != nullptr); - abfd = gdb_bfd_ref_ptr::new_reference (b); + abfd = gdb_bfd_openr (expanded_fname.get (), "binary"); + gdb_assert (abfd != nullptr); } } base-commit: c995b827636ecaad5454cc89bd7fc226c6a4fd33 -- 2.53.0