From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6bF8JWaroWlMmgwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 09:34:14 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=kIu89dOl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 93AC21E089; Fri, 27 Feb 2026 09:34:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5BA91E089 for ; Fri, 27 Feb 2026 09:34:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 53AE14B9DB6A for ; Fri, 27 Feb 2026 14:34:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53AE14B9DB6A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=kIu89dOl Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 21C054BA23C2 for ; Fri, 27 Feb 2026 14:33:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21C054BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 21C054BA23C2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772202828; cv=none; b=gEagBQv6o87CztdaYJuajXZ4j8f9cphGQW8qoVB98kX3W1h+FpFmZoELEDOkXyR/IniMkSoyY4EArrPQ4lVc9msx5FS0FZIdY/bhkw+Ygi57/Uguy398QLhIqS2aLyyIpTEHYNc86pMV1OlrAkL8c9Jv9zIUkR6Cm9c/IVLBx3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772202828; c=relaxed/simple; bh=4NzPIW31bK9rGxXy+/SmMfrQ75fxtJ0Koj1IKH90BHg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AI3bdRMNV9ikP5AGMzIbcYIPBNoYpYRuE4UgjnP0D1EKHvar7crkzqEJQuhxl5BIHiB72lFd0qvF3m9WZfKYOUtZU6GR7Ra/tBBdgP7XgnG9AUyJ7Uge4KrLEibB5vt3Y2ykr1R9YGu1+jBF679z4Jd6Gzb8i2mR8vioNK82ajo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21C054BA23C2 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7d596ab0917so363232a34.1 for ; Fri, 27 Feb 2026 06:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1772202827; x=1772807627; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TepqqT6jk4Mc8BeqxGG+IZFIpxuT9s9/zMPhlvfaPNc=; b=kIu89dOllySeh2F7g7E5LhsCJqw+r37S/BFrnFKA6sTbyDc6xXyIBqpOFdrNz/GYD2 Aa6GA+OEeF+1Vqi3KmjLEJ8RfuRdOdvScSycjO5hImS1Yymp3vCjfKFAh3zwekr5AgYF J73TyJAx1KyZ5lJuhFR787NU3B8kDOmebcoVjbuW0MwpFciujM0DLB08+vlfKV/0ungY ORNJlFEAsXgfTVM68nnwP9fV+disCKQDfq8O4vxtlXAxK03hdy9bNEpn7sJWSDCqpW8Q FTarYzZqT+U6BjyBzMg+/O0pVK5c68AL5lJcsMPueiMERqt2/s+8hmd3QPYEyof540qs t+0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772202827; x=1772807627; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TepqqT6jk4Mc8BeqxGG+IZFIpxuT9s9/zMPhlvfaPNc=; b=VPixO2WAJUGEzcTNX+2KI06z2Mu0c7trGfAAU9BJ7vWXWV2tp/gy7JazCl3oCIqMW+ 7p2+vxIcW7ZIafilSE1N2kONMJ7Am35QZZz+G3WIHTEveM/A8a34F5RzTtVlyWOAQpoA ZwXassvggZkJIC7bAt1hNyqYc20Aiwrqtbnzq/XdmAXea02nVXSQX5JPo/dEH0HlquuH N00llt3IO0hIl5I1/w5nFo470ANyIlRzyixA9xMBoHqlpntXWCfREq0TbkhFh1FMFl0R VbX5mUuXv03Rp92corJbGPAnIrq5Zfs1uSaq5g5gHk9aeJ0wfDXTaWtI0ACYqE4NvrUH EjCQ== X-Gm-Message-State: AOJu0Yz5gtFcWFZBhudWUITULm/hbTKtKB7/WgSdjpnSibSm5SQ/smyn tAVNbUYh6NTflJTsLORUejjixLAI1lgG/xwp9C2/D8Y4nXSMWuaT5gOUyk9bMCAjYE7gFuozbTO J6es= X-Gm-Gg: ATEYQzwAbCN/RVE5NCEhDfSPCBNHo78O5sgRvPFfHXV7BSDjWX3PZc4dt9EHTLWPHvR +VwsWC+So+MU3o7HXXxE5EG26EO5S+mUcNVbV7fHGwg1HHW5t8HfMwXLg4NhcVrjslBWs+zPWMh CDDmuHfH1kCejP/9e4z0UVVGpprJIYLi62E84fzR0PvyXe+Az6gv1zzPZMyWvEKVRV4PJqvkXi8 QEVCdeU3NczovTNuFlNVXMxB3asy1CzICDebb6U6gokYZqVhJNbhRo9BPwxBzB4hKmMsMfKZmaK gIJRO6uyPp+oHWYSbxSFyhiwn1JsUtklKETiHN4EmiHJ5wgBAyWj4OFy3Mh8N/8pNTmXXXvp5mJ SLiGPddHsGndFyg4Dgb2P5oBD80/N4zitfuj8LXw47PPXnZvvr1+zncof1G2gbKF4frtGF3eozc Chv3ZDV8BvTHCEJJ5wUyZKjH/FDJwZr5OXtfvUlbZm9OFO6RUBXhJp9hdN X-Received: by 2002:a9d:62c3:0:b0:7c5:38d2:fe1e with SMTP id 46e09a7af769-7d585760321mr3165808a34.11.1772202827424; Fri, 27 Feb 2026 06:33:47 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d58666f30esm4313987a34.26.2026.02.27.06.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 06:33:47 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Compute register name once in default_print_one_register_info Date: Fri, 27 Feb 2026 07:33:43 -0700 Message-ID: <20260227143344.333820-1-tromey@adacore.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org PR gdb/9884 points out that default_print_one_register_info could call gdbarch_register_name a single time. The current code seems harmless but OTOH the proposed change is also harmless and perhaps slightly faster, so why not. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9884 --- gdb/infcmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 319d17d95eb..d0d1c142041 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2505,11 +2505,12 @@ default_print_registers_info (struct gdbarch *gdbarch, /* If the register name is empty, it is undefined for this processor, so don't display anything. */ - if (*(gdbarch_register_name (gdbarch, i)) == '\0') + const char *regname = gdbarch_register_name (gdbarch, i); + if (*regname == '\0') continue; default_print_one_register_info - (file, gdbarch_register_name (gdbarch, i), + (file, regname, value_of_register (i, get_next_frame_sentinel_okay (frame))); } } base-commit: e302db71359c85e3c1f1eb90e8f0aaa06ee81752 -- 2.53.0