From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Yhv+JqhcoGlINwsAWB0awg (envelope-from ) for ; Thu, 26 Feb 2026 09:46:00 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=er4x/SVm; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5+5Sz/Cl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=er4x/SVm; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5+5Sz/Cl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 814F71E0DD; Thu, 26 Feb 2026 09:46:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6E3DA1E089 for ; Thu, 26 Feb 2026 09:45:59 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id F24054BA23D7 for ; Thu, 26 Feb 2026 14:45:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F24054BA23D7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=er4x/SVm; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5+5Sz/Cl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=er4x/SVm; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5+5Sz/Cl Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id EE8824BA543C for ; Thu, 26 Feb 2026 14:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE8824BA543C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE8824BA543C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772117131; cv=none; b=rwHIu99Zagpn8WRa6R1PhKN7xP7G7WhiBKX1GjkcorQh3ZQbXb1L2lnmhntyEWXcoCAh6/FIM2Mqt81dgElzTmBYQ2eEXIJBfbNoRuIM+7043lTrIdZKFOVa44EDXx4krqAiCud39DgDe1jIRhs6qKEyL7kno9bLR8AeluPId5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772117131; c=relaxed/simple; bh=EfwgYbx1o1NncXyujulHov0Q5neOFDUIHvsyMEJ4nTQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=M/9r7sPKEnx8lcq3SjpkYJuAklCBP0tNm7EqsYcEZm6cF2B+IbiFJFL70xZtcJYWRcEr9KMkFKczBXWzHG9PZIITvUwUqzn9H0fQIBTTTppjlQHwxHWwfCMESbKyZj8Pq5K1wRQ1eVKaiwF1sWf/PS6hfDVYhmTl0zJu7+v5vhM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE8824BA543C Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 044A63FF78 for ; Thu, 26 Feb 2026 14:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772117130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SLB48KUsBvTA1x7CTr3+3aiInrBXJ5jKtCQ4hy72xSI=; b=er4x/SVmJmk0tox2vUiqb6D8vbKcrTfYxsQ6mV4abXsLNMFzpWkyVDonisMCvXWsCPK7NZ Hpya3xLfrPY+R1vVrBu/TLiiybGtgUmPAUFrrv6s4Q1e5pABUG0GSRMBbjN91gMW23fqgm rrsjgIDZI5uHsPsvO/RCBdw+kiH+/54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772117130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SLB48KUsBvTA1x7CTr3+3aiInrBXJ5jKtCQ4hy72xSI=; b=5+5Sz/CljUKqnLwcswk1EXzqF++7o1EL+GOeI0WdjUNOkIewqsTvI6Vh8AmfuzQe9A4wSi jyfvRbP6TN8aQ1Cg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772117130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SLB48KUsBvTA1x7CTr3+3aiInrBXJ5jKtCQ4hy72xSI=; b=er4x/SVmJmk0tox2vUiqb6D8vbKcrTfYxsQ6mV4abXsLNMFzpWkyVDonisMCvXWsCPK7NZ Hpya3xLfrPY+R1vVrBu/TLiiybGtgUmPAUFrrv6s4Q1e5pABUG0GSRMBbjN91gMW23fqgm rrsjgIDZI5uHsPsvO/RCBdw+kiH+/54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772117130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SLB48KUsBvTA1x7CTr3+3aiInrBXJ5jKtCQ4hy72xSI=; b=5+5Sz/CljUKqnLwcswk1EXzqF++7o1EL+GOeI0WdjUNOkIewqsTvI6Vh8AmfuzQe9A4wSi jyfvRbP6TN8aQ1Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E294E3EA62 for ; Thu, 26 Feb 2026 14:45:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lvr3NYlcoGmjLAAAD6G6ig (envelope-from ) for ; Thu, 26 Feb 2026 14:45:29 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/record] Fix syscall recording some more Date: Thu, 26 Feb 2026 15:45:29 +0100 Message-ID: <20260226144529.360296-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I ran into the same gdb.reverse/sigall-reverse.exp failure on ppc64le-linux, as fixed in commits: - commit 3686645cec9 ("[gdb/record] Fix return value for svc in aarch64_record_branch_except_sys"), and - commit 4ef576bdb7f ("[gdb/record] Fix return value for syscall in loongarch_record_syscall_insn"). The difference with those commits is that the problem is not due to confusion about a port-local enums (aarch64_record_result, loongarch_record_result). Instead, the port just treats return values 1 and -1 the same: ... if (tdep->ppc_syscall_record (regcache) != 0) return -1; ... Fix this by passing through the return value 1 instead. Likewise on s390x-linux. Tested on ppc64le-linux and s390x-linux. --- gdb/rs6000-tdep.c | 5 +++-- gdb/s390-tdep.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 8aa155e1f36..7d0902941a0 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -7187,8 +7187,9 @@ ppc_process_record (struct gdbarch *gdbarch, struct regcache *regcache, if (tdep->ppc_syscall_record != NULL) { - if (tdep->ppc_syscall_record (regcache) != 0) - return -1; + int res = tdep->ppc_syscall_record (regcache); + if (res != 0) + return res; } else { diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c index 6cf5acbc542..f52e898047b 100644 --- a/gdb/s390-tdep.c +++ b/gdb/s390-tdep.c @@ -3242,8 +3242,9 @@ s390_process_record (struct gdbarch *gdbarch, struct regcache *regcache, /* SVC - supervisor call */ if (tdep->s390_syscall_record != NULL) { - if (tdep->s390_syscall_record (regcache, ibyte[1])) - return -1; + int res = tdep->s390_syscall_record (regcache, ibyte[1]); + if (res != 0) + return res; } else { base-commit: 96cc0a530d58d96a81b1c30247de79812f1d4538 -- 2.51.0