From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4QpRMlr8nGlE8gcAWB0awg (envelope-from ) for ; Mon, 23 Feb 2026 20:18:18 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Ain1BSdf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C8F881E0E1; Mon, 23 Feb 2026 20:18:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CA22F1E08D for ; Mon, 23 Feb 2026 20:18:16 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 513294B9DB72 for ; Tue, 24 Feb 2026 01:18:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 513294B9DB72 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Ain1BSdf Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 8355D4B9DB54 for ; Tue, 24 Feb 2026 01:16:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8355D4B9DB54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8355D4B9DB54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895819; cv=none; b=fP1Gir8+HQWHrjG2PV/F1YV0hk1LBTrA9t+BYYQKt8aIj7MixTCpV64gBlxfEB3aiANc6kheuSb5tq1EliX+7xb5rAIRW+d18kHG0y6XUMiPeOwEl6ZMbSeIA2IqGx2khodZ6d4FybroaAHO2pJThgtDI8uzdCjVxtIttZA+37c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895819; c=relaxed/simple; bh=YPtvjBGmQ10T+v+TFH/2zSj7zb//0HQFbsXPhQyT3NM=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=uBIGheC8lEWfZztX5MbnjCzC4TFqLF3DDrm+E9ZiReCS2A4/nTCffeSpe5h3+5fPw43aL+4xvVI6qxxtUgWCRlIVmWwzkgIJmknmSGe/uL0EYmEjqqwnLDxlhn5LNu0up7Qd1zjweKJ5BTgfgADjElH/+GLZODUWb4iuc9Bk6Lo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8355D4B9DB54 Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id uc6Av75JRCxrGuh2pvPSDw; Tue, 24 Feb 2026 01:16:59 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uh2ovz0xQK8vzuh2ov0rJe; Tue, 24 Feb 2026 01:16:58 +0000 X-Authority-Analysis: v=2.4 cv=cJDgskeN c=1 sm=1 tr=0 ts=699cfc0a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=B_Tv2JfvxkIVyvo0GuEA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T4+AKks6nncK4kK83j8Tt9BUbTZdyie5TxKUK3X2AbI=; b=Ain1BSdfAV83693gJUAMU+TjAY ll3M8l8Qcvd0IvR9OfsGFoRg8bKxapuktLPybf5T3NRMh2ETS4mAGrYW1gUK8VjfAU7JRCgH6oIH2 qt3/VDAwCd4jG6gBKiE0R7yAY; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:51428 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vuh2o-00000000sJg-0Ilx; Mon, 23 Feb 2026 18:16:58 -0700 From: Tom Tromey Date: Mon, 23 Feb 2026 18:16:55 -0700 Subject: [PATCH v4 2/8] Skip partial units in process_psymtab_comp_unit MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-2-bf923dc5fb19@tromey.com> References: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> In-Reply-To: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vuh2o-00000000sJg-0Ilx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net ([192.168.122.1]) [97.122.122.234]:51428 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFnYH3ZnRvJI/peR4EUfKVr7/GFGSX+gjM2eAlDKvHvdY7R4bHyUnbwwgYEcSoBd/nM03TWybksiUfoumDHwDIutGSBvAAXjR6yxi44CopeyiXDYNSJp 6QIKcSYRv5WHPh08osvZc2fEOjY+Bk377sCOOKBU+DjNA1lYFdpwYrlQiyPb95XW6NTYi2kp5XIJVMbzp0p8z1fLpOkQMnRTEIo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org process_psymtab_comp_unit passes 'false' for the 'skip_partial' argument to the cutu_reader constructor, but then proceeds to skip partial units. This patch simplifies the code by passing 'true' instead. --- gdb/dwarf2/read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 302b137526f..2cbdd7c6dc8 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3373,7 +3373,7 @@ cooked_index_worker_debug_info::process_unit { auto new_reader = std::make_unique (*this_cu, *per_objfile, nullptr, - false, std::nullopt, + true, std::nullopt, storage->get_abbrev_table_cache ()); if (new_reader->is_dummy ()) @@ -3387,7 +3387,7 @@ cooked_index_worker_debug_info::process_unit if (this_cu->is_debug_types ()) process_type_unit (reader, storage); - else if (reader->top_level_die ()->tag != DW_TAG_partial_unit) + else { bool nope = false; if (this_cu->scanned.compare_exchange_strong (nope, true)) -- 2.49.0