From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QXwXBEv8nGn38QcAWB0awg (envelope-from ) for ; Mon, 23 Feb 2026 20:18:03 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Y1sooBtj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 077B71E0BA; Mon, 23 Feb 2026 20:18:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E853E1E08D for ; Mon, 23 Feb 2026 20:18:01 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 51D3C4B9DB7D for ; Tue, 24 Feb 2026 01:18:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51D3C4B9DB7D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Y1sooBtj Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id B1D1A4B9DB64 for ; Tue, 24 Feb 2026 01:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1D1A4B9DB64 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B1D1A4B9DB64 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895818; cv=none; b=C72NGro1TRxg/Vz0E2fAGrPCBIv64xdyBEdnAbyJjVp/vXY77jLIiJGipNjPQXHMs0yUZ3mOpBaqOKcwrX0eUlKJxia0CPELDhwkdXWeUZfsDr6KoLyg91zzX1/1Bg2iQtlUlEXyE2pZ1N35gGXHFYm51vjDbs/b0N6W1+ZmuQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895818; c=relaxed/simple; bh=s+amAY3dtw2jJvR7xXSrYTpuQhYT3yXFcQtQ4PaZgz4=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=UvkTetxqDvw81siatAI3zGtCnprzc3ImDQRWkraD0ggWyggnwxgmHgIO2rKhs2I9nYgUUg/ddo0M8dgRVuCiMZTY6u5qXW05k10Tn38RDJVNoUaa97ujnb3hHlDFR2FBwdWbfgFbF4sga1VdwYQO828BZSo2mTU2PoYKkBp8QZw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1D1A4B9DB64 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id ucA6v76ZSCxrGuh2ovPSDj; Tue, 24 Feb 2026 01:16:58 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uh2nvG8IkN3K1uh2ovSo9h; Tue, 24 Feb 2026 01:16:58 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=699cfc0a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=3Fx7I0CSB0swmR94fG8A:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sugE34VnTx7SgZbL4Xf9dF551Me+fwf0ecr45Gi5Zxk=; b=Y1sooBtjEKjdzdfr0qj+Kx6ifO cg67K1rl8cUW/SCKvPo+9WWuSV2RgIG9gw5TZnpEd2AdQNcOdsnDRexRzq+Lx/aKM8YSBBEP9WdWC Q/Yc5tIZdpp/vGg/18pq85FSu; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:51428 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vuh2n-00000000sJg-2XpS; Mon, 23 Feb 2026 18:16:57 -0700 From: Tom Tromey Subject: [PATCH v4 0/8] Correctly handle inline functions with dwz Date: Mon, 23 Feb 2026 18:16:53 -0700 Message-Id: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAX8nGkC/5XOQU7DMBAF0KtUXjNgj0PjsOIeiMU4mTQjETuyQ 9qoyt1xugHEpiy/9Of9uarMSTirl8NVJV4kSwwlVA8H1Q4UTgzSlaxQ41EbfIbuDBI+JDD0cvm cYEqQ13EmD1bX6AChbq3xvXW9Z6uKMyUu1dvG23vJnjKDTxTaYZdjkpOEp5HyzGnvD5LnmNbbS 4vZr/6zvhjQwE1TW6qo0oZe5xRHXh/bOKp9fsGf5PEeEgvpyBtnO9MY0/4h7TeJqO8hbSEbR1x YdD35X+S2bV8LB3GBmQEAAA== X-Change-ID: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3 To: gdb-patches@sourceware.org Cc: Tom Tromey , Eli Zaretskii X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vuh2n-00000000sJg-2XpS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net ([192.168.122.1]) [97.122.122.234]:51428 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHLKAfCiIQoPpwlsYs+A4PVmaYG7hF8kBz0T65YjRTXqBOhtKxo5tiDl2/6JhjHMvhAufYPxw1X+ADlR80cgxw7Ibpa1nZA002OJCnh08nk+/qSlLCJd TnyeypDG6AWmJSTK+sVFs8uIA1s+ziISUvEa4FQU5+WpMmCTOf7euyha0dVDNcfbi1unMZA0hVKZkR+4azLxmZbd9sTNu8+Nz3Q= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The new indexer does not correctly handle inline functions when 'dwz' is used to compress the DWARF. This series fixes the bug, cleaning up a number of other things on the way. I've separately regression tested each patch in this series on x86-64 Fedora 41. I've also regression tested the series as a whole with the dwz, gdb-index, and debug-names boards. Even with that I messed up somehow, so v1 didn't actually fix the bug in question. I must have modified the patches after testing..? Anyway in v2 I've moved the line recording the CU inclusion and added a comment explaining the placement. I re-ran the aformentioned tests and didn't touch anything. Signed-off-by: Tom Tromey --- Changes in v4: - Update assert in .debug_names writer, and add regression test - Link to v3: https://inbox.sourceware.org/gdb-patches/20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com Changes in v3: - Minor updates per review - Rebased; which required some changes to the iterate_over_one_compunit_symtab patch - Link to v2: https://inbox.sourceware.org/gdb-patches/20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com Changes in v2: - Fixed fix from Tom de Vries for IS_INLINED debug display - Moved line to record inclusion - Link to v1: https://inbox.sourceware.org/gdb-patches/20260125-dw-inline-fixup-pr-symtab-30728-2-v1-0-e9973a4a401a@tromey.com --- Tom Tromey (8): Don't call add_dependence from index_imported_unit Skip partial units in process_psymtab_comp_unit Don't consider DW_TAG_inlined_subroutine as interesting Combine two cases in cooked_index_functions::search Remove C++ special case from process_imported_unit_die Have iterate_over_one_compunit_symtab search included symtabs Handle inline functions with dwz Update .debug_names documentation gdb/doc/gdb.texinfo | 37 +++++ gdb/dwarf2/abbrev.c | 1 - gdb/dwarf2/cooked-index-entry.c | 24 ++++ gdb/dwarf2/cooked-index-entry.h | 39 +++++- gdb/dwarf2/cooked-index-worker.c | 14 ++ gdb/dwarf2/cooked-index-worker.h | 26 ++-- gdb/dwarf2/cooked-indexer.c | 60 ++++++--- gdb/dwarf2/cooked-indexer.h | 8 +- gdb/dwarf2/cu.h | 6 +- gdb/dwarf2/index-write.c | 224 ++++++++++++++++++------------- gdb/dwarf2/read.c | 85 +++++++----- gdb/dwarf2/read.h | 37 +++++ gdb/symfile-debug.c | 23 ++-- gdb/testsuite/gdb.cp/breakpoint-locs.exp | 8 ++ 14 files changed, 415 insertions(+), 177 deletions(-) --- base-commit: 2a2b24ecc13988a6d87619f53b36faa2bcb61beb change-id: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3 Best regards, -- Tom Tromey