From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aP3KE5jRmWmtNQQAWB0awg (envelope-from ) for ; Sat, 21 Feb 2026 10:39:04 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NA/a/5yt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mxT3n+Vb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzFJpS2/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nUDdeuR4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3BCA91E089; Sat, 21 Feb 2026 10:39:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 60CE61E089 for ; Sat, 21 Feb 2026 10:39:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 35DBC4BA23FA for ; Sat, 21 Feb 2026 15:39:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35DBC4BA23FA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NA/a/5yt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mxT3n+Vb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzFJpS2/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nUDdeuR4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 526664BA23CD for ; Sat, 21 Feb 2026 15:38:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 526664BA23CD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 526664BA23CD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771688313; cv=none; b=S6Wif65chx3ozeNwlX/QUyy0c+tQRvRw87luBVqGr6s+kAFOFNH3DMX/lq84bC7Emsw6e+ykWfvE7PZaQ/buVYoSv+MrWnlRV4HjlsOQ8nV3eZnq4kibRiSnasMy1cDBM/Du3oW4Wtw6xCaBaFknmBaDjceqyt8HGSiFJmolAso= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771688313; c=relaxed/simple; bh=veiJc5ejMcBt06XQlY49gYO4nLUWzKeWnZ5qJeyjkZs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=D2HmBPyUJt80HRO5OJ17QKEmDJkda/OZ9O4h/FmRkasefiLtwqpHJeujkKtCEmYt5sEIbgTtv6AvyPW3yHtuwvmNP0HcczTylf0YQjR9BOBXaN1OFQQTEIS/0xF7dSeDxXGpAuK0qUibRDdNld5Cc9Pwdow1XjBiNsfvviKIfPo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 526664BA23CD Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DBF9C5BD4F for ; Sat, 21 Feb 2026 15:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771688312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mGl7vXfgg6YDUUgqLLcsAiPJJ4GuglN6CivnaRmQFSM=; b=NA/a/5ytZ9hZ9+5d3VaMM8dPClCwN3OZWaeBJyc32UiWYEQ28TOrKmAb9U6xpJxsKglHyz 2TLKfovy1BVzm5xge5qhkZZBwz63VmaqXVb0BEngPoiwtRwnAZiXHtoSOv2HW6eqEQjV4Y T7uMMqNEYWJYKguxVOsErVC1m/5O5KU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771688312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mGl7vXfgg6YDUUgqLLcsAiPJJ4GuglN6CivnaRmQFSM=; b=mxT3n+VbH/TEnX/5cd+tXbIxUC+DsVSzBnQ57BH5ZpKuftL9e3IPILwDVsAPw9nTunPKwv kykIaaR3RnHiPnCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="uzFJpS2/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nUDdeuR4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771688311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mGl7vXfgg6YDUUgqLLcsAiPJJ4GuglN6CivnaRmQFSM=; b=uzFJpS2/dLEi/6i3y9kXpFE61K8HtaP8jC2u3/y4brk+TrgQuq13xzDRZ2xoSbYR2MaUET CsEhRNHLKA/y3yQTOwh/8HX6INaPHsDyyw+JDM4tvS/DL+48e8vjyjzBvHEDkkBw9aibOQ i4Rr0X9bSPNACMEgkA03dkv03w5mMyY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771688311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mGl7vXfgg6YDUUgqLLcsAiPJJ4GuglN6CivnaRmQFSM=; b=nUDdeuR46e0a8iFVr836F9t1or3UrCLdLE7F0QmK7vp3ZhkGga4c91XSyDGTA9V6YiqeLX MMSEctMF5dOejVAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B0C833EA63 for ; Sat, 21 Feb 2026 15:38:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rhkmKXfRmWkLfgAAD6G6ig (envelope-from ) for ; Sat, 21 Feb 2026 15:38:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/tui] Make tui_setup_io more robust Date: Sat, 21 Feb 2026 16:38:31 +0100 Message-ID: <20260221153831.2743758-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[suse.de:+]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: DBF9C5BD4F X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The following sequence of events may happen when enabling TUI: - tui_enable () is called, - a SIGFPE happens, before tui_setup_io (1) is called, - the SIGFPE triggers handle_fatal_signal, which calls tui_disable (), - during tui_disable (), tui_setup_io (0) is called, and - tui_setup_io (0) tries to restore things that were saved during a previous tui_setup_io (1) call, but tui_setup_io (1) was never called so the saving never happened. This can cause current_ui.m_ui_stderr to be nullptr, which then can cause a crash in sig_write (PR33918). Fix this by: - adding a variable tui_io_mode, and - using the variable to bail out of tui_setup_io in case the current mode doesn't change. Tested on x86_64-linux. --- gdb/tui/tui-io.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index f673fbf36f6..5a3bc604592 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -824,6 +824,10 @@ tui_rl_display_match_list (char **matches, int len, int max) gdb_display_match_list (matches, len, max, &displayer); } +/* Whether the IO is setup for curses (1) or non-curses (0). */ + +static int tui_io_mode; + /* Setup the IO for curses or non-curses mode. - In non-curses mode, readline and gdb use the standard input and standard output/error directly. @@ -837,6 +841,14 @@ tui_setup_io (int mode) { extern int _rl_echoing_p; + if (tui_io_mode == mode) + { + /* Nothing to do. Also, this makes sure that we don't try to restore + things before having saved them. */ + return; + } + tui_io_mode = mode; + if (mode) { /* Ensure that readline has been initialized before saving any base-commit: 646982f4295bf0a1e64867606d496c34c9a15a0c -- 2.51.0