From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gcore: Query auxv for AT_PAGESZ in gcore_copy_callback
Date: Sat, 21 Feb 2026 12:47:44 -0700 [thread overview]
Message-ID: <20260221124601.27a3013a@f42-zbm-amd> (raw)
In-Reply-To: <495d90f1-2a63-4f20-ac8d-4c389e9992e8@suse.de>
On Wed, 18 Feb 2026 09:43:04 +0100
Tom de Vries <tdevries@suse.de> wrote:
> On 2/18/26 3:09 AM, Kevin Buettner wrote:
> > This is a followup patch to commit c1da013915e, titled "gcore: Handle
> > unreadable pages within readable memory regions".
> >
> > In his review of that earlier patch, Tom de Vries recommended using
> > target_auxv_search with AT_PAGESZ to find the page size if it's
> > available; this patch implements that suggestion. As before, a 4k
> > fallback size is used should the search for an AT_PAGESZ value not
> > succeed.
>
> Hi Kevin,
>
> LGTM.
>
> Approved-By: Tom de Vries <tdevries@suse.de>
Thanks, pushed.
Kevin
prev parent reply other threads:[~2026-02-21 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 2:09 Kevin Buettner
2026-02-18 8:43 ` Tom de Vries
2026-02-21 19:47 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221124601.27a3013a@f42-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox