From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ge4jK7bMmGnGNAMAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 16:05:58 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=YoOGLUjg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A70811E0BA; Fri, 20 Feb 2026 16:05:58 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C2CE51E08D for ; Fri, 20 Feb 2026 16:05:56 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5D2B94BAD150 for ; Fri, 20 Feb 2026 21:05:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D2B94BAD150 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=YoOGLUjg Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 990ED4B9DB40 for ; Fri, 20 Feb 2026 21:03:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 990ED4B9DB40 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 990ED4B9DB40 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771621437; cv=none; b=uqnI+kQBq9Pf5shBW/lMtm/ihkwp4ozSR9t0ukRaVKvqeSnjWcd0+awiv8dVfhe3tQ09yVXoKHqajnGmNQU9j2Fvm+EVv8Cax1mpHsyBfkh8ObCEiekMv9uXn8Y6vxm/0ZTkWwdGKNdh+MurokTZe3UaPcn59jV4GVG+jXuItjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771621437; c=relaxed/simple; bh=G3x3wkYTW+1KtNKWvC1jc2Wa3dwhSCMeqYuwFsmCKVM=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=W1XQStNEpES9q8lez/3AsCuERF7aQPRf7uSCd+a2PXwrEykkoUiqJWM/HopqqPpSl0QKfsZmakJPXwjlXffdQdZo8y1bRPPK0GAIqV2Nq9EjVjYX3ADWN7lSvlTuJqf+n3RKLj8KGJUyP5xnH2wrAJeP/GWGP/gofm+cpYMkbRE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 990ED4B9DB40 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-409de4132b5so1515309fac.1 for ; Fri, 20 Feb 2026 13:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1771621436; x=1772226236; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t3QSg4XS/jX8l+K5eexaYXweVQISZciP4rs7DWtnwT0=; b=YoOGLUjg0oBFaJCaDSQJJ39GnyuX1A5IELJaj4Ypm55lZSKzdrFeB0jChI7CiV/2RY /Xv81X/gB/w41shUF+dQ0L+i2/kc1aFjarAOSR0Mml9uYg+Y8msKyxzwU/kaXz35gFfS DAuTB+1fdDNeOPRcWZhamY79ra3PRNh/+8RPFXHaSJoKWQBgRIH+KdNVNRPWW3wxcUEw d+/9bdDuJfl+WDQUGinnLwAktGuZ9gaF7JPSDzZgYaQxcdFR16bKui1IQnnWiSjDF87E hfNuukPs5/0SFAMl0Wqa69j4VwLr7y74UlbI3OpJtVgeCDHT/Uo9HIxbutS9VyDWzDYr HAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771621436; x=1772226236; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t3QSg4XS/jX8l+K5eexaYXweVQISZciP4rs7DWtnwT0=; b=wgoQnFBO03GeqIdFCzcV2s9S7YHAxq7SyyDdEGytpwVV9yoz1MpM/Ce0u6j/oNGSCH zuloDXRs53T0giFsJKxDY0YBhzaupmYDifHXgg7yar5muVHiWj+NPKwVn9SLyQp2alS9 01S1pju6Grl+hy9ufr3A3coq7Imot/3iPjXTS9jkpFW+2+685f76K+EVqmoAfSAuSAY0 aeAdj0JTa0zx6b5dNL3aFX0mTvw5QRD4eK0EjI/igYAnpWAidDS3jDRfoMwG8qkn8mUT 5Cl5I+aEM5veiRhnfXimbID/bb4ZXRNJkN1rbDG8sxRIqiHhRG243BRZPmAIoTYpd2Ie vqZA== X-Gm-Message-State: AOJu0Yz36+pmANmH+MORG2dMV9otas7DM2c5LmSgelM22TAzDIJ9cXG1 e75l1J8B0HUzNXQOYf+BkhlWJ4WeBaODtDf9uAlrMevxHCf7Bqm/90pIJNWGfXiz4AUjhIurCbz 9b64= X-Gm-Gg: AZuq6aI490Q9yIcoX1Xfr97zFKId91tqA35/vsJL0DOU/YQDcvoOrchM8zvuO+fxJDm V17k1MRX+tSQTHt0X8ZZB4VHzCsOG6NDL+Lm2mDsp2Lt0QVXoAqDPANZtYGNWNRuaXBhlqAXIL3 a9gVjVns7aWATTcUcF4b2pEaLzEbOPQvN0afI2zn5ZLdC0FH+lRt4TYF2jMX0cONRrfP3mzqU+o a6V5J8usy4bEezYQR0AggO3aOdLOTAr/Dk7f6acslTgg1Cl2aken8YJVFDLq2Yci8XSzGUrObjz vhLAO2BePB3criTcOuRKqhQBIiuHlgZOCwsIuKvxWb1W4EgoxLmyhYNtv0lDCg++UO7LBjhGwGK G8VbIgPd2igc7PYpUIOrtH1V3U0h6273rg0GiMmAElD5N45mMPLBNjv7p2D2riXbghqs0JOGqcT UHZmKdjhsZLmB6PDiTZxKGDW1ZNAXl/SXJ4+9SqLXshqbOeOSVqRNuX+mj X-Received: by 2002:a05:6871:7893:b0:3ff:46a0:a25a with SMTP id 586e51a60fabf-4157abe9708mr745527fac.4.1771621435697; Fri, 20 Feb 2026 13:03:55 -0800 (PST) Received: from [192.168.0.26] (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4157d2d7826sm561630fac.10.2026.02.20.13.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:03:55 -0800 (PST) From: Tom Tromey Date: Fri, 20 Feb 2026 14:03:55 -0700 Subject: [PATCH 09/10] Return gdbpy_ref<> from gdbarch_to_arch_object MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260220-python-safety-minor-v1-9-4c4b12e445af@adacore.com> References: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> In-Reply-To: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes gdbarch_to_arch_object to return a gdbpy_ref<>, using the type system to convey that a new reference is always returned. --- gdb/python/py-arch.c | 4 ++-- gdb/python/py-disasm.c | 2 +- gdb/python/py-frame.c | 2 +- gdb/python/py-inferior.c | 2 +- gdb/python/py-unwind.c | 2 +- gdb/python/python-internal.h | 2 +- gdb/python/python.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/python/py-arch.c b/gdb/python/py-arch.c index cf740821dfa..f40d7da1763 100644 --- a/gdb/python/py-arch.c +++ b/gdb/python/py-arch.c @@ -84,7 +84,7 @@ gdbpy_is_architecture (PyObject *obj) Returns a new reference to the arch_object associated as data with GDBARCH. */ -PyObject * +gdbpy_ref<> gdbarch_to_arch_object (struct gdbarch *gdbarch) { PyObject *new_ref = arch_object_data.get (gdbarch); @@ -97,7 +97,7 @@ gdbarch_to_arch_object (struct gdbarch *gdbarch) /* new_ref could be NULL if creation failed. */ Py_XINCREF (new_ref); - return new_ref; + return gdbpy_ref<> (new_ref); } /* Implementation of gdb.Architecture.name (self) -> String. diff --git a/gdb/python/py-disasm.c b/gdb/python/py-disasm.c index 9f5d0e2fdcb..748ffd5e6a3 100644 --- a/gdb/python/py-disasm.c +++ b/gdb/python/py-disasm.c @@ -699,7 +699,7 @@ disasmpy_info_architecture (PyObject *self, void *closure) { disasm_info_object *obj = (disasm_info_object *) self; DISASMPY_DISASM_INFO_REQUIRE_VALID (obj); - return gdbarch_to_arch_object (obj->gdbarch); + return gdbarch_to_arch_object (obj->gdbarch).release (); } /* Implement DisassembleInfo.progspace attribute. Return the diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index c0defbdc7ef..4d625f05ced 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -201,7 +201,7 @@ frapy_arch (PyObject *self, PyObject *args) return gdbpy_handle_gdb_exception (nullptr, except); } - return gdbarch_to_arch_object (obj->gdbarch); + return gdbarch_to_arch_object (obj->gdbarch).release (); } /* Implementation of gdb.Frame.unwind_stop_reason (self) -> Integer. diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index 53f3344429d..fd9da27b92e 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -778,7 +778,7 @@ infpy_architecture (PyObject *self, PyObject *args) INFPY_REQUIRE_VALID (inf); - return gdbarch_to_arch_object (inf->inferior->arch ()); + return gdbarch_to_arch_object (inf->inferior->arch ()).release (); } /* Implement repr() for gdb.Inferior. */ diff --git a/gdb/python/py-unwind.c b/gdb/python/py-unwind.c index 872cd00e84f..fbb9263844c 100644 --- a/gdb/python/py-unwind.c +++ b/gdb/python/py-unwind.c @@ -766,7 +766,7 @@ pending_framepy_architecture (PyObject *self, PyObject *args) PENDING_FRAMEPY_REQUIRE_VALID (pending_frame); - return gdbarch_to_arch_object (pending_frame->gdbarch); + return gdbarch_to_arch_object (pending_frame->gdbarch).release (); } /* Implementation of PendingFrame.level (self) -> Integer. */ diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 85f7f1f4dd1..1f0964f24d3 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -517,7 +517,7 @@ PyObject *objfpy_get_frame_unwinders (PyObject *, void *); PyObject *objfpy_get_xmethods (PyObject *, void *); PyObject *gdbpy_lookup_objfile (PyObject *self, PyObject *args, PyObject *kw); -PyObject *gdbarch_to_arch_object (struct gdbarch *gdbarch); +gdbpy_ref<> gdbarch_to_arch_object (struct gdbarch *gdbarch); PyObject *gdbpy_all_architecture_names (PyObject *self, PyObject *args); PyObject *gdbpy_new_register_descriptor_iterator (struct gdbarch *gdbarch, diff --git a/gdb/python/python.c b/gdb/python/python.c index 9862d1a726f..8739864a861 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1421,7 +1421,7 @@ gdbpy_colorize_disasm (const std::string &content, gdbarch *gdbarch) return {}; } - gdbpy_ref<> gdbarch_arg (gdbarch_to_arch_object (gdbarch)); + gdbpy_ref<> gdbarch_arg = gdbarch_to_arch_object (gdbarch); if (gdbarch_arg == nullptr) { gdbpy_print_stack (); -- 2.53.0