From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aZtLM6nMmGnGNAMAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 16:05:45 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=SNTslaHl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CDAC51E08D; Fri, 20 Feb 2026 16:05:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3BF7C1E08D for ; Fri, 20 Feb 2026 16:05:45 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B5D474BAD15F for ; Fri, 20 Feb 2026 21:05:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5D474BAD15F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=SNTslaHl Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 1C6784BA23F8 for ; Fri, 20 Feb 2026 21:03:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C6784BA23F8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C6784BA23F8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771621432; cv=none; b=aciPtpc2wztr0en90ywuEGo0ZHqe3VyM59msIjNUlQJ8e9ndQmBpX6XGppOPA64s+DD6GhkHXJS2hFLGO0Nc2faT06ZHHEygilHegZGpVzlUJuiYtosOviZ/uFWtmw6YHYE7nQBFl0uIpBv+sjRnY4C3bV2D9l2pTmGAqUeHu8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771621432; c=relaxed/simple; bh=ReinFW6IXhBdhqOWkAQ5W2wXGO2JLPdn+rIgct0GAK4=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=DiHLqZELQ1zaG0i8DrtJHl//AfYKpNOU0yJEbjhwHyI4i1PVbILesnDGmn4xLZDWr1vaO/obMvJWMCxIILhfqYZz844l744AqtHqeiBPA99eaa3jxs5rUaxIFJn4T3MeVksnzHhHZsOjjDd1tsg1Yrg8dGebCHLlyi6t/ea+mSo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C6784BA23F8 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-4042fe53946so1062555fac.3 for ; Fri, 20 Feb 2026 13:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1771621431; x=1772226231; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SdoG2eOWQfsM3gx0EH4bzI5AWpKmVpOBKSK42g+Cpec=; b=SNTslaHllcHWImxkaq1em33QgnPnIIMeq3knyfhcU0JFQ6Qs1er9Khwby9RbW7vw5M v4b+9T7LuenmksLLRY3qVyF7HNbRMiMY9XER0iLkbKcuccA4j93LtfiSO18cMFyIIanw uUkSUuiPlQcQcxL6ujQ4dhi8jQ6sFwt+4GMInStHFCaZIhmrkRgkqkNi+kLda+dXZNZv kx2aBqCSy5opeQqWRYICG0eoU1zQyH/B9joi+v1bG/tt8CwK7zoG4UjvED4zz1nyw+dC aymPSYEjZNLqvqeesfFlraIyC20jOnI5R5h3RUJUJzZ+8Hf48zElaXxYzuOuCmYkaSq9 EU+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771621431; x=1772226231; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SdoG2eOWQfsM3gx0EH4bzI5AWpKmVpOBKSK42g+Cpec=; b=BgnoIIBOQN7rtyRPqImJq+ACl9OZeE0Pc2uEyPajv48yw9F1b0eNLwb8R+ruHqocEF MzJjzBvuUVZDMp66/W0Kjd1PykDTsxkYzzuaBHFTU5LyZsnaFuUSLK9xeBhpP4nmx15F /o+IGwmedKrEOPwm2ky7RokglNcULU14JryPxw/0kuooYLkhRD7nXNQuSqjXbTRYtCHZ hXqAc2IajhFw2VftKCuvDoUnfaXmSNIVzSgBXkp/qCTK/LbRKOu7PsaUgc+zKg8Qmvce PIMC6rmkeBBPBufxSfMQzM97BDAuIxFx1TyOt3eoq7LjTsm/yU6cNaPRuWqdEVL1vAlN Uh+Q== X-Gm-Message-State: AOJu0YxnYFXubq/oGu7XabV967AWA8m2U0I4I8FH0PIKvOlxsUVRf5RS yNX/uTUgQBGKDitemDGi6QSZCrrCmI33UeNRvNg2vxnC0cfqXg/zL9NkAIcx5fE2eA== X-Gm-Gg: AZuq6aKpAkSUsX+OAVJFLvvnbbYddrSpc+nzzOe3QxSim6yDYbdPvRyuWQK0NnVqxpb wkGvGct21Dd2TZFqhXK3zpjbXgorOSceCdYpb+SHkqk3KEOKrlPHeMtIHrbOzxfyPCLrM8WTyzT LQFIEDnaBm3xx+Ps7hEpaxDUYnHI6wNbP0A1tHVjLAtqTeh+LQQ2x438G3i9BHS1RUnaQSuo79h f01pcApsw5hq6vT7YniSPEFu8PHr+RxLy9jHaRuM6oMeIAUT9n/ob/0lg/jaHkruvPVdCiE/81T K12J6VPKY+Tp0PBY9t4SeMJ4G2n2Uguz1kt9XlHb7noKDaCTmitZ9X9qzqZiJwZyXhpszUe9ClY zH93fsKYfOPwzG2511vE8Ral/1+fCSCCU6qnUlhcNuLenQ9wL0nf7j4TvpJkq/mX9IooD3MGxSE Vpbwz5lYrXXX1aNEe4sE6Z/bcalQKzesduqGB1191XwKDW2V+EhTxqrf9anWzZrvYDnEM= X-Received: by 2002:a05:6870:9709:b0:40a:6360:2db2 with SMTP id 586e51a60fabf-4157ac74845mr649600fac.21.1771621431211; Fri, 20 Feb 2026 13:03:51 -0800 (PST) Received: from [192.168.0.26] (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4157d2d7826sm561630fac.10.2026.02.20.13.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 13:03:50 -0800 (PST) From: Tom Tromey Date: Fri, 20 Feb 2026 14:03:49 -0700 Subject: [PATCH 03/10] Return gdbpy_ref<> from symtab_to_symtab_object MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260220-python-safety-minor-v1-3-4c4b12e445af@adacore.com> References: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> In-Reply-To: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes symtab_to_symtab_object to return a gdbpy_ref<>, using the type system to convey that a new reference is always returned. --- gdb/python/py-symbol.c | 2 +- gdb/python/py-symtab.c | 8 ++++---- gdb/python/python-internal.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index d51f4823315..492c386b7ee 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -86,7 +86,7 @@ sympy_get_symtab (PyObject *self, void *closure) if (!symbol->is_objfile_owned ()) Py_RETURN_NONE; - return symtab_to_symtab_object (symbol->symtab ()); + return symtab_to_symtab_object (symbol->symtab ()).release (); } static PyObject * diff --git a/gdb/python/py-symtab.c b/gdb/python/py-symtab.c index 820542932ba..3b05721e616 100644 --- a/gdb/python/py-symtab.c +++ b/gdb/python/py-symtab.c @@ -299,7 +299,7 @@ salpy_get_symtab (PyObject *self, void *closure) if (sal->symtab == nullptr) Py_RETURN_NONE; else - return symtab_to_symtab_object (sal->symtab); + return symtab_to_symtab_object (sal->symtab).release (); } /* Implementation of gdb.Symtab_and_line.is_valid (self) -> Boolean. @@ -366,7 +366,7 @@ set_symtab (symtab_object *obj, struct symtab *symtab) /* Create a new symbol table (gdb.Symtab) object that encapsulates the symtab structure from GDB. */ -PyObject * +gdbpy_ref<> symtab_to_symtab_object (struct symtab *symtab) { symtab_object *symtab_obj; @@ -378,14 +378,14 @@ symtab_to_symtab_object (struct symtab *symtab) symtab_obj = stpy_registry.lookup (symtab->compunit ()->objfile (), symtab); if (symtab_obj != nullptr) - return (PyObject*)symtab_obj; + return gdbpy_ref<> (symtab_obj); } symtab_obj = PyObject_New (symtab_object, &symtab_object_type); if (symtab_obj) set_symtab (symtab_obj, symtab); - return (PyObject *) symtab_obj; + return gdbpy_ref<> (symtab_obj); } /* Create a new symtab and line (gdb.Symtab_and_line) object diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 979bf2498da..8d101e8afb6 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -496,7 +496,7 @@ PyObject *gdbpy_register_tui_window (PyObject *self, PyObject *args, PyObject *kw); gdbpy_ref<> symtab_and_line_to_sal_object (struct symtab_and_line sal); -PyObject *symtab_to_symtab_object (struct symtab *symtab); +gdbpy_ref<> symtab_to_symtab_object (struct symtab *symtab); gdbpy_ref<> symbol_to_symbol_object (struct symbol *sym); PyObject *block_to_block_object (const struct block *block, struct objfile *objfile); -- 2.53.0