Re: [PATCH v3 0/8] Correctly handle inline functions with dwz

Sam James
2026-02-23T13:49:21Z

[-- Attachment #1: Type: text/plain, Size: 2506 bytes --]

Simon Marchi <simark@simark.ca> writes:

> On 2026-02-23 08:30, Sam James wrote:
>> Tom Tromey <tom@tromey.com> writes:
>>
>>> The new indexer does not correctly handle inline functions when 'dwz'
>>> is used to compress the DWARF. This series fixes the bug, cleaning up
>>> a number of other things on the way.
>>>
>>> I've separately regression tested each patch in this series on x86-64
>>> Fedora 41. I've also regression tested the series as a whole with the
>>> dwz, gdb-index, and debug-names boards.
>>>
>>> Even with that I messed up somehow, so v1 didn't actually fix the bug
>>> in question. I must have modified the patches after testing..?
>>>
>>> Anyway in v2 I've moved the line recording the CU inclusion and added
>>> a comment explaining the placement. I re-ran the aformentioned tests
>>> and didn't touch anything.
>>
>> With this, I get a crash when creating an index:
>> ```
>> $ /usr/bin/gdb --batch -nx -iex set\ auto-load\ no -iex set\ debuginfod\
>> enabled\ off -ex file\
>> \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin/gdb\' -ex save\
>> gdb-index\ -dwarf-5\
>> \'/var/tmp/portage/dev-debug/gdb-9999/image/usr/bin\'
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> ----- Backtrace -----
>> 0x561db97db67e ???
>> 0x561db9fd8a04 ???
>> 0x561dba59b487 ???
>> 0x561db9918fe0 ???
>> 0x561db991fb47 ???
>> 0x561db9927e99 ???
>> 0x561db99282e0 ???
>> 0x561db9f12f56 ???
>> 0x561db9b6612c ???
>> 0x561db9b6cbfb ???
>> 0x561db9644baf ???
>> 0x7f8b51c03649 ???
>> 0x7f8b51c03765 ???
>> 0x561db96648d0 ???
>> 0xffffffffffffffff ???
>> ---------------------
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> Quit this debugging session? (y or n) [answered Y; input not from terminal]
>>
>> This is a bug, please report it. For instructions, see:
>> <https://bugs.gentoo.org/>.
>>
>> dwarf2/index-write.c:818: internal-error: build: Assertion `offset_inserted' failed.
>> A problem internal to GDB has been detected,
>> further debugging may prove unreliable.
>> Create a core file of GDB? (y or n) [answered Y; input not from
>> terminal]
>> ```
>
> Are you able to share the binary?

Sure: https://dev.gentoo.org/~sam/tmp/gdb.xz

>
> Simon

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 418 bytes --]