From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WR2lHANel2lDvwEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 14:01:23 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=QaRd/DRZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7043F1E0BA; Thu, 19 Feb 2026 14:01:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7F851E08D for ; Thu, 19 Feb 2026 14:01:22 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3BF104B9DB6D for ; Thu, 19 Feb 2026 19:01:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BF104B9DB6D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=QaRd/DRZ Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id 8DA594B9DB78 for ; Thu, 19 Feb 2026 18:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8DA594B9DB78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8DA594B9DB78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527490; cv=none; b=MdOv18CdW567k4Qq/Wwv5QtT4V/yzdhaqnDR1DHkRafkspfHaceWVyi1T5vKu4Lvw7s1j+jsbhKuNfgYi8kFkubH36d9NBXGgRtv8H3tDrZMFDFmn41Tmu4w+q8tDYWo9Fm/z8wTFU4HPVKVhq9AUaaEtkuvI+Od5Mg2VX7FEYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527490; c=relaxed/simple; bh=m/eJZSGFeCRrQweMBURutg17ObbZPke7XJ7UR/fuvTE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HqTUnuOOPWQD3fXhc5TCMv6JVrk8kePjSbRmsJ7hzEtY6oetBIFNxLfVz/+iUHx5KV/3BMYTTFjU898xzfuRUwCN7hDS0lQURiI6OWvqPOCxOvTKfxI/MnKbFg+e215S557cLBZC51nD5kG29Id4m2X7Y6NJVkiUmdiEyiq7Oww= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DA594B9DB78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1771527490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/AtP15ftPYgpQv2mWd8bC+18Jupp2GzYd5jWL1J/yRo=; b=QaRd/DRZvs3/CDPBLcfKLnYajQKCTBvJBBr90URclSUv45NJMbz7H18dNgg8FLpAAJAV3U UY/3t0jXpqK5oU30MxoPrEqOJZStiOB6SZTFyt5Ci3uBlFcjJUUcOFUE6pz9kkkw+SAFu7 NainZL7OnsMQt/HxyX7NBKjKavkMr+I= Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11022132.outbound.protection.outlook.com [52.101.43.132]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-D8DPxkA2OGqYrBUkV6inRg-1; Thu, 19 Feb 2026 13:58:09 -0500 X-MC-Unique: D8DPxkA2OGqYrBUkV6inRg-1 X-Mimecast-MFC-AGG-ID: D8DPxkA2OGqYrBUkV6inRg_1771527488 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by CH3PR17MB7196.namprd17.prod.outlook.com (2603:10b6:610:198::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.16; Thu, 19 Feb 2026 18:58:06 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%7]) with mapi id 15.20.9632.010; Thu, 19 Feb 2026 18:58:04 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany Subject: [PATCH 4/7] gdb: do not set blockvector address map Date: Thu, 19 Feb 2026 18:56:35 +0000 Message-ID: <20260219185638.360694-5-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260219185638.360694-1-jan.vrany@labware.com> References: <20260219185638.360694-1-jan.vrany@labware.com> X-ClientProxiedBy: LO2P265CA0317.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::17) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|CH3PR17MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e93bbf1-5920-4495-5cfe-08de6fe8d003 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UhD9fPCFvF4BpcueStBqCSZG7tlVrE4b4js/Tj/ldH/wUm6IqM52LRfp4nSH?= =?us-ascii?Q?/yqxmXEGDfiJhiwxUkqdh8bRERpvFUHNdJaJyEEzijdZSms/BlfQ3ODn9F4j?= =?us-ascii?Q?pHH6E8CDY/LqVmgpTIspcd3ouzOO9FQ3MSuv10vBRP46ag1sx2SDSN4mv9+e?= =?us-ascii?Q?Gj5fiDGWmGJL69ybABEs9C0B15RNiC3m+jgKkdqkLS1LxqX/h3qrY08puliD?= =?us-ascii?Q?zbAv5JAAcl9m0nhosGmSUkinEyXV48Xso9fDDHpCaGl8BUbmek5Eggis6+uX?= =?us-ascii?Q?eFg5pSeLDy0Cb7EDgQOPTn8igGew16O1YgwZJ55DBUqOkkPZSfVWCWYGpbXX?= =?us-ascii?Q?jjxmf5HM1l8cTV3aTu0718ZqHHymxD4sVa4m4BagvoWXg3dZ1eJtbvoUhdv9?= =?us-ascii?Q?Psz6a3pwCFHQvGn9WcqfB84MIo84shVrnEtUiSBTfkU+Yto15oPmlnfCR0aD?= =?us-ascii?Q?YPpLsuGYkc0AcXitVbbffSxMw6WrhfAXeH07mRcLu1xKiRA2EleX7qb/HM5V?= =?us-ascii?Q?Uj4qh/sd5xwxqo4iBA4haLrbEdxoTm1B2jkNDZEDVRqTBJ7juPQXWKMf9fwL?= =?us-ascii?Q?+8n8lvSEIN3NR1mPRHxjHc0vNwPgSwt/5b16gi4/fTXhUmoYTfQYzAAujnbj?= =?us-ascii?Q?JsrpPiGMdhgKyFI+h6OXCMGbnfihyjxKw1UKddPTsUnvB9qwRHmRSR7BYeS/?= =?us-ascii?Q?/3nrpivrWSuD2rjQVoCRBmUWFyb/ufVJ0dW2IkUdMbGYPUbv6/4XjCZxsvx2?= =?us-ascii?Q?GImxnpXMdAGY0bOpn/UdZaQJICBI+L0qc/aAyyHCG1H+CW51bI0BeR9ebpkV?= =?us-ascii?Q?LBKvK6Uahu7uW85yenZbRB7gI15vpWL0zOVf2OLVm9CSnMhO8wnBSLQpXM8v?= =?us-ascii?Q?3c4yuKkz0un/lwY5+f0MRUnJecXuLCnZj0flVYo7BO6n4WVmoorSmdYIEP55?= =?us-ascii?Q?NujvV5uFK2zsjVvUPAYo05gywuatxr+bkiTt2EhV8FPPAjicq42W/pbgItSM?= =?us-ascii?Q?8OxAFruecA0jdHcaj98oW1mpu9sbMSZEC4dutH0pTRzs0fiBMgW5cnNiZvR6?= =?us-ascii?Q?y/uaiGq4TBMfSRuumDGGzA9dN/PsI4+qdwYiaUglD1HYQ2wH4j5+sWm0vAbR?= =?us-ascii?Q?GjZ9WTPezXofx0PzedAlnTD8JamnKz4SUocRFZ2w34gYt4x8/7YbEcXwop46?= =?us-ascii?Q?opdoKDt0CbAdkTydcH2FOLo8vLt0x7Vdb8Hq0KAD2FdglPdtiDI4q9kKCmch?= =?us-ascii?Q?XEMQigIa/elRk14fmbQsJBzTleTcgT/BmvCYDXzZDu2xRgdS0VIpJu6b2mQ3?= =?us-ascii?Q?hhYROZkWK0fJDFodESRwx+aKeARwgxGa5qCXvj+87c8dF0C/jVNqeuGLuHbw?= =?us-ascii?Q?Xi5wr067MXH34PZaK4OUOXU5hgmXXsNuJ28dX4CBQOrbNLPKw/zyspKfr5IL?= =?us-ascii?Q?bKhzlOy5T6rFUArI9NGh+iYbsDHpc5s2ehh8TK4zY6JKppINqahByBwzfuEX?= =?us-ascii?Q?dmydPefaUU2Li+kAu3dwZNiNIhxYDaTXxhuvV+jpqmXQwAVpqR6lSwu1FmMQ?= =?us-ascii?Q?f7p52bx28N/XW7vro70=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W4hKsRQ6nlLjnGcQPOHskc4Jqd/Xsz2QnsGMIcZ01X8AbNy+K5+Q/Fu63aE6?= =?us-ascii?Q?nniz1ZvD7144omhk3/F/AUy1x3ud4ijSNz5YYfa/xjqbUpwNYXCQW+P66lFV?= =?us-ascii?Q?xGcZ9flznQT0dBDCyMqWP6AnOGjz9zmzU7++K0SqVjyFuM/Re2NB+ZfmFMtV?= =?us-ascii?Q?BHqqaDrBbzvZiDttFgwfzBm5v2xK9ufpv3uHu8qpSDdz21hiSanbIiuoO5jV?= =?us-ascii?Q?nLwhe3fNWxejMs9Z9s50goYCwzDyiptyHc48LeCl2sV+rnZJYplB/ZBeXN/5?= =?us-ascii?Q?08LRsNGOp8tpB7a5BoUsl0X6wqov08h5YB94Ox/mEhr7Sy+JmjZce0uqllQK?= =?us-ascii?Q?cqlSsfYJKwJK8IsZQpd3XZwXtfv3Msx7+KUeXckmDDSHL0p3u/ALX/xst/Rr?= =?us-ascii?Q?fwbxQ9JEffLe1sQYDHoVjdfH4Co+P0cyxNozpXZRBkEePiwRUtSM1trNAhm2?= =?us-ascii?Q?LZIzBn0LfyzWusKwzIcv2XwtFO2QwQzLB94G3ddlpYi6WJS5GB7YFp+nU+IT?= =?us-ascii?Q?28fYnnDS1GCkqN+hPn0BeZ9kIL5rF4juvXujihCv+QkR0hd4W1RSEOj/n3Sx?= =?us-ascii?Q?D45twOrE8Ln7HV7V8JAPF6k+VuW7rAXRlqf8jiXQmtVIo9duO9WgF9Rm4ahB?= =?us-ascii?Q?EQE3NkhOcvOXGX16JQnYXlatAnMJPVOV9u7mpTLt5c39VhyHh4OyHvRgI5/W?= =?us-ascii?Q?JRvzfFUN9eXp03+YD1E8YArdtKKeARRCJy2PX4chnIqbwtw3+SWmuAhGTRaN?= =?us-ascii?Q?u2gic+cdVgICa4yo9umJS7CnoLKKIIIT9OChQBLiOt5lQnsJovkQUanGLNyn?= =?us-ascii?Q?Wvcsbe/thdg44lp5HH+qoibe+QSf0ab6Yeg3T+8/PsUcq813T035XYM7mBb5?= =?us-ascii?Q?29eTrJhRtD6w2HxZimt3ceuL4CZ9n9QqOFLF5z6umsQuSjHt/MQqq+XgPzNo?= =?us-ascii?Q?QV6G5FqZn+jqV/oyV7hotbJtXErx3kP5H1046nq1BIG8FV66MfMl+h8cwAWx?= =?us-ascii?Q?CnSx9EGN8+NGulnNG2P9vFwD1WoOMlCVAJzRFZG0uCF3Gpd7TURHHDI5DJxs?= =?us-ascii?Q?jWGJK+HT8cghNUa5guahLpMvQz+2bu8kJCDgzeIEUAhZEDHFzSev/cNs5nDb?= =?us-ascii?Q?qSXCOC0J1boqbwHA6oFOOH2afo7d+ZWfaitRbB0/5eiaFPqTlY2g0DbVCOW9?= =?us-ascii?Q?Ayzrmmgexr8j+YZjbpYuZ33pggZrx3mb6OQ1qxjtijeOH2rBlfUfiBa0q5XA?= =?us-ascii?Q?SxBlYI4apBC26cu6CePlvkYYGfiS141+d3rjDHr4PvgRAw5lpn/28jU+lC3q?= =?us-ascii?Q?g2eyRK/yRClu+phZfqkmhW2jzLiVk25Icoe6MqxeKjWAOltT+wHY98gx/taJ?= =?us-ascii?Q?mccunc7nn2OahOnZcoW/Q6jWVU/lHUGUOczGlf+uFWPoG+TDBPaBbZeQuW5g?= =?us-ascii?Q?RacOjzlriqMMeEWsznKNUD1En3g8/bEM8jJku1GNSBjyajLGMGuaUAg6d9gs?= =?us-ascii?Q?UVBNStd5pJ+5eWysJ1wBH0MCUGrb9lGwtViXRBT/dbRbuoFx21Mnu60SnWMb?= =?us-ascii?Q?x0lsuDTu8DZ3Ff0LTU7Zz46AyjQ0J135JqkeWhAVr12E1/mfclCQW2D8HUaj?= =?us-ascii?Q?Lo7JtXMH5T0qnypf3SHRV5Jq8cICcqqm0Qwooqv2UMDdZVDS5SvXpJoZSysS?= =?us-ascii?Q?twT3MyyI7IDofFHJ9DTCdkUx+w40fD3wC3MIKcIFV5SvlGxBLkhoPT+HmwEs?= =?us-ascii?Q?aQI4h5krDA=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e93bbf1-5920-4495-5cfe-08de6fe8d003 X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2026 18:58:04.9133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I/qbM3VrwmhffarH8SJUNvktl/9uFZM0Euy/sqhQGSRCTwCL/v/VItkjv9hWQXJGzbMo9baBAAKNwGpQYZKMKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR17MB7196 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 25yuLenaZhpUD11v6eWCILrTl9bDNlUxFlV49iy6Lk0_1771527488 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit removes the code that sets blockvector's addrmap in case one or more blocks are non-contiguous. Following commit will fix GDB to handle such blocks without use of the addrmap. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D33829 --- gdb/buildsym.c | 55 ++------------------------------------------------ 1 file changed, 2 insertions(+), 53 deletions(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index aa95889424b..5f47d0d5835 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -316,18 +316,10 @@ buildsym_compunit::make_blockvector () std::unique_ptr blockvector; int i; =20 - /* Count the length of the list of blocks. Also, if any blocks are - non-contiguous then we need to make use of the addrmap for mapping - addresses to blocks (PENDING_ADDRMAP_INTERESTING is set to true). If - all the blocks are contiguous then we can avoid creating the addrmap, - and perform block look up using the blockvector. */ + /* Count the length of the list of blocks. */ =20 - bool pending_addrmap_interesting =3D false; for (next =3D m_pending_blocks, i =3D 0; next; next =3D next->next, i++) - { - if (!next->block->is_contiguous ()) -=09pending_addrmap_interesting =3D true; - } + ; =20 blockvector =3D std::make_unique (i); =20 @@ -345,49 +337,6 @@ buildsym_compunit::make_blockvector () m_pending_block_obstack.clear (); m_pending_blocks =3D nullptr; =20 - /* If we needed an address map for this symtab, record it in the - blockvector. */ - if (pending_addrmap_interesting) - { - struct addrmap_mutable pending_addrmap; - int num_blocks =3D blockvector->num_blocks (); - - /* If PENDING_ADDRMAP_INTERESTING is true then we must have seen -=09 an interesting block. If we see one block, then we should at a -=09 minimum have a global block, and a static block. */ - gdb_assert (num_blocks > 1); - - /* Assert our understanding of how the blocks are laid out. */ - gdb_assert (blockvector->block (0)->is_global_block ()); - gdb_assert (blockvector->block (1)->is_static_block ()); - - /* The 'J > 1' here is so that we don't place the global block into -=09 the map. For CU with gaps, the static block will reflect the -=09 gaps, while the global block will just reflect the full extent of -=09 the range. */ - for (int j =3D num_blocks; j > 1; ) -=09{ -=09 --j; -=09 struct block *b =3D blockvector->block (j); - -=09 gdb_assert (!b->is_global_block ()); - -=09 if (b->is_contiguous ()) -=09 pending_addrmap.set_empty (b->start (), (b->end () - 1), b); -=09 else -=09 { -=09 for (const auto &br : b->ranges ()) -=09=09pending_addrmap.set_empty (br.start (), (br.end () - 1), b); -=09 } -=09} - - blockvector->set_map -=09(new (&m_objfile->objfile_obstack) addrmap_fixed -=09 (&m_objfile->objfile_obstack, &pending_addrmap)); - } - else - blockvector->set_map (nullptr); - /* Some compilers output blocks in the wrong order, but we depend on their being in the right order so we can binary search. Check the order and moan about it. --=20 2.51.0