From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QXd5Gmddl2mUvgEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 13:58:47 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=ifCPHB0S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 64FA01E0BA; Thu, 19 Feb 2026 13:58:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E1F81E08D for ; Thu, 19 Feb 2026 13:58:46 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CE5EF4B9DB78 for ; Thu, 19 Feb 2026 18:58:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE5EF4B9DB78 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=ifCPHB0S Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTP id BACDF4B9DB58 for ; Thu, 19 Feb 2026 18:57:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BACDF4B9DB58 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BACDF4B9DB58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527477; cv=none; b=CrF4ubS4n7IDg07cAAy/7rjserjSyXDdbMClReyUqLdclb5lOqv9cZPIHXqzhNKV3TzZhfshL4FjSenm+jriTGqE3bFcgOcrDlgcJF/PNxyChxOtnphZZzOLh0UVbUSr0NSCocV/GvSJVKUeTI+LG3Md2Yj6EdFHyE4D/XTEVxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527477; c=relaxed/simple; bh=iFYuVY/Q2LBNA0gAiGmfEBgBuzwQiGdfp3QCSEIsgRQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KZSNZOB6NnmqG/Nj7nYN/+xku7DjWKuCUIMNtupyrRnsfWdE/hzCOjiDELJLiulfLUXmVoahJIoOFgDh4rZfsKvPOr/KsqtmoHacDUFXxurSjJo3d43r/HyLDnKLjEpXxqQDvuIfq7BO61T0FoMie0M/mgn4Mlas29jy95VvQC0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BACDF4B9DB58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1771527477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opF8lWW/lRX2DLLL8rdXYQ6uUucfSKB2ZUSVwEWvrbQ=; b=ifCPHB0SQEHHPjTQujyOSYb8a+Vx/h7suVXaQgClT+MS0RYbKR5XKONfUAiiaEWxJWMi/K 6qljNVxUHTNLJXqACYQqZ2beQnj7HlUMQ+HC4e+IDPqtaaw/pTwt5PgYjIWaPX96UmwftL JItr9N2XXHkcNi+7sYfqXXmZAIY8Is0= Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11022080.outbound.protection.outlook.com [52.101.43.80]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-5Ejum6-1NpaUnQGe8DKydw-1; Thu, 19 Feb 2026 13:57:56 -0500 X-MC-Unique: 5Ejum6-1NpaUnQGe8DKydw-1 X-Mimecast-MFC-AGG-ID: 5Ejum6-1NpaUnQGe8DKydw_1771527475 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by CH3PR17MB7196.namprd17.prod.outlook.com (2603:10b6:610:198::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.16; Thu, 19 Feb 2026 18:57:50 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%7]) with mapi id 15.20.9632.010; Thu, 19 Feb 2026 18:57:50 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany Subject: [PATCH 2/7] gdb: update expanded_symbols_functions::find_pc_sect_compunit_symtab Date: Thu, 19 Feb 2026 18:56:33 +0000 Message-ID: <20260219185638.360694-3-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260219185638.360694-1-jan.vrany@labware.com> References: <20260219185638.360694-1-jan.vrany@labware.com> X-ClientProxiedBy: LO3P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::14) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|CH3PR17MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: cae08053-e4a6-4907-f707-08de6fe8c7a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xUsoaud76VePNsCdQ8rOlpTIBYEAo5gV4tOJIOCqbReT+uroKCcTAVl9J2N2?= =?us-ascii?Q?s7H7acwJmlaV8Cn7niHTMoVhCpcbkkjzzPLCxDYle9iXIi/Mipp7mwRl6XlQ?= =?us-ascii?Q?ZHqEaG6wNFN5sLF1zebjksTeuOF9FZJpz65VUSIJQHxv/HMfEEyTEJXkizxa?= =?us-ascii?Q?a9/+KmWrlx29we2uGxk2rWIcTEWXBZDl5cLGWA4kmsbjhVuvia+jh9qWFCwC?= =?us-ascii?Q?Rm6QcDJP2u/fhQuDAbcDNaMhLr5zh5JAye6CBgCkTFPgH4L+Loxazrs43Uvh?= =?us-ascii?Q?NnD8lCfHh94fsIM+6RuH9qlfDI+sbs7rVux+xKWEcxBzEcrQOwsefalUUI36?= =?us-ascii?Q?t/PqmnD1oqaupzfrKmIx630Q9VV9Uc35X4mCkeSR74cHkx/0tHo3JRXsmQmn?= =?us-ascii?Q?paYX1bsiYp2zq8KWYQhGlq7x3TfOaIudqZdEMrsAA9CFYg9crDksPGKWjYpu?= =?us-ascii?Q?k8tEY6WbTOPXkvAEo82TY6D5XWvoYZW4+yv1hChvW5p0sJIQIpSysnt06Fby?= =?us-ascii?Q?q/pRmFp3dFmnDRNPI4qe3TbZF1WB0i/hdlzYQMLSjaPlqTcP6l0hBAKjWIze?= =?us-ascii?Q?0OOu5+59C+Ctr/bwtHeEJuQv1aakC4AKmXdq3TrWRXtgJgrjNnYPjtsHOCaS?= =?us-ascii?Q?O2P/bKtBMEhRNN+ptCX0D7gjIiyUCGSTjxvVVDBdzQ1WbyCqHv+8WmyTiYQf?= =?us-ascii?Q?6AHpY+Fu0LjxedA5c26bP6da/a/jLgCr0wJRzS1Xiy2JhxmJqjpMNxDaagep?= =?us-ascii?Q?gaW7U6370Wmuyx1Eky24KTcZyWGNnrbqJ6LE//GGbh6wzDRm4J8RoBi+pIuF?= =?us-ascii?Q?2JM0kcASINh9CvF4al3Pwf5su+xJoxbQ+I1mn3lcq4xUFpCU2h/vr6WNyGLF?= =?us-ascii?Q?1NVEtOioNk0tkN9TUl2NsYP/wHmYQSaDZevD1+SEw9hHgQEOgpv0QvKyn2bk?= =?us-ascii?Q?XmuVo2UAJNCoReoMk+kN/w16+8D2FgAdJHS731VAI2OghTevKloNEg5A4jFe?= =?us-ascii?Q?pedsJaRUL0eiQuFXdPa7ZjdNpr3fZtad21J3ouqTpJk2q4mDsoKFGihQBcZL?= =?us-ascii?Q?eYSnyGtPRm2A+xCK+JLh2h8GAd11O9vnb7+Av1/90UvZImivGaN7asUdWXCb?= =?us-ascii?Q?y5ZJYZm35rNwk/g4Wms5nSgBq1gUYZU2x2Lb4aRERKX5feV5ISsysbsuuJst?= =?us-ascii?Q?sC3uUInFBOpfY1EFzcQNpJS/d+UsI+t8w3AOYbVlCVpAG6p/DDz4cFkcQhLt?= =?us-ascii?Q?JQ5KzM86X/xsRisUHTxCOulRBYk8hprVWR980ZDQRLHOdi2Vx1ci4AwGoxNA?= =?us-ascii?Q?nN+8Mc7OBjxx4CRtmreJ+9bU1OXQ0Z/D7vjFw7gH7sUfmxebiErEhkmRcdfN?= =?us-ascii?Q?OtOksUej0BUeZ3JSAyMETY93Ygywpqkl3I9nVkZMrzlqUFAaj3VKu3BBszm6?= =?us-ascii?Q?yfUdGg05GaKNKfQEQIy60Tvsay3zeIZQBNjj6d9l4B/V/X1k1f2bfhQbKb8l?= =?us-ascii?Q?I4/B7QlGAea7IoHmsiXlgWoxrLNptCNABHQLV+WFK2meybHjmtBjkqu5jm9n?= =?us-ascii?Q?Ij81h2fKg9VQrLyTzOg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IUEW1Ksuw2WbJakYD6KQNf6gAB7gngr2o5UmHO/psAvuFVL6x4sj45UiYdUg?= =?us-ascii?Q?2gyQ/WyLyPbCFRYYtNVzQpPrWQX7SD1HZncYaiwz1loUi5fUZGItRSAnmVOa?= =?us-ascii?Q?egyaQIUkq6ZVTiLBkn6b3Uu2U0Pjdy4bnMQtqlw8eYKLKfKAOJ2fSzZDZE4e?= =?us-ascii?Q?G2mzr59Ms26kWW+GIfXMOrjRv8wkHoUq+IHphxAa83I+EzTz5TfmI/TO6DWb?= =?us-ascii?Q?uudHE5tkRfbJO/OxxM4+Ni++YRxH+3D4Dlfcvgiwq254jt/beYV8JQb9UwCj?= =?us-ascii?Q?PJPvaJIm5ONFf66rwPXZ6Wq0maUu32V1fSFpn+XSDRwadvwigo5rSKMZPR8T?= =?us-ascii?Q?nGK2VA53ZckPpY00WfjpxMRZiY6QdjXnN+/mxE08VmGwOjOVX7abzXcB4UrX?= =?us-ascii?Q?w2GTt6uxMOldOIXYMORcGKIpmKp+w9pg4ZXCNq+xndgjIZvdgno39LgQMqTd?= =?us-ascii?Q?CBG3sdfgz3l31LoJApoIV1BXBlwYabJtNFuIkpPpoKf84j6RwfM5Dqbws7BG?= =?us-ascii?Q?PAsRRIYKr6ccWzekHjR7GC+uaaVAEAy6btnY9kB9oyo+Mmwwm6XCw5RAuVEP?= =?us-ascii?Q?XqEXCGq1PaI8upAFInoV5KEJPvWBYIijdlkvOQFYYglVR8NSiGcuhXxCBDIC?= =?us-ascii?Q?lAzwKt6czK1/UAOz5eY7eKhqIFvRjkqQVU/5LQTwGDg9nvNiQsMZE0oCv7+X?= =?us-ascii?Q?7w3XMrjzz5QaBSbVLBuD+rAqjDSlRFDCtbqqcKLGnPpn1ae0VMfPjU4lJcTc?= =?us-ascii?Q?BGf5eCk4jdt3gGomBQLEmtmZ62AZhzFicrZx0E8XC/thFBqWJOzwwsvwXyp5?= =?us-ascii?Q?BEnfFI+9luDJwTzfOQeW3uW/GEUUOXv7Mznkh0jpj8S0IqmnNpg5Vade26Mi?= =?us-ascii?Q?0bktmM+5TtJzaVwaSBMabQ6lEiU97YC7EXDtvKl1fctxWWkUzwmsdwhAzJ/x?= =?us-ascii?Q?4wcUNuZIdRe0Bo+MRCIWn3KI0le9W9nxMSNfSSN0DR0K5kZ+X6IvQ0Lta4sp?= =?us-ascii?Q?4NsklTGoJA/T7pmClsUZkcQT9fwchqntcjcJKef33VyVydWJceSRhvGzG6f/?= =?us-ascii?Q?aafeYOx7+fdqh0gHTLi883f9e45ibJvFGzfPnslmVk2CLSBPNwmy9hJAJIKJ?= =?us-ascii?Q?CLlAeMr0RB3KG7pYrHle52XvPoXXFEw6DHv3bpGsEKsVrZ+BUdMnyyRJEZk+?= =?us-ascii?Q?Z6rq9VA0SjHQaFDotNhbnk5ikbWAHKWluhTWURZdAHBGBu7lvV1yXKqkNkk8?= =?us-ascii?Q?TQ0+CBh6hf6O2zuqR5B2Mhbbv7fBrOHMdyJog0BGK9g8cDKklXWvo9e63nSI?= =?us-ascii?Q?MXRUDAzdSzaE7QuTfXBB6m8hoqdv5vcaUdsacxEoWpnty9UPCf2HZm7kQWld?= =?us-ascii?Q?WyfMqe/o/dwLln3Yvi9gQnRhu3K4VoN9FkpPnYuU8RyIHSlACYV8324HmAaD?= =?us-ascii?Q?IVkW+wdDe0aWeLpuJLYOKSd4F2FXx+UR/LcNkLzDOuIQeGoZQ+33tbA7EvaN?= =?us-ascii?Q?AAJREUOM2hiyMToqSVjQxZrUlqsgx6jmrnsBG12Ob8oB55RkWC9gdnOeRRC8?= =?us-ascii?Q?+dEYp3S0R78+I2Ktoi6mBK7d7i6s4BbQG8qPuXM9jk+JQO52EOe8DI32lcsW?= =?us-ascii?Q?ovw8nHqKk72fvIIjHJVWJbJB1N9RU8XaaUjwyqrp1WbldrRRCVIZtZZsosUJ?= =?us-ascii?Q?EYSfPGIPnKElrMBTAGnb96NgbH/jz7eMWMUVduP+d2a+cTZYegMYLEwQzlOm?= =?us-ascii?Q?lOXXgQirdQ=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: cae08053-e4a6-4907-f707-08de6fe8c7a7 X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2026 18:57:50.7882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RoCDrVS6FHag8GRVuyznBpmPa7Z5fMWZnCR4Mpl/nEAuvc3i3UBjE7kLn8PJv/EujwT3ORLCAv3a3+bW6aaZuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR17MB7196 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JTkT9TwdEAtLpaXmUhD-lbM5IVsr7-mD7VctyNcApZk_1771527475 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit updates expanded_symbols_functions::find_pc_sect_compunit_symta= b to search all compunits rather than just returning null. The original implementation (just return null) was based on reasoning that its would suffice since find_compunit_symtab_for_pc_sect walks all CUs anyway [1]. This commit is a preparation to simplify find_compunit_symtab_for_pc_sect by removing that code. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D33829 [1] https://inbox.sourceware.org/gdb-patches/874iqoogoa.fsf@tromey.com/ --- gdb/expanded-symbol.c | 18 ++++++++++++++++++ gdb/expanded-symbol.h | 8 +------- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/gdb/expanded-symbol.c b/gdb/expanded-symbol.c index 050608795f9..3c7f9019beb 100644 --- a/gdb/expanded-symbol.c +++ b/gdb/expanded-symbol.c @@ -18,6 +18,7 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . = */ =20 +#include "block.h" #include "objfiles.h" #include "symtab.h" #include "source.h" @@ -113,3 +114,20 @@ expanded_symbols_functions::find_symbol_by_address (ob= jfile *objfile, =20 return nullptr; } + +/* See expanded-symbol.h. */ + +compunit_symtab * +expanded_symbols_functions::find_pc_sect_compunit_symtab + (objfile *objfile, bound_minimal_symbol msymbol, CORE_ADDR pc, + obj_section *section, int warn_if_readin) +{ + for (compunit_symtab &symtab : objfile->compunits ()) + { + const blockvector *bv =3D symtab.blockvector (); + if (bv !=3D nullptr && bv->contains (pc)) +=09return &symtab; + } + + return nullptr; +} diff --git a/gdb/expanded-symbol.h b/gdb/expanded-symbol.h index c088d74f7e5..dc2e9814b3c 100644 --- a/gdb/expanded-symbol.h +++ b/gdb/expanded-symbol.h @@ -71,13 +71,7 @@ struct expanded_symbols_functions : public quick_symbol_= functions =20 compunit_symtab *find_pc_sect_compunit_symtab (objfile *objfile, bound_minimal_symbol msymbol, CORE_ADDR pc, - obj_section *section, int warn_if_readin) override - { - /* Simply returning NULL here is okay since the (only) caller - find_compunit_symtab_for_pc_sect iterates over existing CUs - anyway. */ - return nullptr; - } + obj_section *section, int warn_if_readin) override; =20 symbol *find_symbol_by_address (objfile *objfile, CORE_ADDR address) override; --=20 2.51.0