From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QaWIMoFdl2mUvgEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 13:59:13 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=mwxQG3Hb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C86131E0BA; Thu, 19 Feb 2026 13:59:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3A2801E08D for ; Thu, 19 Feb 2026 13:59:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E8DDB4BAD14F for ; Thu, 19 Feb 2026 18:59:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8DDB4BAD14F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=mwxQG3Hb Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.133.114]) by sourceware.org (Postfix) with ESMTP id 6440F4B9DB7B for ; Thu, 19 Feb 2026 18:57:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6440F4B9DB7B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6440F4B9DB7B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527469; cv=none; b=htL4L2yZim+L9KMahyH1VC60MBfuMgdPgY1flL9R1vxt73P1dgjQBCDgA3LLPa05S0qiehSodcwO4Ov4XADAuUD1IzdlXpQN2+cmsBmmbL7Ak3VkyPyVIg6PoK4S33cmvatKi2ZlwrEx01QhhrTqw2dOg91Le09ZS+yE4mLZ1ns= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771527469; c=relaxed/simple; bh=APoSjrS1OP7OANmMR0aBxwbmP2OMdlAGEwoK/7RJXb4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bOMf6T+hclPI9el/2aQQxT9Fbho4ru0ffqpXjByUAXliG/AMLUHMw3LSseYnu+MGZ0hXbR+cYSlzJ6L6JnceV8RhV7XZXzGbNWbzkauOUF8WQEkOybRILPp+IRYHXRHmpADEpCMM+FupJt1jWN1CZG2XM3D0rDpfU1ChQSXEWKA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6440F4B9DB7B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1771527469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gcob6R5mCHjfmq7BnJqJS9k0Q2DjFn84Veyu5Bxsxvo=; b=mwxQG3Hb22ojdM27dHluM012FatPWwqOKjYTsKj2wdjOZUu3F3pJX7u5HOc10Btpbg67MA kxLLJLZgd91b49QBpZjeLSzzGLm/rL01994fIOStzIT6C8PzjHKQnK4zQE5vFCUcANMoaX 1G+xBxdCn7gcoUo1BlAzhgiHbG6r+0I= Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11023132.outbound.protection.outlook.com [40.93.201.132]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-ladhE-RJOJ-4s79dQlWSDg-2; Thu, 19 Feb 2026 13:57:48 -0500 X-MC-Unique: ladhE-RJOJ-4s79dQlWSDg-2 X-Mimecast-MFC-AGG-ID: ladhE-RJOJ-4s79dQlWSDg_1771527467 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by CH3PR17MB7196.namprd17.prod.outlook.com (2603:10b6:610:198::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.16; Thu, 19 Feb 2026 18:57:45 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%7]) with mapi id 15.20.9632.010; Thu, 19 Feb 2026 18:57:45 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany Subject: [PATCH 1/7] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Date: Thu, 19 Feb 2026 18:56:32 +0000 Message-ID: <20260219185638.360694-2-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260219185638.360694-1-jan.vrany@labware.com> References: <20260219185638.360694-1-jan.vrany@labware.com> X-ClientProxiedBy: LO4P265CA0226.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::7) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|CH3PR17MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 665ac1b3-27ba-47ea-70d7-08de6fe8bf04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yBSZ+oohr9WtsRfRo4LGKhW6pQMfQNavoL7fo47Ia1fgDP8aPgZxt6rc9Qpg?= =?us-ascii?Q?oRtJPQFYcM0JPNhNC7IBxfzluIvrqjf2Ucx3OnROyMGEGuY3jV2NKHTuidNN?= =?us-ascii?Q?GzBhZUIgmVLSZRKFWWB6YXMbCiKSKuuQkRJVKd7Yqxj8+r4GmpK2ZDxEvPWQ?= =?us-ascii?Q?Ys06y63Pd6T27mbySpwZ2hVyBBgtMehZrqwKYKGdbE5r1pzGjFBWKn26Ilds?= =?us-ascii?Q?fP5JS5xFfkFdA1LJGCIBs/fMlxm9F6/3p7jw+RKanKSMw07M9uir70uFQ4O4?= =?us-ascii?Q?VaaDZ1rwrMn35c35a8fhhS/O0fGqsi9bNL7fcfuNsC50DMcvKmJoFyW4xGip?= =?us-ascii?Q?zlUjtWd7cRMUFnzzyxydGOtz4Inz6NyPm+V5GBYPDY144So8HdgyXt6k/YKL?= =?us-ascii?Q?7g3wV2Zv7FsaSHgzt6v9qieltud+vLuXq05Rbo4waIOsig2xKIicZdAnVHH7?= =?us-ascii?Q?Lb6cUXfe4/HzXROPYOGPxyaH+kT8uuLIVRvxzxfzf6j1GuhCDXPv7INQ/UzO?= =?us-ascii?Q?QmaYwwYQY6S618TdaLGzg77pwTRWO0t9NjB+c5QgeC0qZYrVfD1nItI2ch/E?= =?us-ascii?Q?GWCclf5Hc99/1gAULTJe5f5ULs8N9zte6Yx16QcQfALW9YUiz4YXX9hxvZKv?= =?us-ascii?Q?cdJlwdQeYpHN92Pcd/8dEoNyRpp+WRcy/E1zbFMSVikgVsCmPezbgo+80Wyu?= =?us-ascii?Q?B882yJlpwGFGcl5o5Q4Wwhl4uPD0RSgZgylJFz0sRsBM/xeAOwoFigvFGJWM?= =?us-ascii?Q?N+5d2OnciTHqCgupUaJ6S5YjG/jxWUbwIjUQAv6IM2ozN3AKlCrj/ww0fjSi?= =?us-ascii?Q?53BnFWXB0dCa2vO9eZAs44lI/YgY9wDb8oRGcAjY/W7zFsycNK2oM/ec+MwG?= =?us-ascii?Q?ruz52B0LlIAUsSlsjTbUdTZV7y5MgzWsWnrXrSv9rRmek5qGBuht+YVq3Mkt?= =?us-ascii?Q?T/o4NY80fQ70laTTnB4MipWpert+a4xawHSWdEdXIyfEkib50tv4CH87DAx/?= =?us-ascii?Q?fR3I1M4hI+l7VWZoMjZ1eMLST6nM2iOcFAPGxO+KrAOho3L9GY5zG5HhhG8d?= =?us-ascii?Q?DvT0rYkZFShJCRukfhJrXbhNEZoeXJSFttP+40DZa6CBkM4kQuQFmuZE1bos?= =?us-ascii?Q?98Bu/mirgwRq7wafXTU1pG+0kDELJ4x0Sih52TRJ98SJ6o29kzS4ttS6PGBO?= =?us-ascii?Q?9RJF39uJgimJ/QVBJNqeq2byHXVHF4X1Gurgk3ZPLTLEDxZSCzqxVFQq5WPl?= =?us-ascii?Q?I+1+AWK+8yiG806ve3eeHpx1pr1E0OyfNiKGuX0z0t837tYG/GFgzYaY7xYZ?= =?us-ascii?Q?jzO82hz5eubmXRMgXerCL2M+pyA/wgaBV3vmK3+1B5Nd3rff6bX5tOTcIYk4?= =?us-ascii?Q?ksJLlsgHhwXFEWv9xhvGwTFyBLbT76w5SdsBYxL+4fq+hCoQ4DTJrLDb+z9Y?= =?us-ascii?Q?SjcVUturalus4fBVbguDNTdM61ninI7ZdLFcm4cSFz04GTkUuMpK4pgEnt88?= =?us-ascii?Q?ySesT8WTO2JWPKu8I7NWy8gpT8iClkUXa3DMB1mKlVzEYg02NtqACIzytiI8?= =?us-ascii?Q?XmI1/7h04bCc/b7pKic=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J/lOXZRBtaa53Qh1rVknsVIwUN7vbLrecEm8CXn1lk9YgdndFSzi6/OVaUGo?= =?us-ascii?Q?ttL2O8To5/0tdolI4u3dXljIl+z7Begi6afgmHfqxujBzu+61wBZnNTunrJF?= =?us-ascii?Q?dtcQT9qjItXl2xHeVt2XYHwgH1RV9cN0OvypBYImJDgLxoh3Y5t/M66mH7+E?= =?us-ascii?Q?onXn9OT+1IsH/xFPe2fWRWCGIOwVif+1LdOcdizSk+0w4maeS1JPjWJteWRt?= =?us-ascii?Q?t+sHLmIRWjBnQljeytQ/csHm9rmW3aemoZs5/TfdGuaGf+QFSCKvIpWvbeS/?= =?us-ascii?Q?78SlDjUjhUNqd6Z38rOeQ06YxxoZqQbN01ezzS4WUyt/A4VcQLfgFf9UC5fR?= =?us-ascii?Q?mhlhX9L1CipVQmOTBCCOp6gP95Rwyad8OvAlc44Stgb3+ABv9p96nY0wr9pG?= =?us-ascii?Q?G8IO3GwqHLFknQo15HkZIkujtoG2beh8knNdq9AhFO5Z0uTcCYEdEEfJHWD+?= =?us-ascii?Q?Sh9HSeSR67QVgis1Luih2eslgC6B67NUJMypzjN3aF+0dnZR9lkae+dDHTGf?= =?us-ascii?Q?GRlNgRmrZkFSKqv4PFRabcd3tC5o7Uq3K9FfYuw0cT9yGH/0U6joqAdJH6zm?= =?us-ascii?Q?LTUwGDTL12UNS2fvTcAQJ1aADHpqSfmSEz9fpL4DXWRkolJjOHMLv0SiBg3l?= =?us-ascii?Q?xPPEXMl4sfG93VEHMKL4fFxIDxX51loKX4dS9uSiu5wuxdrh5rJoW2IWBuuP?= =?us-ascii?Q?WfQgGbsDNpPlDCWOdiHBzWckf71JAVaPotaZ5k7oPuYS+Yeo5b0Nl6LRZ06n?= =?us-ascii?Q?9iSzRZIhCLPchOSlDhdK5Npq0i8E8dAiImQiQ2nO9IxIBGb31edl/LVe77LE?= =?us-ascii?Q?2hGk4+s0a7LnY0dSQ3wtIydPs2/SwkpnqR7yG2Pkj9mubOTxAqIzwparBpd7?= =?us-ascii?Q?cwbv2H7IjLHJSBqycg9hCCCR5nkbgZImfXbRy8p6MdgnLHoeZJHDDk15l0Z6?= =?us-ascii?Q?3L4RSWvMvHGqN9bLO/OYcChiV4s6dnPQ2o1k2S8RU6ZCw3m0FwStMGJC0uwr?= =?us-ascii?Q?LDqOUmnT6mVp0+fldnqabCLDwoi3BtGYsM7y2I6rWBLJqDFaYHx5Glzg0yHu?= =?us-ascii?Q?TOJtp4oq3/IN7NHmCMwufxhLyEZX1jxzfAmpzzJuNQD8RTriF3hVmvTDHthD?= =?us-ascii?Q?4WqAui8hT9sUiTpws+Tsbiwb35AboxYIHK5BZjVyHnzIGoot5SLipEnoDARl?= =?us-ascii?Q?QM9NrwGUCwWUAcS2DV6oCeQrRz1aP5iUAaKCos7C5IBY++ZY4p9cnMQnJpsk?= =?us-ascii?Q?3ctQHczGsX/28udfdkH04JbRl4t1G3R1OoPLqM9+K0bGXE3Q+1WZ+a19+D5j?= =?us-ascii?Q?WcS5OnXswN/zo2bIlK34UqUzKBOMct37ZUX41EBT4+O11hRNyGjVvEkL2rPU?= =?us-ascii?Q?oqAAH2BC+03g8ZdnvtNDyKXaB9OWaibuL2Fv6YNcUVFDOQDt0BT7AeewUUcv?= =?us-ascii?Q?5ufgxeXFbxQ8PkypJtmMGPCoJdq8Rd4FqqN6+IB2Mjzqo5bWFTWEPPM/O4ba?= =?us-ascii?Q?apT9lEwTmOFkiyfIfy+6S6XV57N+sMjvktTcauof9tbKKL8BpzV/FSpUjBL7?= =?us-ascii?Q?3WGSTgqqGZVfVcVm1YNHzWz97/2cUdAjlrEprb4Px/1fsvpQEVyl4+V6I7w2?= =?us-ascii?Q?JZuwm7t6PWKCay4AR//F280qAXXR+tI88C4eySJj2dJ/JLYdE6s0qWi7mHEz?= =?us-ascii?Q?JSiBiiHGS6JyUZxhw5cfIUBiThDw++ESlv/Tt7Ft7ModEDdRkysufw6xnrei?= =?us-ascii?Q?y65PQKOKSA=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 665ac1b3-27ba-47ea-70d7-08de6fe8bf04 X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2026 18:57:45.5846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E2+cD84ocoByg14k3QxHp4csMO85Xtdgd2DmOpJ+O2PQsMrpRwPLRTSC8+GgPIetKlNcg67ZtJEht8a077RihQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR17MB7196 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kYzCU5HX5ifkC6HEvgFza5H4Mxj4AvA0Uc0Uo7LFR7Y_1771527467 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit implements readnow_functions::find_pc_sect_compunit_symtab. As comment in read.h states, index_table member dwarf2_per_bfd is null when -readnow is used and thus this method would always return null when using -readnow. This issue did not manifest until now because: 1) readnow_functions::find_pc_sect_compunit_symtab is called from find_compunit_symtab_for_pc_sect *after* all CUs expanded so far are searched and, 2) it happens that required CUs were expanded by other "quick function" called prior find_pc_sect_compunit_symtab. This is a preparation for simplifying find_compunit_symtab_for_pc_sect by removing the code that walks all existing CUs. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D33829 --- gdb/dwarf2/read.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index efe0b046f15..702dca8e5e9 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -1525,6 +1525,10 @@ struct readnow_functions : public dwarf2_base_index_= functions return true; } =20 + struct compunit_symtab *find_pc_sect_compunit_symtab ( + struct objfile *objfile, bound_minimal_symbol msymbol, CORE_ADDR pc, + struct obj_section *section, int warn_if_readin) override; + struct symbol *find_symbol_by_address (struct objfile *objfile, =09=09=09=09=09 CORE_ADDR address) override { @@ -2166,6 +2170,33 @@ dwarf2_base_index_functions::find_pc_sect_compunit_s= ymtab return result; } =20 +struct compunit_symtab * +readnow_functions::find_pc_sect_compunit_symtab + (struct objfile *objfile, + bound_minimal_symbol msymbol, + CORE_ADDR pc, + struct obj_section *section, + int warn_if_readin) +{ + dwarf2_per_objfile *per_objfile =3D get_dwarf2_per_objfile (objfile); + dwarf2_per_bfd *per_bfd =3D per_objfile->per_bfd; + + /* This invariant is documented in read.h */ + gdb_assert (per_bfd->index_table =3D=3D nullptr); + + /* Since we have no index, we simply walk all units until matching CU is + found (of there are no more CUs). */ + for (int i =3D 0; i < per_bfd->all_units.size (); i++) + { + dwarf2_per_cu *data =3D per_bfd->all_units[i].get (); + compunit_symtab *result =3D find_pc_sect_compunit_symtab_includes ( +=09dw2_instantiate_symtab (data, per_objfile, false), pc); + if (result !=3D nullptr) +=09return result; + } + return nullptr; +} + void dwarf2_base_index_functions::map_symbol_filenames (objfile *objfile, =09=09=09=09=09=09 symbol_filename_listener fun, --=20 2.51.0