From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gcore: Handle unreadable pages within readable memory regions
Date: Tue, 17 Feb 2026 10:50:56 -0700 [thread overview]
Message-ID: <20260217105056.70237fc1@f42-zbm-amd> (raw)
In-Reply-To: <e3dcb147-cf3e-41f9-bf90-837b9b980590@suse.de>
On Tue, 17 Feb 2026 15:19:31 +0100
Tom de Vries <tdevries@suse.de> wrote:
> I'm seeing the same failures on openSUSE Tumbleweed, and I've done a
> full test run with the patch, and indeed it fixes all those failures and
> causes no regression.
>
> Thank you for fixing this, and the clear and detailed explanation.
>
> I've reviewed the patch, and it LGTM.
>
> [ FWIW, I'm wondering if we could use "target_auxv_search (AT_PAGESZ,
> &page_size)" as a way to improve on the default value, which itself
> looks good to me. Perhaps as a follow-up patch? ]
That sounds like a good idea. I'll take a look.
> Approved-By: Tom de Vries <tdevries@suse.de>
I've pushed this patch.
Kevin
next prev parent reply other threads:[~2026-02-17 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 19:39 Kevin Buettner
2026-02-17 14:19 ` Tom de Vries
2026-02-17 17:50 ` Kevin Buettner [this message]
2026-02-17 17:44 ` Schimpe, Christina
2026-02-17 18:16 ` Kevin Buettner
2026-02-17 21:22 ` Schimpe, Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217105056.70237fc1@f42-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox