Re: [PATCH v6] Add .clang-format

[Kevin Buettner <kevinb@redhat.com>]

On Thu,  5 Feb 2026 15:48:49 -0700
Tom Tromey <tom@tromey.com> wrote:

> This patch adds a .clang-format file to the gdb repository.
> 
> The resulting reformatting is what I'd describe as "ok but not great".
> There are a few variances from our normal style, some discussed in
> comments in the file, and some in the bug.
> 
> I've somewhat come around to the idea that some ugliness is
> acceptable, particularly because I regularly see code that's already
> ugly anyway -- either in formatting or along some other dimension.
> 
> I don't know of a way to enforce a particular version.  I have only
> tried clang-format 18 with this particular file, though Kevin Buettner
> reported trying 19-21 as well.  I've documented this in the file.
> 
> I used "AllowShortFunctionsOnASingleLine: InlineOnly" as previously
> discussed.  I feel that the spirit of the GNU style is that vertical
> space is free, and we should use "None" here.  (This goes against
> something we previously decided on the list, though.)
> 
> The file is in the root directory for ease of use.
> 
> For the time being you should not bulk reformat files.  I think we
> should have a flag day for this, but at some later point.  See the
> earlier discussion for details.
> 
> New in v4:
> * Comment fixes
> * Remove ForEachMacros - no longer correct
> * Remove IncludeCategories - no longer correct
> 
> New in v5:
> * More fixes to the comments
> 
> New in v6:
> * Removed 'StatementMacros' setting, we're no longer using
>   PyObject_HEAD
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30098
> ---
>  .clang-format | 167 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  .gitignore    |   1 -
>  2 files changed, 167 insertions(+), 1 deletion(-)
>  create mode 100644 .clang-format

I was around back in the days when we used to use gnu-indent with a
particular set of options.  We all agreed that it wasn't perfect - in
fact for many things it was downright ugly.  But we also agreed that
it was better than the alternative of having no code formatting tool
available.

I'm in favor of this going in.  I'll give you an Approved-by in case
you wish to use it.

Kevin

Approved-by: Kevin Buettner <kevinb@redhat.com>