From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aD8OKbxXhWmJnSoAWB0awg (envelope-from ) for ; Thu, 05 Feb 2026 21:53:48 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=p04DyF1x; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 991981E0BA; Thu, 05 Feb 2026 21:53:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6BE21E089 for ; Thu, 05 Feb 2026 21:53:47 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3B7C948FE0BC for ; Fri, 6 Feb 2026 02:53:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B7C948FE0BC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=p04DyF1x Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id CFB7E48FE081 for ; Fri, 6 Feb 2026 02:52:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFB7E48FE081 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CFB7E48FE081 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770346366; cv=none; b=DZ00n/EwlWMODAoOU+JKY4ye1WYOfOqIk9TnEY16gM+E65UifHKDfk/+s5LvueKK1ySXEB1SNeEnk2yio6WDBx0QpYqIqfrXWVa+24Y6cwode6wF+Ff+///oDFJFNE3teLv3Mus4ga4+VwL+00J7u5GTCmCnrmAmNs8hw5rEsf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770346366; c=relaxed/simple; bh=C1DKHXGcu9BWjc7kXMjo2sYPBKAw9Ilpkpl2p50AtUA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GVficz729zvKHeFv1klkmTEEiFcQ7nrQGrT1SqKcDWbni2vnWhp9PaXIcV3xcZyek+0Sg2qmQluAog/oKr0Wk9wy3xwNAoOtwy1uO7hTKo0vY1EX1nZrgO544qMnacwBEGC3pYnGzX2bVccnTFfaZpCt/opOqTAylGt6Sh1XoCk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CFB7E48FE081 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 6162qefS076618 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Feb 2026 21:52:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 6162qefS076618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770346365; bh=qiltPGyYfD1rdjw5469PodcHglEGIZrS6B0rOMisoXA=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=p04DyF1xueJrlEmaEYFU5v0id4RNeGt4B/mYi1dUG/AfqEG5vmMaV7PiIDdOw3eHE CDdxYspBo7hIr/zYsTaoG8sOgM48O9CoCuIFM/69zipLBmwrDJT+mgB+q+T0JEsfe/ 3vVEroJaCGmPtgZHz1UlGkta0czXAQ4TgNhSNRtZCddHqtrMd6bhcX+5hbB4Uhannv XNysFsXIcMjkh0dyeoBhzxtD+7Y+CeKYzMz0ZdDqBU1fyI5HNs01rqUSH4DdLVrRR7 ZGXH6I6GJwm1HJ/KKd3PAY2hgAd5YSi3Vv/6wnUmEUaw8RAN8Iu8rrs5oVPQ5lrFnh zi9Ss4zgRMFFg== Received: by simark.ca (Postfix) id 491D11E09A; Thu, 05 Feb 2026 21:52:40 -0500 (EST) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 2/2] gdb/block: add assert in block_iterator::compunit_symtab Date: Thu, 5 Feb 2026 21:52:31 -0500 Message-ID: <20260206025238.3467043-2-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206025238.3467043-1-simon.marchi@polymtl.ca> References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 6 Feb 2026 02:52:40 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi Verify that the compunit is only accessed when the iterator is in the mode where that field makes sense. We could also set compunit_symtab_ even in "single block" mode, it wouldn't hurt, but it would not be useful either. Change-Id: I237db16bb485148f9e906b2e7238159e9f0a8585 --- gdb/block.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/block.c b/gdb/block.c index 5aa58545393b..730e4580a5b7 100644 --- a/gdb/block.c +++ b/gdb/block.c @@ -442,6 +442,10 @@ initialize_block_iterator (const struct block *block, compunit_symtab * block_iterator::compunit_symtab () const { + /* The compunit field is only used when iterating over global or static + blocks. */ + gdb_assert (this->which != FIRST_LOCAL_BLOCK); + if (this->idx == -1) return this->compunit_symtab_; -- 2.52.0