From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SZBWF/ubgWnCXiUAWB0awg (envelope-from ) for ; Tue, 03 Feb 2026 01:55:55 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=uZGk+JES; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A0271E0BA; Tue, 03 Feb 2026 01:55:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E82CB1E089 for ; Tue, 03 Feb 2026 01:55:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 68BC34BB58EE for ; Tue, 3 Feb 2026 06:55:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68BC34BB58EE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=uZGk+JES Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A6EE74BB58EE for ; Tue, 3 Feb 2026 06:54:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6EE74BB58EE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6EE74BB58EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770101688; cv=none; b=P4qQt5B+7A5m8JwoYdrzEwihlIjz1+/dCkX0I6kw4J9LKWAEdoyJrlsm5a/H3xzPWzQts38fy7Dis/8ERr8ZfKSAeeZvBQBK5lYjqlmAsKrNGWbL9Dzj72IEp25BOWYHAEHj5mXce7Gnlql5U2BlQ/+4wBPcyvTv3IyW4BnQdIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770101688; c=relaxed/simple; bh=d1x6/Aac093m43WlaZdys/TLOQyJT6G1HmgpTzsxWYM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=C98FzddqYu2uBNasY283/Qvcrd4HtSq7bR8cstVox23OzcrJC8EBzJBPwNgn9dmPJtAYQc2NN30hzpRv6B8iJJv8BwbEXS+UJOk6kjfO9QhoVk+JRygkf4RjnzjFycWzRsUjsO5zccdNy2odHoS+WRyDYVTwneEcV+S3KHLclHA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6EE74BB58EE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 6136scf6180208 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Feb 2026 01:54:42 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 6136scf6180208 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770101683; bh=kOKrqSdVPCA+aOmIGI13l63dmFXuth1/L2iLtvD18Fk=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=uZGk+JES53aU8HcHCOIbO3P7snZyyZbncerysDg0qF2bI8PKETnWQJkoxU95qDbC0 3YrUa2G3PHmpRko/zoUXbULDRpp9La2q6GAI8T5yuY/Ie1PK7TgmfaYW+DdyXvQwgd wJv1PMEvKhukzIK+sHPGV7QziQakBKIY+OoYdaqWpX74M88HWsZGe17g4XfvAonAaE 1QNlh18cOGQoI2BzFOln8rascpOmxsX04IMvB3ltKTk9AyyRaiuFa2EVArsQdUWI+J FmvqFbpy6SuuBGlywi3IN4/cYpZ3jHR1LFE69EQz5Lo0TB8u+1ZxcKqSBpAj48BUuT R5OvoPUfMhROQ== Received: by simark.ca (Postfix) id F1ED91E0BA; Tue, 03 Feb 2026 01:54:37 -0500 (EST) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Nick Alcock , Weimin Pan , Simon Marchi Subject: [RFC PATCH 2/8] gdb/ctf: add unique_ptr types Date: Tue, 3 Feb 2026 01:45:43 -0500 Message-ID: <20260203065435.3092465-3-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203065435.3092465-1-simon.marchi@polymtl.ca> References: <20260203065435.3092465-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 3 Feb 2026 06:54:38 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi Add ctf_archive_up and ctf_dict_up to automatically manage the lifetime of a ctf_archive_t of ctf_dict_t and use them. Change-Id: I51b3548b1bb28941c7bad776a11a238eb25789e4 --- gdb/ctfread.c | 56 ++++++++++++++++++++++++++++++++------------------- 1 file changed, 35 insertions(+), 21 deletions(-) diff --git a/gdb/ctfread.c b/gdb/ctfread.c index 141f51f621b0..5fd55d3f78f3 100644 --- a/gdb/ctfread.c +++ b/gdb/ctfread.c @@ -125,28 +125,40 @@ ctf_kind_str (uint32_t kind) using ctf_type_map = gdb::unordered_map; -struct ctf_dict_info +struct ctf_archive_closer { - explicit ctf_dict_info (ctf_dict_t *dict) : dict (dict) {} - ~ctf_dict_info (); + void operator() (ctf_archive_t *arc) const noexcept + { + ctf_close (arc); + } +}; - /* Map from IDs to types. */ - ctf_type_map type_map; +using ctf_archive_up = std::unique_ptr; - /* The dictionary. */ - ctf_dict_t *dict; +struct ctf_dict_closer +{ + void operator() (ctf_dict_t *dict) const noexcept + { + ctf_dict_close (dict); + } }; -/* Cleanup function for the ctf_dict_key data. */ -ctf_dict_info::~ctf_dict_info () +using ctf_dict_up = std::unique_ptr; + +struct ctf_dict_info { - if (dict == nullptr) - return; + explicit ctf_dict_info (ctf_archive_up archive, ctf_dict_up dict) + : archive (std::move (archive)), + dict (std::move (dict)) + {} - ctf_archive_t *arc = ctf_get_arc (dict); - ctf_dict_close (dict); - ctf_close (arc); -} + /* Map from IDs to types. */ + ctf_type_map type_map; + + /* The archive and dictionary. */ + ctf_archive_up archive; + ctf_dict_up dict; +}; static const registry::key ctf_dict_key; @@ -1542,26 +1554,28 @@ elfctf_build_psymtabs (struct objfile *of) CTF_SCOPED_DEBUG_START_END ("building psymtabs for %s", bfd_get_filename (abfd)); - ctf_archive_t *arc = ctf_bfdopen (abfd, &err); + ctf_archive_up arc (ctf_bfdopen (abfd, &err)); if (arc == nullptr) error (_("ctf_bfdopen failed on %s - %s"), bfd_get_filename (abfd), ctf_errmsg (err)); - ctf_dict_t *dict = ctf_dict_open (arc, NULL, &err); + ctf_dict_up dict (ctf_dict_open (arc.get (), NULL, &err)); if (dict == nullptr) error (_("ctf_dict_open failed on %s - %s"), bfd_get_filename (abfd), ctf_errmsg (err)); - ctf_dict_key.emplace (of, dict); - pcu.dict = dict; + ctf_dict_info *dict_info + = ctf_dict_key.emplace (of, std::move (arc), std::move (dict)); + + pcu.dict = dict_info->dict.get (); pcu.of = of; - pcu.arc = arc; + pcu.arc = dict_info->archive.get (); psymbol_functions *psf = new psymbol_functions (); of->qf.emplace_front (psf); pcu.psf = psf; - if (ctf_archive_iter (arc, build_ctf_archive_member, &pcu) < 0) + if (ctf_archive_iter (pcu.arc, build_ctf_archive_member, &pcu) < 0) error (_("ctf_archive_iter failed in input file %s: - %s"), bfd_get_filename (abfd), ctf_errmsg (err)); } -- 2.52.0