From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tHnCEx7igGnniyQAWB0awg (envelope-from ) for ; Mon, 02 Feb 2026 12:42:54 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TcdovVph; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3AC791E0BA; Mon, 02 Feb 2026 12:42:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEAB81E08D for ; Mon, 02 Feb 2026 12:42:53 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 235CE4BB58EE for ; Mon, 2 Feb 2026 17:42:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 235CE4BB58EE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TcdovVph Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id AC4EB4BA9035 for ; Mon, 2 Feb 2026 17:42:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC4EB4BA9035 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC4EB4BA9035 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770054147; cv=none; b=sHarE1X1PgjNBOqhK+FJNOG5QAOtZ1F4WkBE5dJaRBkqTS9LXFqCtV9ReIjy7kpUqF8eX68gZ24lEPZIS6/GO1qHqKz4XK3SXm2ArnHvSgvTvIlD/glmCQ82pGuQYpyN2bARnRhaacj8DJFloRZg+Z5VGZgqWWrtcOleAkE4Z00= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770054147; c=relaxed/simple; bh=c8AJwtbErYTVjS8Q3trbDApdpPrUUsQIkFGq/D1zFT4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=tVmeKFMDxHwo80aiKcMz/6ggZVjtXFktMmnFN86Q70a9o6gcoYpX3aT1N2oFT2k1F+mpl1ZtCUuGTHXZjc7QNGzmPOKUcW2cFTGfQgL8Ns8KFidIfpXZf95A55Jz/oL7hJkbt/oj1XzBY73g/VX2iZ4/iEq/+5TMazeWtAtyZhE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC4EB4BA9035 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770054147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRh6sSwinl5ehupOY1FHCiKSgeLstgvNnx1wZPrg1Hw=; b=TcdovVphbhBrDQbQIGiHGHLRshwteHg/9DGJJEYaT+ikxoFaMvWE9av0Wycr0zoM1rBReB Nsw5dYz5dHnZxRlryghfPL5hmLsTKGDVb2jTx6FKDq3Q1jc24zpT1n4S+aF5GHy9X04kWu 94ldbDagqZxnKBBoSfmpNGsjgOajqF0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-3X-dPmDFN7u9o6XfCjmRiA-1; Mon, 02 Feb 2026 12:42:22 -0500 X-MC-Unique: 3X-dPmDFN7u9o6XfCjmRiA-1 X-Mimecast-MFC-AGG-ID: 3X-dPmDFN7u9o6XfCjmRiA_1770054141 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9366C19560BF; Mon, 2 Feb 2026 17:42:21 +0000 (UTC) Received: from f42-mesa-1 (unknown [10.22.64.64]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 98DC41956053; Mon, 2 Feb 2026 17:42:20 +0000 (UTC) Date: Mon, 2 Feb 2026 10:42:18 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH] gdb/dwarf: turn some errors into asserts Message-ID: <20260202104218.7aa08244@f42-mesa-1> In-Reply-To: <20260126170120.268777-1-simon.marchi@efficios.com> References: <20260126170120.268777-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7LGomMG0bdhG07QowzblQU_Y-EWqRY5bwcvmUffceYk_1770054141 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 26 Jan 2026 12:01:17 -0500 Simon Marchi wrote: > From: Simon Marchi > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH] gdb/dwarf: turn some errors into asserts > Date: Mon, 26 Jan 2026 12:01:17 -0500 > > From: Simon Marchi > > There are some nullptr checks on the return value of load_cu that I > think can't possibly ever be true. load_cu returns nullptr only if the > CU is "dummy". A "dummy" CU is one that has a header but no DIE. The > body (the part after the header, included in the unit reported by the > header) is either empty or consists only of zeroes (null entries). > > In the various spots I modified we are doing some work (e.g. evaluating an > expression) in the context of PER_CU, so PER_CU can't possibly be empty > / dummy. > > Change those conditions to asserts. No behavior change expected, unless > my reasoning is incorrect. I agree with your reasoning. Approved-by: Kevin Buettner