From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id adAoJi6wfGkksB0AWB0awg (envelope-from ) for ; Fri, 30 Jan 2026 08:20:46 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TBhY4XX3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 980881E08D; Fri, 30 Jan 2026 08:20:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 401651E08D for ; Fri, 30 Jan 2026 08:20:46 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A2E7B4BA23F7 for ; Fri, 30 Jan 2026 13:20:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2E7B4BA23F7 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TBhY4XX3 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id EE1F84BB3BC1 for ; Fri, 30 Jan 2026 13:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE1F84BB3BC1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE1F84BB3BC1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769779049; cv=none; b=nRDzYct6/jxZNv/RM4gcVM1O63QGl1xEZ5w+UAhE1sq/ASobc2cAVAMElCnNpt7rrPIw9GqpaidtKfTm3+cs29zjn0vdintfypYLU+GWn3xfvHLkF2Xs42FTXRWLl+3p6CrE/sVyqDwLyJb7D85fir6t/rma7v4gSDQC7AJFA5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769779049; c=relaxed/simple; bh=SXiepQiWnYu1wm80RcTBJoqIi36zT4fTJBXkAZ5XTxM=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Ljo5INL7Z4MWHLr+MCpSffrVkX8Yf35XQ2eWNXkLwHLT3K0GcacmDdxd9i5Gt0QtxZCIOy1Vb3BCjOramJLUoCqB3r+iLznOHmcH0ICBwe8IB67HBej8BYRvtFFtmoH6jmvanqFy5y7MmRxr/rjIzHeITf47CQ/OOQROfrG6gsg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE1F84BB3BC1 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id lffwvFyAAKjfoloNLvUHmr; Fri, 30 Jan 2026 13:17:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id loNLvVYatOs9RloNLvvYu6; Fri, 30 Jan 2026 13:17:27 +0000 X-Authority-Analysis: v=2.4 cv=HPPDFptv c=1 sm=1 tr=0 ts=697caf67 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=YkDfKrMQzgVh9zySfpYA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yUTnWuMAiQuqC5Mds5u/BlJIsjblTPg6fMIGE+d4lNM=; b=TBhY4XX3bqX2VxZkpRa9yn+g40 78bvEWE1Lqv/tUAvYbnPbZPj6LgHokkIXoKDr5v27/lzrG65QQGrAVz5P82tbqlsRDtLCveJ6ujdG EmCZTKRSgjlCYw8u7oHHvcnBf; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:33716 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vloNK-00000001JjQ-4B27; Fri, 30 Jan 2026 06:17:27 -0700 From: Tom Tromey Date: Fri, 30 Jan 2026 06:17:33 -0700 Subject: [PATCH v3 19/21] Use std::make_unique with ui_files MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260130-pr-28948-logging-5-v3-19-3eec47ef3cba@tromey.com> References: <20260130-pr-28948-logging-5-v3-0-3eec47ef3cba@tromey.com> In-Reply-To: <20260130-pr-28948-logging-5-v3-0-3eec47ef3cba@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vloNK-00000001JjQ-4B27 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net ([192.168.122.1]) [97.122.114.32]:33716 X-Source-Auth: tom+tromey.com X-Email-Count: 31 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFCbEah7RP3wsQMj/xhPfoY7pTxKBbchh34yz/rtUBixwYxaBulP5YIEF9cr/MPyzgBEYLN/HsXQudC0nQnTyf/6ZBP5eWMTKn00mN6bAdW+EcuDITtz HaApnliIwyva2rEo7aao3JCBeQC630Qm7Kg3hBtWQfM/hMVSTRXK/F3NSfQr9LHIgUxcPqNU59Mw/WRaNNCkwPYjrnC86KcunL0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes a couple of spots to use std::make_unique rather than 'new'. This is a bit more idiomatic. I've only touched code involving ui_file here, there are plenty more changes like this that could be made, but I considered those unrelated to this series. --- gdb/cli/cli-logging.c | 2 +- gdb/serial.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index 8d22a62fa02..836c24445bc 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -232,7 +232,7 @@ handle_redirections (int from_tty) return; } - stdio_file_up log (new no_terminal_escape_file ()); + stdio_file_up log = std::make_unique (); if (!log->open (logging_filename.c_str (), logging_overwrite ? "w" : "a")) perror_with_name (_("set logging")); diff --git a/gdb/serial.c b/gdb/serial.c index c27e3792715..f034c1c94eb 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -238,7 +238,7 @@ serial_open_ops_1 (const struct serial_ops *ops, const char *open_name) if (!serial_logfile.empty ()) { - stdio_file_up file (new stdio_file ()); + stdio_file_up file = std::make_unique (); if (!file->open (serial_logfile.c_str (), "w")) perror_with_name (serial_logfile.c_str ()); -- 2.49.0