From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uzcyBy2we2nRJhwAWB0awg (envelope-from ) for ; Thu, 29 Jan 2026 14:08:29 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OkOaUjqt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0286B1E0DD; Thu, 29 Jan 2026 14:08:28 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A4911E08D for ; Thu, 29 Jan 2026 14:08:28 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B20784BAD147 for ; Thu, 29 Jan 2026 19:08:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B20784BAD147 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OkOaUjqt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B00944BA5436 for ; Thu, 29 Jan 2026 19:07:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B00944BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B00944BA5436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769713677; cv=none; b=i7RVtgXSH4VZp2Q+6kaRQSWMTUPvCx2wKP3cllvrOOR6F2gZEuqBTwurRfu+VZ7rtp/6XtGidLdmJb4QMNSojkhXA7lcI4J2lGHeoswWfMGCqrDSvyR3nohOj75w7KxzXid7ngCEykEqh/nhJNW1bFRB+O5et/gF6akcyphS6lE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769713677; c=relaxed/simple; bh=yzoE5zamlQ5g8BXjNIF7JTHG8OSCUGvCck98TxndHmI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ptq2Kir2gXzwcIs8yGumYSmk4pOpq9eZ2lUnOCnNtiMkICIknathdzlnNzAF3bPEMExYFx6lzQWYcsPVfPor/K26/dlMUenrq8fZKmUzIWzU9BHtmVNBTEUoO39W0lHV2PWd3qKEdwcEXtZ+IP+WVV4WRg1fHlQeKovxfZNjz9g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B00944BA5436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769713677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AfOMS1dSezczDvxCXCaymNBQwAwO9hFWahLU498PVMA=; b=OkOaUjqtu6YzmcNJ2gZTO0clWmVpRNgehn1cmA+XpnSimj8yE5ndFlHBjXXYs1aSrPLql8 TrgXjHuFNW4BQWhCC6u8q3T/1DnzffrYDshXJaPSNLDPrpMUci9BLXeD4/xcaUdO1rU5VG coDSMWzyQJQLljADHEc0UA5u10xt+eQ= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-fG5kNfPDO8K9wUF7j9u0uQ-1; Thu, 29 Jan 2026 14:07:54 -0500 X-MC-Unique: fG5kNfPDO8K9wUF7j9u0uQ-1 X-Mimecast-MFC-AGG-ID: fG5kNfPDO8K9wUF7j9u0uQ_1769713673 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F7BF18005B0; Thu, 29 Jan 2026 19:07:53 +0000 (UTC) Received: from f42-mesa-1 (unknown [10.22.64.64]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 436E53000218; Thu, 29 Jan 2026 19:07:52 +0000 (UTC) Date: Thu, 29 Jan 2026 12:07:49 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Remove some uses of alloca from cli/ Message-ID: <20260129120749.7f31aa5d@f42-mesa-1> In-Reply-To: <20260122-command-no-alloca-v1-0-402aa429bbbf@adacore.com> References: <20260122-command-no-alloca-v1-0-402aa429bbbf@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d1KbeAnkDaSR6rWS1gDzxHFbk6H7BxhZT2aZMqojsh0_1769713673 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 22 Jan 2026 13:49:10 -0700 Tom Tromey wrote: > I found some spots in the CLI code that needlessly use alloca. This > patch fixes these. > > Regression tested on x86-64 Fedora 41. > > Signed-off-by: Tom Tromey > --- > Tom Tromey (3): > Use string_view in cli-decode.c:find_cmd > Don't make copies when calling find_cmd > Remove alloca from lookup_cmd I've looked over all three patches. All LGTM. Approved-By: Kevin Buettner