From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 2/2] Regularize spelling of names of keys
Date: Mon, 26 Jan 2026 08:32:46 -0700 [thread overview]
Message-ID: <20260126-metasyntactic-v1-2-02e22dbe6c2b@adacore.com> (raw)
In-Reply-To: <20260126-metasyntactic-v1-0-02e22dbe6c2b@adacore.com>
This changes gdb to use <KEY> when referring to the name of a key that
the user should press -- basically for return and tab.
In one spot, an obsolete use of <return> is removed.
---
gdb/cli/cli-cmds.c | 4 ++--
gdb/cli/cli-decode.h | 2 +-
gdb/testsuite/lib/mi-support.exp | 5 -----
gdb/utils.c | 2 +-
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 6fa5a61ae02..5cf8f87cd75 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -2674,8 +2674,8 @@ Here are some common GDB behaviors that you can expect, which are\n\
not tied to any specific command but rather GDB functionality itself:\n\
\n\
EXPR is any arbitrary expression valid for the current programming language.\n\
-Pressing <return> with an empty prompt executes the last command again.\n\
-You can use <tab> to complete commands and symbols. Pressing it twice lists\n\
+Pressing <RET> with an empty prompt executes the last command again.\n\
+You can use <TAB> to complete commands and symbols. Pressing it twice lists\n\
all possible completions if more than one is available."),
&cmdlist);
add_cmd ("internals", class_maintenance, _("\
diff --git a/gdb/cli/cli-decode.h b/gdb/cli/cli-decode.h
index fd9e2b7fcff..865f89ed9b5 100644
--- a/gdb/cli/cli-decode.h
+++ b/gdb/cli/cli-decode.h
@@ -171,7 +171,7 @@ struct cmd_list_element
/* Nonzero says this is an abbreviation, and should not
be mentioned in lists of commands.
- This allows "br<tab>" to complete to "break", which it
+ This allows "br<TAB>" to complete to "break", which it
otherwise wouldn't. */
unsigned int abbrev_flag : 1;
diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
index 1dc389dea71..e21570c88b1 100644
--- a/gdb/testsuite/lib/mi-support.exp
+++ b/gdb/testsuite/lib/mi-support.exp
@@ -838,11 +838,6 @@ proc mi_gdb_test { args } {
fail "$message (unexpected output)"
}
set result 1
- }
- "<return>" {
- send_gdb "\n"
- perror "Window too small."
- fail "$message"
}
eof {
perror "Process no longer exists"
diff --git a/gdb/utils.c b/gdb/utils.c
index ceea8317dc5..a121a6ea576 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1483,7 +1483,7 @@ pager_file::prompt_for_continue ()
}
/* Now we have to do this again, so that GDB will know that it doesn't
- need to save the ---Type <return>--- line at the top of the screen. */
+ need to save the ---Type <RET>--- line at the top of the screen. */
reinitialize_more_filter ();
pagination_disabled_for_command = disable_pagination;
--
2.52.0
next prev parent reply other threads:[~2026-01-26 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 15:32 [PATCH 0/2] Metasyntactic formatting nits Tom Tromey
2026-01-26 15:32 ` [PATCH 1/2] Use upper case for "metasyntactic variables" Tom Tromey
2026-01-26 15:32 ` Tom Tromey [this message]
2026-02-02 17:16 ` [PATCH 0/2] Metasyntactic formatting nits Kevin Buettner
2026-02-02 19:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126-metasyntactic-v1-2-02e22dbe6c2b@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox