From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uSxsNmWJd2kCOBYAWB0awg (envelope-from ) for ; Mon, 26 Jan 2026 10:33:57 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jBS14xcs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D801C1E0AD; Mon, 26 Jan 2026 10:33:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4601F1E08D for ; Mon, 26 Jan 2026 10:33:57 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C4C924BC7ED2 for ; Mon, 26 Jan 2026 15:33:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4C924BC7ED2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jBS14xcs Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 42F2E4BC895C for ; Mon, 26 Jan 2026 15:32:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42F2E4BC895C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42F2E4BC895C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769441570; cv=none; b=tua7vI5w/3xvIhpqkeCI9zSkd+ASJNmiTBGU6lM04/yzfy78m4ALqLxl8XCQin9PWtC0eRfmgM2ByqNN0ciA6HqohrbEto/qyhjcmfRiLCLelHAF1ZkKgA777XD6V0mjYY+1/IlmP1blc5NVFQzBGeU3S1e5dcpVAFg24z8HRV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769441570; c=relaxed/simple; bh=uXmaJRePqLGUqgTb6tRFWydjH+xtBflxJBjizZLzHLE=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=dBBT6O6oQar6eIIzdU2VKEJWzwUzPH3f4szFheiOR4MhEsX5CCLMXb9CwKDqta9BH6wmhBZDHHABnhJJ1hBGZ6jo/Fh7logR5ztRn1hP41tz6aGbnOHlkD854PxJ6NDko12GPt02TjIap1ydfcIwN90isF+HDLdBPMScg+JKek8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42F2E4BC895C Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-45c9f47e1e8so1182032b6e.0 for ; Mon, 26 Jan 2026 07:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1769441569; x=1770046369; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jk7g55fozOcjzo0QPSeQn6JEOlwMrDB/2K1uEl4BZZo=; b=jBS14xcsGG4lLV2acJ1g+T0IQolYNDw6ou3ncVWREZPmAyR36LxtbzuZOck+Wz8Xjf PFQ/UOMbG4ZaIpwiAHKx1vHwuOZsN8WZeAK9BFanBgTHOJZtNoGifqrSc8XA5h8qzCSp Y3OjMTqCM3awGYMkZbPtEGyLdHIh9YjwgLcQqeUveXx1tPq48bxZA+H0OR+OpzWFFX4m 8O62pwLxYHAl3jb+9A8xYxF2xdX4TTRK+KQxV+kRelgTe28M+C1sCoyk0IAd3Y7v+JyH 7zoGXvYSDb4sc3OniNPytwS1XTWcuyHoahM7riOaJ1syKgl/O6WlUnXjPiBwRnLfkJX6 TviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769441569; x=1770046369; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jk7g55fozOcjzo0QPSeQn6JEOlwMrDB/2K1uEl4BZZo=; b=bTkwXD8BYYaPCxtRkJX30h5eupecfMxA8BqbDdSvfGo9bOkZdZJEeZuUtX33V9yxxj 39juPzzez68ZHf+J+eRimQj3ZcUMaGdC+U7/PcJkefESOOSLuLIMTysObV8fyBfGiaG0 UaYs+3W9ErKXQtLLQsJvM3/SXn+5i+sNtq5j0pAQ13nOFyJUOVzUPodWu7lUWv6M4Eem ccHHwI+2ZumLgX4UMsOuhl/TvybVafLY3wBU+bI0C8mMAgD5cTT5WOaJcdMglX0IRkly mjANfi1aJSLZM2X6IUanw/9qIk9Rs2+6uKzX82JNWLZsIuZQkdGzzkINJcQnAbLsmTZp aXDg== X-Gm-Message-State: AOJu0YzgW4SdVnky5lqrNN0iuEX0H/8L5MAGzAoICkTTOIn+8LvwVChA lxg4LEXYLujW0k5N5uJ01dM258oxWZ2sAYZ1FAK4Y4EqgXM1PUxW7BmQq+0fgQ2S9es4gffvm6y RXco= X-Gm-Gg: AZuq6aL5zdOwidMe3R7mglSwMBLAOwTjbal2c/NlnVtvIuXSxwRibTkexwvNPrmGsrB vqKRad7R18MCZILOnfHTy6K8ReQdONpZL1JxFRA0WHfCdTp3dyu0/1jTtECQszUb/hsnU+s74LA Tf9x1lImdrQOvbxYBptekPiPhQFQ0RUXipael54FmbExpX9F/gD6iHnTXE9dJIy8x9jsZtPO+Yh bxXIZk0JpHIkY296rviQZV0THDxKcjfjVacZVRMRPtjzEQ32XpisC1Vl9YvgGMEknfLSmmcrJhx wMwSXKBZvNh94KfsZvd0wEVesKa+bEC6g+v2KdHYxCEnVRZOUZfuJAtbzekHAIfipB0GvEzz99r +FFWupy1uqd67GMifQAo7TbDV6R40UlJc9HRkEb8+1CakHQRNppSQk9KqLAG9f1tZh6UXg5Tk08 KVaOV+oTzYy+Hzr9WeqIqCiYrGvJMzrUYayVuM7Qta2w== X-Received: by 2002:a05:6808:f8f:b0:450:5e3a:6f20 with SMTP id 5614622812f47-45ed9888120mr2255491b6e.10.1769441569486; Mon, 26 Jan 2026 07:32:49 -0800 (PST) Received: from [192.168.0.26] (97-122-114-32.hlrn.qwest.net. [97.122.114.32]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45eb40e39d4sm6020293b6e.2.2026.01.26.07.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 07:32:49 -0800 (PST) From: Tom Tromey Date: Mon, 26 Jan 2026 08:32:45 -0700 Subject: [PATCH 1/2] Use upper case for "metasyntactic variables" MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260126-metasyntactic-v1-1-02e22dbe6c2b@adacore.com> References: <20260126-metasyntactic-v1-0-02e22dbe6c2b@adacore.com> In-Reply-To: <20260126-metasyntactic-v1-0-02e22dbe6c2b@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org GNU typically uses all upper-case to refer to user-supplied text, as opposed to the other common convention of angle brackets. This patch fixes the cases of the latter that I found in help and error text. --- gdb/cli/cli-cmds.c | 4 ++-- gdb/printcmd.c | 34 +++++++++++++++++----------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index a37e38e9709..6fa5a61ae02 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -2667,8 +2667,8 @@ INIT_GDB_FILE (cli_cmds) add_cmd ("essential", class_essential, _("\ GDB essential commands.\n\ Welcome to GDB! This help text aims to provide a quickstart explanation\n\ -that will allow you to start using GDB. Feel free to use \"help \"\n\ -to get further explanations for any command , and check the online\n\ +that will allow you to start using GDB. Feel free to use \"help CMD\"\n\ +to get further explanations for any command CMD, and check the online\n\ documentation for in-depth explanations.\n\ Here are some common GDB behaviors that you can expect, which are\n\ not tied to any specific command but rather GDB functionality itself:\n\ diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 7c97fc71992..666ed5a8a64 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -3036,7 +3036,7 @@ memory_tag_with_logical_tag_command (const char *args, int from_tty) show_memory_tagging_unsupported (); if (args == nullptr) - error_no_arg (_("
")); + error_no_arg (_("ADDRESS TAG")); gdb::byte_vector tags; struct value *val; @@ -3116,7 +3116,7 @@ parse_set_allocation_tag_input (const char *args, struct value **val, } /* Implement the "memory-tag set-allocation-tag" command. - ARGS should be in the format
. */ + ARGS should be in the format ADDRESS LENGTH TAGS. */ static void memory_tag_set_allocation_tag_command (const char *args, int from_tty) @@ -3125,7 +3125,7 @@ memory_tag_set_allocation_tag_command (const char *args, int from_tty) show_memory_tagging_unsupported (); if (args == nullptr) - error_no_arg (_(" ")); + error_no_arg (_("STARTING-ADDRESS LENGTH TAG-BYTES")); gdb::byte_vector tags; size_t length = 0; @@ -3399,37 +3399,37 @@ Generic command for printing and manipulating memory tag properties."), add_cmd ("print-logical-tag", class_vars, memory_tag_print_logical_tag_command, ("Print the logical tag from POINTER.\n\ -Usage: memory-tag print-logical-tag .\n\ - is an expression that evaluates to a pointer.\n\ +Usage: memory-tag print-logical-tag POINTER.\n\ +POINTER is an expression that evaluates to a pointer.\n\ Print the logical tag contained in POINTER. The tag interpretation is\n\ architecture-specific."), &memory_tag_list); add_cmd ("print-allocation-tag", class_vars, memory_tag_print_allocation_tag_command, _("Print the allocation tag for ADDRESS.\n\ -Usage: memory-tag print-allocation-tag
.\n\ -
is an expression that evaluates to a memory address.\n\ +Usage: memory-tag print-allocation-tag ADDRESS.\n\ +ADDRESS is an expression that evaluates to a memory address.\n\ Print the allocation tag associated with the memory address ADDRESS.\n\ The tag interpretation is architecture-specific."), &memory_tag_list); add_cmd ("with-logical-tag", class_vars, memory_tag_with_logical_tag_command, _("Print a POINTER with a specific logical TAG.\n\ -Usage: memory-tag with-logical-tag \n\ - is an expression that evaluates to a pointer.\n\ - is a sequence of hex bytes that is interpreted by the architecture\n\ +Usage: memory-tag with-logical-tag POINTER TAG\n\ +POINTER is an expression that evaluates to a pointer.\n\ +TAG is a sequence of hex bytes that is interpreted by the architecture\n\ as a single memory tag."), &memory_tag_list); add_cmd ("set-allocation-tag", class_vars, memory_tag_set_allocation_tag_command, _("Set the allocation tag(s) for a memory range.\n\ -Usage: memory-tag set-allocation-tag
\n\ -
is an expression that evaluates to a memory address\n\ - is the number of bytes that is added to
to calculate\n\ +Usage: memory-tag set-allocation-tag ADDRESS LENGTH TAG-BYTES\n\ +ADDRESS is an expression that evaluates to a memory address\n\ +LENGTH is the number of bytes that is added to ADDRESS to calculate\n\ the memory range.\n\ - is a sequence of hex bytes that is interpreted by the\n\ +TAG-BYTES is a sequence of hex bytes that is interpreted by the\n\ architecture as one or more memory tags.\n\ Sets the tags of the memory range [ADDRESS, ADDRESS + LENGTH)\n\ -to TAG_BYTES.\n\ +to TAG-BYTES.\n\ \n\ If the number of tags is greater than or equal to the number of tag granules\n\ in the [ADDRESS, ADDRESS + LENGTH) range, only the tags up to the\n\ @@ -3442,8 +3442,8 @@ that gets repeated until the number of tag granules in the memory range\n\ &memory_tag_list); add_cmd ("check", class_vars, memory_tag_check_command, _("Validate a pointer's logical tag against the allocation tag.\n\ -Usage: memory-tag check \n\ - is an expression that evaluates to a pointer\n\ +Usage: memory-tag check POINTER\n\ +POINTER is an expression that evaluates to a pointer\n\ Fetch the logical and allocation tags for POINTER and compare them\n\ for equality. If the tags do not match, print additional information about\n\ the tag mismatch."), -- 2.52.0