From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ke98JkLed2kIrRYAWB0awg (envelope-from ) for ; Mon, 26 Jan 2026 16:36:02 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=w6qi6kmd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 980311E0DD; Mon, 26 Jan 2026 16:36:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3D9411E089 for ; Mon, 26 Jan 2026 16:36:02 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B56794BA2E30 for ; Mon, 26 Jan 2026 21:36:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B56794BA2E30 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=w6qi6kmd Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 96BB54BA9024 for ; Mon, 26 Jan 2026 21:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 96BB54BA9024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 96BB54BA9024 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; cv=none; b=o29EpMrGIOCFxDHuUZkJZDf42GUnd6RsTlS49xf75+oZf/NaZ6FIt7jWcjB8QLtnCYR/YT2deO7YXyzQ+JK6pWz4D8aozXnC4/7Rdw9c13kid3iFeUFxefSX/c8c56MJtRx6spk4yOVLIHkLJa7aCFiokejrtFS8mvM3kyPXH5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; c=relaxed/simple; bh=QhAPVwZzQIxxayhmz5qeDLjF040FRBI9ZPjKKJq/chA=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=k5qpwfxta71ZhfyqAmSzG3ZEfuGnabx4k/sjaEk7fqpmVuFU3lv/WfUNuSk0hArSrU9KfDn06szKW0M5Xflh5S0Io6FY1F2o1MArShAY/BgVU1Uq3mycsyEnyrUT/la211TlVMOCPunwDiCIhr2ffaX1+qZrrNP+xpZVECnq5HQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96BB54BA9024 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id kTaTvdtS3aPqLkUDBvvvxb; Mon, 26 Jan 2026 21:33:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kUDAv5J2qvXvHkUDBvFNc0; Mon, 26 Jan 2026 21:33:29 +0000 X-Authority-Analysis: v=2.4 cv=e4IGSbp/ c=1 sm=1 tr=0 ts=6977dda9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=B_Tv2JfvxkIVyvo0GuEA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1KOkAzfEUc26N7kqejs4FpfZKnOO0U1TK8vJFYQWTLo=; b=w6qi6kmd3OkXRzMVCN3omSu3EG mdCWIK/EQaJpyq1GJjBxqPL+S4wIOr9zZTTd5IPygb0ASAj9o9NVeh0H3K0CUn7jf2YekkDslNeQw CzaLsDZvkIFMlegNk0s3XV7c/; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:44294 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vkUDA-00000003cBe-3AN1; Mon, 26 Jan 2026 14:33:28 -0700 From: Tom Tromey Date: Mon, 26 Jan 2026 14:33:04 -0700 Subject: [PATCH v2 2/8] Skip partial units in process_psymtab_comp_unit MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-2-8ab183d1911c@tromey.com> References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vkUDA-00000003cBe-3AN1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net ([192.168.122.1]) [97.122.114.32]:44294 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOFMOYaubD5Db2vBwjfiPNMc+J9PyLuu3U+00dOUN45uc2kH2tshd6ruvGCsmqw8NNu7iCP9VFPyw4k1JVTgwnbgJv+cXvqA5eE0Ns6uPjXL3A19SMe3 OgtiM03RMaIVIqZp/rpnaPb3jHjsvN/Uskok8YWHA2kzKLMIvn9iaISeztuppayhgPErqRYR5yX+LTZjthQPh3upG4fxsOrVto4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org process_psymtab_comp_unit passes 'false' for the 'skip_partial' argument to the cutu_reader constructor, but then proceeds to skip partial units. This patch simplifies the code by passing 'true' instead. --- gdb/dwarf2/read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 036ec7e6337..b8f758ae8c7 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3436,7 +3436,7 @@ cooked_index_worker_debug_info::process_unit const abbrev_table_cache &abbrev_table_cache = storage->get_abbrev_table_cache (); auto new_reader = std::make_unique (*this_cu, *per_objfile, - nullptr, nullptr, false, + nullptr, nullptr, true, std::nullopt, &abbrev_table_cache); @@ -3451,7 +3451,7 @@ cooked_index_worker_debug_info::process_unit if (this_cu->is_debug_types ()) process_type_unit (reader, storage); - else if (reader->top_level_die ()->tag != DW_TAG_partial_unit) + else { bool nope = false; if (this_cu->scanned.compare_exchange_strong (nope, true)) -- 2.49.0