From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MpjBEurdd2kIrRYAWB0awg (envelope-from ) for ; Mon, 26 Jan 2026 16:34:34 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AH9Cvymj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3D8A61E089; Mon, 26 Jan 2026 16:34:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7F791E089 for ; Mon, 26 Jan 2026 16:34:33 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 069884BC7EE0 for ; Mon, 26 Jan 2026 21:34:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 069884BC7EE0 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AH9Cvymj Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 580D74BA23F2 for ; Mon, 26 Jan 2026 21:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 580D74BA23F2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 580D74BA23F2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; cv=none; b=vGG7Q3Oy1UnQ0K52lnypgIFEicfJITYUj8R9KD+lBBuxyqfW5bUMm3u2BklEaIjAtohx8PeUf7WAdNXZFtsMdXW3Q8RQoWZhC8rZzI7qZQGy77wmbT03fScdiWurgwiR74PIyZll2N1YV0BccSMHMjDewTJ5mq8kTnCtrgCVYY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; c=relaxed/simple; bh=lIUNEhy1LyTukpn/lJdVfi3A7FA466vJESUGsfkFO+U=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=kdr9g/WS5+08laxJV+VR8/AVxNGGSmnNsLAYNr4kHRBSsx1YeYwKAORAbXRrYc/gqFmq3+GdiVjPnczkAIYHXb9DwTfDEZUqsV6EYtG7SV7FTXOLZiqknmZaph9sqQmrGuuBHDpkLyazeTW9wuckKhJnEwFfOBUJAplz1UR2bkI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 580D74BA23F2 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id kP0XvpVISKjfokUDBvjkem; Mon, 26 Jan 2026 21:33:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kUDAv5pqvSqlVkUDBv40eh; Mon, 26 Jan 2026 21:33:29 +0000 X-Authority-Analysis: v=2.4 cv=I7FlRMgg c=1 sm=1 tr=0 ts=6977dda9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=WDSbgKPZrbZFA2NwGeYA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DJiXnNuvnm6VRHwazTmBbkMC5anVUvSehh5JjSau4AY=; b=AH9Cvymj7vPa72eeXJsxLTwVyA xCGZoU5dSXKFLmZxecyMx97mXMfw5Cs4ybWBQ30ujoLDeiiAowED029JWXZ/e3CRiQDVrNVOT9ajM LXXAL33rAScbtbmBa+ZtTIkm9; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:44294 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vkUDA-00000003cBe-1u3T; Mon, 26 Jan 2026 14:33:28 -0700 From: Tom Tromey Date: Mon, 26 Jan 2026 14:33:03 -0700 Subject: [PATCH v2 1/8] Don't call add_dependence from index_imported_unit MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-1-8ab183d1911c@tromey.com> References: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> In-Reply-To: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vkUDA-00000003cBe-1u3T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net ([192.168.122.1]) [97.122.114.32]:44294 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCmOvymLrxphCBkueE9RM0zR8W24bbp49EDLNaOVTbRNx5fD7ks4N89v7oFh6boSgj3wcv2iy2PMn6SzpKecCq55MnEYv9u1qX2mqqSQbu4ON//lMo+V 3vfhZg94qxa0ZNnS7dO6wFY52qN/qSXhBrzUzHwDZxn63uldx3ZybiGK6uhBfqRTLG+GRwvNKSYJ3T61g/GWEHQiFZSgv72ZVJE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org cooked_indexer::index_imported_unit calls add_dependence. However, this field is only needed during full symbol reading. Remove this call. --- gdb/dwarf2/cooked-indexer.c | 6 +----- gdb/dwarf2/cu.h | 6 +++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/gdb/dwarf2/cooked-indexer.c b/gdb/dwarf2/cooked-indexer.c index 1d5b5bcca40..b5ccf4588c4 100644 --- a/gdb/dwarf2/cooked-indexer.c +++ b/gdb/dwarf2/cooked-indexer.c @@ -431,11 +431,7 @@ cooked_indexer::index_imported_unit (cutu_reader *reader, cutu_reader *new_reader = ensure_cu_exists (reader, *target, true); if (new_reader != nullptr) - { - index_dies (new_reader, new_reader->info_ptr (), nullptr, false); - - reader->cu ()->add_dependence (new_reader->cu ()->per_cu); - } + index_dies (new_reader, new_reader->info_ptr (), nullptr, false); return info_ptr; } diff --git a/gdb/dwarf2/cu.h b/gdb/dwarf2/cu.h index 97c0b87121b..2e13ad0c397 100644 --- a/gdb/dwarf2/cu.h +++ b/gdb/dwarf2/cu.h @@ -288,9 +288,9 @@ struct dwarf2_cu symbols are being read. */ buildsym_compunit_up m_builder; - /* A set of pointers to dwarf2_per_cu objects for compilation units referenced - by this one. Only used during full symbol processing; partial symbol - tables do not have dependencies. */ + /* A set of pointers to dwarf2_per_cu objects for compilation units + referenced by this one. Only used during full symbol + processing. */ gdb::unordered_set m_dependencies; public: -- 2.49.0