From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EVHbBPTdd2kIrRYAWB0awg (envelope-from ) for ; Mon, 26 Jan 2026 16:34:44 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HNtfOacL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 10FF31E0AD; Mon, 26 Jan 2026 16:34:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 921A11E0DD for ; Mon, 26 Jan 2026 16:34:43 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 176A84BC8955 for ; Mon, 26 Jan 2026 21:34:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176A84BC8955 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HNtfOacL Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 57FA74BA2E30 for ; Mon, 26 Jan 2026 21:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57FA74BA2E30 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57FA74BA2E30 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; cv=none; b=jcdU7LnYZ/flZdjwTPyzTimVVDqGFveY6fYTViHVEClXD5J86liInEj3Ipv9OsTNjSvg08GNUboHyVXESN8S55oPKC9oQpYODjcj7JI1ffUm4z4vlEqQyt790iYcWtvs2ckOR2RJGN6RbGDX5GDwDtoE5TFgSIy15k1CE+ITN8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769463210; c=relaxed/simple; bh=wx4xQ7T4k0srLiooQljHq8zdJfPGZa6VILglyyfXcpo=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=Y3xfV9godoLSVOTuZQ6LrKY4ctA44g3IPBIMOBKkY2W40ycLZIUfsvC75pHW4r2kFpISksg9U4nzo6HMe6YTihSCEfTDmSM+Cw7Evmo8lKVdOJ9hS3b49gIHbIx+buF1NShmy1uBZpXUvuPpgmmZZr6jXGkC0T//Mlcn3XlVQMs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57FA74BA2E30 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id kSkovr7GPKjfokUDBvjkeh; Mon, 26 Jan 2026 21:33:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kUDAvY1LtjAxukUDAviO7t; Mon, 26 Jan 2026 21:33:28 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=6977dda8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=3Fx7I0CSB0swmR94fG8A:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=n6O4ZvAdM/NWAv5YQTlzXZdeZzfpBx9dDO2HXiMofCs=; b=HNtfOacLTv4B/XkzxlyqLOz908 b/PXCdtJcgfFOTiluVK0UXhjfVaLcNke3vUhvLcVZeWVOVEU+3+UBgYce8EhyzqKQfAxUXh08t3Vi huGwHowCAn7rwLbPS42SvEa+z; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:44294 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vkUDA-00000003cBe-0wQQ; Mon, 26 Jan 2026 14:33:28 -0700 From: Tom Tromey Subject: [PATCH v2 0/8] Correctly handle inline functions with dwz Date: Mon, 26 Jan 2026 14:33:02 -0700 Message-Id: <20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAI7dd2kC/5WOTQ6CMBCFr0K6drQ/KODKexgWLQ4yibRkiigh3 N3CDVx+yXvfe4uIyIRRXLNFME4UKfgE+pCJprP+iUCPxEJLfZFKn+HxAfIv8ggtfd8DDAxx7kf rwMhCl6ChaIxyrSlbh0Ykz8CYovvGvU7sbERwbH3TbebA9CR/6m0ckbd8R3EMPO+XJrW1/lmfF EjAqiqMzW0ulb2NHHqcj03oRb2u6w9JHmf58wAAAA== X-Change-ID: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3 To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vkUDA-00000003cBe-0wQQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net ([192.168.122.1]) [97.122.114.32]:44294 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJbBmS06embKJ+wASvVPPvM7JYG/rRZuKJVTKMD7/WA8O+CT1K049rbT3097XeTnArbYpV7AM7fstDg3ODzuaL/9b7ZffnWvW8tlw+2T0iR7GQd0EZch 93R9qpsYsZfyTnLKN9uifNs8EN/PfrpsxqCKYAXwa+kuCF4nEeWez3C7EsuOmGs95vl2EfqvhynSNLBdUQO4+xFjprA0gIYUaK0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The new indexer does not correctly handle inline functions when 'dwz' is used to compress the DWARF. This series fixes the bug, cleaning up a number of other things on the way. I've separately regression tested each patch in this series on x86-64 Fedora 41. I've also regression tested the series as a whole with the dwz, gdb-index, and debug-names boards. Even with that I messed up somehow, so v1 didn't actually fix the bug in question. I must have modified the patches after testing..? Anyway in v2 I've moved the line recording the CU inclusion and added a comment explaining the placement. I re-ran the aformentioned tests and didn't touch anything. Signed-off-by: Tom Tromey --- Changes in v2: - Fixed fix from Tom de Vries for IS_INLINED debug display - Moved line to record inclusion - Link to v1: https://inbox.sourceware.org/gdb-patches/20260125-dw-inline-fixup-pr-symtab-30728-2-v1-0-e9973a4a401a@tromey.com --- Tom Tromey (8): Don't call add_dependence from index_imported_unit Skip partial units in process_psymtab_comp_unit Don't consider DW_TAG_inlined_subroutine as interesting Combine two cases in cooked_index_functions::search Remove C++ special case from process_imported_unit_die Have iterate_over_one_compunit_symtab search included symtabs Handle inline functions with dwz Update .debug_names documentation gdb/doc/gdb.texinfo | 37 +++++++ gdb/dwarf2/abbrev.c | 1 - gdb/dwarf2/cooked-index-entry.c | 24 +++++ gdb/dwarf2/cooked-index-entry.h | 39 ++++++- gdb/dwarf2/cooked-index-worker.c | 14 +++ gdb/dwarf2/cooked-index-worker.h | 26 +++-- gdb/dwarf2/cooked-indexer.c | 60 +++++++---- gdb/dwarf2/cooked-indexer.h | 8 +- gdb/dwarf2/cu.h | 6 +- gdb/dwarf2/index-write.c | 223 ++++++++++++++++++++++----------------- gdb/dwarf2/read.c | 85 +++++++++------ gdb/dwarf2/read.h | 37 +++++++ gdb/symfile-debug.c | 27 +++-- 13 files changed, 410 insertions(+), 177 deletions(-) --- base-commit: 8b601b78f71e6ae7b5aed7c0f8ac30d469f16325 change-id: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3 Best regards, -- Tom Tromey