From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iYQ3E+6WcWmsGg8AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 22:18:06 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HH9ao0wh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E5CB1E089; Wed, 21 Jan 2026 22:18:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E90C1E089 for ; Wed, 21 Jan 2026 22:18:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 55DD94BA9012 for ; Thu, 22 Jan 2026 03:18:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55DD94BA9012 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HH9ao0wh Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 9BDC54BA9003 for ; Thu, 22 Jan 2026 03:17:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BDC54BA9003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9BDC54BA9003 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769051855; cv=none; b=SEOCYpZ99kd5PhOOC9mDjlBVGZlU6HBafqxgkBXRGAj/hXxAdwN1s4p4EeM9abcY2JEurlFhSYmvNsDf4Rp1+ElIrEhLl7uB9sOSi/tUaX8aDPQJK7vgIwCN8Ooyt5rUmO+Lrx+vcYftWLHeOp2FTsRcqLd+l1MafhfZ8zyOlZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769051855; c=relaxed/simple; bh=OqD0yNgb/rGDs6f9JIk9JHIDk9EbDpLbb7AvX6Hp4Pw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=g5ce5bCx8VfQJiqqhob46rRHYW+k95x05j5JMLkCLZuUMnsV09kqKaZ2JFo6GzfR5AXs2NVrxY/MKE/FV58tNLeROYGIT2U0kfR3fJnXAuNhVPKe5bsJX4nA2ILYpMHm83dCdM3/YE60Wc1fdHc4htuMZnAMG/D0ck3ekFI5Epk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BDC54BA9003 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id ihBRv1dMRVCBNilCQv5Q2Q; Thu, 22 Jan 2026 03:17:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ilCPvk4RmjAxuilCPvCGZm; Thu, 22 Jan 2026 03:17:34 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=697196ce a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=YmbVmXrUmZ2FVSosB60A:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zwNWtknDt4tjiZNeGTu4HOXGrVYtnvVKc+JV41cYRQ0=; b=HH9ao0whMVu5agVz2uTAqCMPMv QgSCbDRRcQKxnFDHYcs0772FXMqdC4SVZLZ3btbHHG1/ck2xRqw9j+YOE/VVbWJpokxEleCtS03U8 6Bye/uUNaNua1opOOg0McHOxW; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:59906 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vilCP-00000000uk1-1Ujr; Wed, 21 Jan 2026 20:17:33 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Constify gdbserver "monitor" commands Date: Wed, 21 Jan 2026 20:17:22 -0700 Message-ID: <20260122031722.3089932-1-tom@tromey.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vilCP-00000000uk1-1Ujr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (localhost.localdomain) [97.122.114.32]:59906 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfERsQ9R0MfTQQa2Q4QQT8Xmv75sFdF82gl+IrUhZoPcAJ0DTqGDVrRrccYoit41EHQS75Vd5RSrLJhjtXgyfxh4YcjtgLo8S6LlUivYYFkuo6HwlJkMU 8V3h86/nl5AC9mrXIi0C9cE9fluKpCtMofxuDONChaGTRGb1OcQiQfP4b4lbK36GG/KGX4r/JeUVP5KdezqRF4hKCOssQxsj4qI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that the gdbserver "monitor" commands should take a const parameter. --- gdbserver/linux-low.cc | 2 +- gdbserver/linux-low.h | 4 ++-- gdbserver/server.cc | 2 +- gdbserver/target.cc | 2 +- gdbserver/target.h | 2 +- gdbserver/thread-db.cc | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index b12f7c08b31..ca20a5bca16 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -6003,7 +6003,7 @@ linux_process_target::handle_new_gdb_connection () } int -linux_process_target::handle_monitor_command (char *mon) +linux_process_target::handle_monitor_command (const char *mon) { #ifdef USE_THREAD_DB return thread_db_handle_monitor_command (mon); diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h index ae196f5767a..03e11202955 100644 --- a/gdbserver/linux-low.h +++ b/gdbserver/linux-low.h @@ -245,7 +245,7 @@ class linux_process_target : public process_stratum_target void handle_new_gdb_connection () override; - int handle_monitor_command (char *mon) override; + int handle_monitor_command (const char *mon) override; int core_of_thread (ptid_t ptid) override; @@ -947,7 +947,7 @@ CORE_ADDR linux_get_pc_64bit (struct regcache *regcache); int thread_db_init (void); void thread_db_detach (struct process_info *); void thread_db_mourn (struct process_info *); -int thread_db_handle_monitor_command (char *); +int thread_db_handle_monitor_command (const char *); int thread_db_get_tls_address (thread_info *thread, CORE_ADDR offset, CORE_ADDR load_module, CORE_ADDR *address); int thread_db_look_up_one_symbol (const char *name, CORE_ADDR *addrp); diff --git a/gdbserver/server.cc b/gdbserver/server.cc index fcad2b973d5..674300f8ce0 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -1714,7 +1714,7 @@ handle_general_monitor_debug (const char *mon) /* Handle monitor commands not handled by target-specific handlers. */ static void -handle_monitor_command (char *mon, char *own_buf) +handle_monitor_command (const char *mon, char *own_buf) { if (startswith (mon, "set debug ")) { diff --git a/gdbserver/target.cc b/gdbserver/target.cc index 5a2e96811b3..43ef421df74 100644 --- a/gdbserver/target.cc +++ b/gdbserver/target.cc @@ -550,7 +550,7 @@ process_stratum_target::handle_new_gdb_connection () } int -process_stratum_target::handle_monitor_command (char *mon) +process_stratum_target::handle_monitor_command (const char *mon) { return 0; } diff --git a/gdbserver/target.h b/gdbserver/target.h index d6ab83768d3..82eab9d1243 100644 --- a/gdbserver/target.h +++ b/gdbserver/target.h @@ -288,7 +288,7 @@ class process_stratum_target /* The target-specific routine to process monitor command. Returns 1 if handled, or 0 to perform default processing. */ - virtual int handle_monitor_command (char *mon); + virtual int handle_monitor_command (const char *mon); /* Returns the core given a thread, or -1 if not known. */ virtual int core_of_thread (ptid_t ptid); diff --git a/gdbserver/thread-db.cc b/gdbserver/thread-db.cc index 2370c139afa..7f29788d7d7 100644 --- a/gdbserver/thread-db.cc +++ b/gdbserver/thread-db.cc @@ -833,7 +833,7 @@ thread_db_mourn (struct process_info *proc) For any other command, return 0. */ int -thread_db_handle_monitor_command (char *mon) +thread_db_handle_monitor_command (const char *mon) { const char *cmd = "set libthread-db-search-path"; size_t cmd_len = strlen (cmd); -- 2.49.0