From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CQYAEPt0cWn07w4AWB0awg (envelope-from ) for ; Wed, 21 Jan 2026 19:53:15 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xUVmT/Ga; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E5051E089; Wed, 21 Jan 2026 19:53:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A517D1E089 for ; Wed, 21 Jan 2026 19:53:14 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9EAB94BC8974 for ; Thu, 22 Jan 2026 00:53:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9EAB94BC8974 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=xUVmT/Ga Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 076BC4BA2E3F for ; Thu, 22 Jan 2026 00:51:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 076BC4BA2E3F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 076BC4BA2E3F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769043086; cv=none; b=mPvBlkriF75crH3xG3vxtfYteI9a1yxpMB9v36s9zoYXXuo3hskFroZMv+RtREfswFF75Pic3G0rwNpH1ZS9C05Jq6A+/AbB3tbyxnMJBMHBDSwmQ1KZ6R5V9cBHXlFGo3aZWL6kw1dV8TIk58+a/B0QAJxCusVRCU1echAh92k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769043086; c=relaxed/simple; bh=/jmXR1FmulG/xJQ2mKF4BIZr52n2kYx+wdWmwEbc+1I=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=nOKbBISav/Ogup7YAEUXlWJfRdmvBe1TcGHcO+PFD30XSdDiVjKojuX/n+/MB+rVrxY3OhPqLS9mq07qyV667uiL+WzDS8WoRqp7Dp11tW6LPVkUMnq3mSHIltf8/1RUyUzK7SfPZ/i8+2lxqDD5dZdws1aIdAeUZKLYD9HXgmI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 076BC4BA2E3F Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id ifOFvKJDMKXDJiiuovep20; Thu, 22 Jan 2026 00:51:14 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iiunvCLXFN3K1iiunvWNDc; Thu, 22 Jan 2026 00:51:14 +0000 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=69717482 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=CpFAy374b5RUs8Uw7bEA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z2WtKZ9cSCnm7k3Wc6IzYWENVgg043LGU8EWrVmVXgg=; b=xUVmT/GaIUUITgw2bq5kgj7N/p 8hBO++Ei+lRl8ehWEnR8JULVXkuKmY4EdCOj8Qmp+orWQd8Q9EOsAHTJcPW8XI0ZtN3kGl+LxtsXp bv9Pa3+sabMi4V62dSLd9sgpg; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:41752 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1viiun-00000003Jvq-11TB; Wed, 21 Jan 2026 17:51:13 -0700 From: Tom Tromey Date: Wed, 21 Jan 2026 17:51:12 -0700 Subject: [PATCH 2/2] Remove lookup_transparent_type lang hook MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260121-cp-remove-junk-v1-2-0999e81d866d@tromey.com> References: <20260121-cp-remove-junk-v1-0-0999e81d866d@tromey.com> In-Reply-To: <20260121-cp-remove-junk-v1-0-0999e81d866d@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1viiun-00000003Jvq-11TB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net ([192.168.122.1]) [97.122.114.32]:41752 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfIYVH9/HXWqcolXzBtutGlF1qkU8cULpE6t5l0dOT8iWokb4g5XjwIQO+EW7HA7dt/XoXxvbh8UwsPzVZfSFsl97hED7C1lna1OPz+QMkRLzlwXjJ8i+ ttDr+FDBmjYI//JC0OV4WZSY6UnsEQOlmDijyJPpacFmDEyKJUZgcsk9HcSlbPRVsrJwKQNAcaGP2uRr8VRUyU0Brtrm56NJno4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org C++ was the only user of the lookup_transparent_type lang hook, so it can be removed entirely. basic_lookup_transparent_type and its helper function are renamed as appropriate. --- gdb/language.h | 8 -------- gdb/symtab.c | 34 +++++++++++----------------------- gdb/symtab.h | 3 --- 3 files changed, 11 insertions(+), 34 deletions(-) diff --git a/gdb/language.h b/gdb/language.h index 50a4c026784..1a6420af74e 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -346,14 +346,6 @@ struct language_defn virtual void language_arch_info (struct gdbarch *, struct language_arch_info *) const = 0; - /* Find the definition of the type with the given name. */ - - virtual struct type *lookup_transparent_type (const char *name, - domain_search_flags flags) const - { - return basic_lookup_transparent_type (name, flags); - } - /* Find all symbols in the current program space matching NAME in DOMAIN, according to this language's rules. diff --git a/gdb/symtab.c b/gdb/symtab.c index 63505a94d41..35e380980b5 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -2622,22 +2622,14 @@ symbol::matches (domain_search_flags flags) const return search_flags_matches (flags, m_domain); } -/* See symtab.h. */ - -struct type * -lookup_transparent_type (const char *name, domain_search_flags flags) -{ - return current_language->lookup_transparent_type (name, flags); -} - -/* A helper for basic_lookup_transparent_type that interfaces with the +/* A helper for lookup_transparent_type that interfaces with the "quick" symbol table functions. */ static struct type * -basic_lookup_transparent_type_quick (struct objfile *objfile, - enum block_enum block_index, - domain_search_flags flags, - const lookup_name_info &name) +lookup_transparent_type_quick (struct objfile *objfile, + enum block_enum block_index, + domain_search_flags flags, + const lookup_name_info &name) { struct compunit_symtab *cust; const struct blockvector *bv; @@ -2658,14 +2650,10 @@ basic_lookup_transparent_type_quick (struct objfile *objfile, return sym->type (); } -/* The standard implementation of lookup_transparent_type. This code - was modeled on lookup_symbol -- the parts not relevant to looking - up types were just left out. In particular it's assumed here that - types are available in STRUCT_DOMAIN and only in file-static or - global blocks. */ +/* See symtab.h. */ struct type * -basic_lookup_transparent_type (const char *name, domain_search_flags flags) +lookup_transparent_type (const char *name, domain_search_flags flags) { struct type *t; @@ -2674,8 +2662,8 @@ basic_lookup_transparent_type (const char *name, domain_search_flags flags) /* Search all the global symbols. */ for (objfile &objfile : current_program_space->objfiles ()) { - t = basic_lookup_transparent_type_quick (&objfile, GLOBAL_BLOCK, - flags, lookup_name); + t = lookup_transparent_type_quick (&objfile, GLOBAL_BLOCK, + flags, lookup_name); if (t) return t; } @@ -2684,8 +2672,8 @@ basic_lookup_transparent_type (const char *name, domain_search_flags flags) but more useful than an error. */ for (objfile &objfile : current_program_space->objfiles ()) { - t = basic_lookup_transparent_type_quick (&objfile, STATIC_BLOCK, - flags, lookup_name); + t = lookup_transparent_type_quick (&objfile, STATIC_BLOCK, + flags, lookup_name); if (t) return t; } diff --git a/gdb/symtab.h b/gdb/symtab.h index bd305e5259c..6a1320aabad 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -2320,9 +2320,6 @@ extern void reread_symbols (int from_tty); extern struct type *lookup_transparent_type (const char *name, domain_search_flags flags = SEARCH_STRUCT_DOMAIN); -extern struct type *basic_lookup_transparent_type - (const char *name, domain_search_flags flags = SEARCH_STRUCT_DOMAIN); - /* Macro for name of symbol to indicate a file compiled with gcc. */ #ifndef GCC_COMPILED_FLAG_SYMBOL #define GCC_COMPILED_FLAG_SYMBOL "gcc_compiled." -- 2.49.0