From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ga6aEkmSa2lAwwcAWB0awg (envelope-from ) for ; Sat, 17 Jan 2026 08:44:41 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=mzj0u9gK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 481D81E0DD; Sat, 17 Jan 2026 08:44:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DF6E11E070 for ; Sat, 17 Jan 2026 08:44:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 451C34BA23F5 for ; Sat, 17 Jan 2026 13:44:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 451C34BA23F5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=mzj0u9gK Received: from sonic301-21.consmr.mail.ir2.yahoo.com (sonic301-21.consmr.mail.ir2.yahoo.com [77.238.176.98]) by sourceware.org (Postfix) with ESMTPS id 5B8774BA2E2E for ; Sat, 17 Jan 2026 13:41:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B8774BA2E2E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B8774BA2E2E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.176.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768657283; cv=none; b=kKGeL+tMSslOnhoq0BDXVbiYMq/IlMOil2jwkQdfiA13iYB3PpEM5PkGWD2ZbB2nnBlldQ80FX3cmoB4uj06kvsRMDfSVKzMxp1247EUnpJeiq0CeUJ7DPSlnglKJqyowC9+adi+FwEnB8kTXi110lY8jrjbNcHQ0lRsEl5E8Eo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768657283; c=relaxed/simple; bh=IaMksSC3XLZexx61+KyQPTUL6MaZvKMBG8woYGtQv+8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=W2h8euQ5iz/DSl9hc7S5TBEbzrjtmcn75ZCU9QXQHGBdYsFzwekBSNSc0GT7ObR7o19fA/Wg4U4rObT05KaQELWRHBahtQey8J8Cm+FWKMZ/yL0hAKlMOa3fRafKHoXENGiHD2gb/YkoZGYdpXxiKUktPztSG/WDEPPNum/dIpw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B8774BA2E2E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1768657282; bh=FhfcdHy1e0vmzWC5Pgxr5AkiWYYWWfJqnPpBOu/Ee50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=mzj0u9gK3QyYYYCSF90DB3JnKSzGsnHDdhA4gVJe3Oyfph5SAQh8RXk/XFXMXx7kQcoe2dmQB9cET5Kp+JD/+YQ3CK8MzRA14gGrbssV6UNSiSMTwMwh//QPZhnhveNDnI1Ldg01PmatiwI3ahUsYBJY4I1dxjjjHbDFo3Hk2RXTY/Y5YjwxP5BfkgRIUypqn5sufjNJvwwNn3/heun7PBDcGOAS7bWvSp/tQEmrGSYX9DUYpDPKFssEBv+HtJFz/pUUnOs7wXG+MQHG72jqxBKDRW9TFe1BI0ftRiww+gqekGpcTG3gI/Bl/5lGGsC8sE9/OeiddsFgPfteYNugKA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1768657282; bh=lkBBhUlX3n4A3oM1h9hNPzVJofQlPukrR91lkg3JC4o=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eYFIvA9+OoIdyQYaxJ4IgEoRzDGdrWWZ2D85dJwpImqZeB/lqtnUensAaPHBLmJzVFD+Eyn92DYeTO1oFmVUuSeC2VcNE9yHvRxQ8SIcqfYC9RWxOAv2xVPPhxpSO8bLyzZm23/8LJgxC9RLPAWC2UAAGsRc1AuBNVpJojHTG6wzpHQ0tkCpunSwv3RulmV+QJXfTQ3OYfrS0zx7Wzhni9DKhXmwussQlou2uzdc7PV9oY1n8NDvj5OW4NP2Ril01TjqJQKcWROXaUQaSMVNyo+GLpqQWy893InnoB6JdwkeQEddDhdZrWy46V7g3eY4oRROnWbJBb4p43TGDNXBVQ== X-YMail-OSG: jyuWS8IVM1kWnCxrntqMSK30p7BxnXZu6CbZbbgeRSJ3yYAf.1GzXFim1CQ.Nl_ WApzEvlCn8zs3jZMW01M6010UILcMQP0wcd_mep43jKLUPZk8monCOi9z0s5Jxg6QzbTYDAdhgzG muKxKIedDGs7E4Oi7yeluVKBWehCDa540KEs2ufl9epjLz4Fyc0BQniDLPr63QE7tOI4PYK.KKwD 6VkFZZTOzAeX3j8VzjSJfBgncJczJqMpCu.5FjuBQlGo321tD1TQvN.r6VHT5V3LvCZtnCnDO.Jf o88HKM2ORSoYMjAaXRdYACCjQBHeIrK4MtbVSz.4EW1HnxQEzMHDtT7JcxMSg.ZaOyEROxgG2q7e hrJKQl4ziIkxG5dRXf9z7eFzho61slEAbDUw8IWNmlYab4.5kuWYQEre47cUhI3tDZg6.ORcAkef MakNvkIE.lhORDs6L6NvllBt2DYeFBy2qBIuwnO8bQCs1P7XZQpsXoejWUCY.OiKAFfEyvHP2b73 rwPhhQsIulda2cq6q5ddaPvgI_J32ZfnSNT1b34qoQpcP_frF85moERFkoJlNve2pKfZtPIswk6M 4UKhublvu0SbWrX.hg85bxXr3WvlfJjLcqYrddYqSoVqXjoJvDhSXYL1hAU_SylE1Bku24xqhFJh JpqdeecNTDmwCJm0phbnBGjlBc0iMBIeWtoxfcKNiZl4FifAsXVWzG8ZB7bUI2EbLjx8P74u9xJw takkd5krWztlZARMf0vRAVjpxH0BxJAcENnF8Sh4Oci0lulXsRvqB1GaVfSs95TKZDzOgTH6YYxB jdY6tkCIBkyCfUVH.Nh41txkLMTQmAPKa3U6sE2qcdelD2srXmJjyuzjF0EpBayViIFON8Asxo0g HQ_fjmAUozmnYCkCnDoIA693f05RZoMtf61GrPnBpRiadc_j89nNUdrBQfqLdjQLqAAfTQckU2JE eyIsxZ5DPTQgVEX9slQycAGq6ekr4LTyhS3fouCOElXgeb.i5EsWSu2vPmME18.3JX1ppmgY.pVi pqblCDaFfkecv_e9tbU1Hc7nT._KjQykgxsc9VnqfJOTv3mQb1NBKSnZSJwmls3OrgPE.8RSlqXE sLLLfHCcRUWQ0mKOr_bZwn6Xu3BIawunND4N14zXpyef0_wwOjij5GUcMaRX5PAi.P2w557IEx89 Jo3WI7l8vflB2T6TCFHc9ESt6OfQ6gU_G2e4GbgqSR11L5_yQc5vYfg_U1X84COaAc3AZEvGjkoE U2XnaqSQp0hogDx6e9LxzlU2Plwl10A2WbbLYywyR5O5dqh2IaSUheCz9xok10_moNnWHcG8DlGq X8BeBZO7j3JPlqiqRswQEvPcRC7mJZ6ZvW3B8tVsLxrlt1nDZYDvv6KSuCOHKddgnYyIxd3D2oA3 uf5U8oa6FvePLYPoLNDkAjIVs0GlfMjw6m1koIIz4nQAKWsjOKhfBalqkNqAYLMjsXmeXG5PLHcO gRadUWPVp6JbykjRw9XWh7ePz8.dzu_e1rjsfS3U6aRZOGI0I1HJdNFC1NVThgZPxlAZst9.xkpn IrScHc2iFxySwtlieYpVmFvi4z6TRnJ3wKiVEeF39_DkSGhBFTLFZHEWbAyQjT.LddZ85scVGM_z xygtcP.70R_5m0LX1tubn5akZjTnAfIcQhc5DmWruSmN1nmmnaU470kJ3fTLrpw7GRWgRonrpn4E J6ZW.MEHnwJs9Y3SSS9CUJR9AqLFy2w1wnRFMF31_k_DtIgOUffunNTbaTIPtaszVTCIDqdLZwQo CtSVQMXDYVKbuK2.UWZD.4J_7ut_b9Nl3_w1bU3apoHrZ2MBUActFQbocqgeX_efQVJYRVJccuwG aO6HKO7ug8De89bRDanWdK0UyovSPD4WVqOR3EFol9F2NvAomyQOsB4cYnO4aXqY6Oc.4EWrW4Ki WmbwoxsnizqNbpIxwZUOUjVZk1UyScy4L.n.ExqP1Gac7tU0F.UqpCCgiwWz.rGtT3mAYPi8UV8l 0.jk74oQzNulbEr5mriR.6tEKKxug_0UP_UWgKvYSTU47JER2.22ChzxKFI0FSl84i2gf03iZtRn pRoUYkbEt550vfUv83WK8EayPndOhdEEccC.NNDCa8om5LKwgOOr7yBjbzBK65BJJVhbnL_WdM2C Y8.OqeGtDlGKBgZHdTr6MkV5mnjmR7FNMY5gdUvSAM2qbO8DVdCj0qEZxrCXLz1i8jhOF1zmV6Gc iOsMpwHxudQt.xqZiy5W7ArN6VmA9IN_59mn2U4MoVlj1hYo- X-Sonic-MF: X-Sonic-ID: 1d32ab78-86d8-4fd7-b909-0d38ca004b04 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Sat, 17 Jan 2026 13:41:22 +0000 Received: by hermes--production-ir2-6fcf857f6f-fskn5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8b536636b504c3e6f51c508e4731c748; Sat, 17 Jan 2026 13:41:17 +0000 (UTC) From: Hannes Domani To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 02/11] Simplify windows_nat_target::resume Date: Sat, 17 Jan 2026 14:36:13 +0100 Message-ID: <20260117134052.2660009-2-ssbssa@yahoo.de> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260117134052.2660009-1-ssbssa@yahoo.de> References: <20260117134052.2660009-1-ssbssa@yahoo.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Now the thread context is only needed for setting the trace bit, so move the rest out of the with_context lambda. Approved-By: Tom Tromey --- No changes in v2 --- gdb/windows-nat.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index a6fd199530c..8ee52768cb1 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1366,18 +1366,15 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig) /* Get context for currently selected thread. */ th = windows_process.thread_rec (inferior_ptid, DONT_INVALIDATE_CONTEXT); - if (th) + if (th && step) { + /* Single step by setting t bit. */ + regcache *regcache = get_thread_regcache (inferior_thread ()); + struct gdbarch *gdbarch = regcache->arch (); + fetch_registers (regcache, gdbarch_ps_regnum (gdbarch)); windows_process.with_context (th, [&] (auto *context) { - if (step) - { - /* Single step by setting t bit. */ - regcache *regcache = get_thread_regcache (inferior_thread ()); - struct gdbarch *gdbarch = regcache->arch (); - fetch_registers (regcache, gdbarch_ps_regnum (gdbarch)); - context->EFlags |= FLAG_TRACE_BIT; - } + context->EFlags |= FLAG_TRACE_BIT; }); } -- 2.52.0