From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SZ4xAbYoa2nKTQcAWB0awg (envelope-from ) for ; Sat, 17 Jan 2026 01:14:14 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=jg9Ny52k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 01B4F1E08D; Sat, 17 Jan 2026 01:14:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5C4F31E08D for ; Sat, 17 Jan 2026 01:14:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D22C94BA2E2A for ; Sat, 17 Jan 2026 06:14:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D22C94BA2E2A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=jg9Ny52k Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8D7314BA2E2A for ; Sat, 17 Jan 2026 06:13:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D7314BA2E2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D7314BA2E2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768630386; cv=none; b=g/us8DvwLpxi72DsNiWpw+x7tZ/BjFuAoDR7aC4g/Ls8VidGlZNYEx1R7iRrZc8DVM9SCGQqj6VnJ+r829eY7wGFdef4COykivSBWGidbobMpNgPaMGRib9K3HSIjcEX79rSolRNhowodNPM/gPt4TnL/KZoRyZUsNHeynGzgWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768630386; c=relaxed/simple; bh=S+rFvisxBBMPSHxtTJvKcSw50Ll5NCZ8Uc9Ps7sGWic=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FgGS+03vsxfhuQV1RsH/IeZ851v5gI/V17KcHKQuiJ0GHPvwzqs/WSfZfqAkFFajzMZRV6Q9p/OBjDHoUqdkT30zWDYGNrbAscqojiZY7doKDapIm2W0PwawP6mlvOgNiZ5gVWV+Cq2kJjaq7FrXALh5ZJ/Pz5BVwk0SKP7j3FI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D7314BA2E2A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 60H6D0k9097928 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Jan 2026 01:13:04 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 60H6D0k9097928 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1768630385; bh=vWpnsC7wqPYeAHZpWhPWBoC7v8Wgilqp8yLf5DoTxYM=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=jg9Ny52klSJgaCHzrbdhgaaguEL+WnnJI3T1HOOsASy0eqoo9XQXPUkd+IEp93ARY /NdgpO1v83XNHd3hq8Z4XhpFW6y078ZT7rxcTnmK5VGMrKo17RjKb33cxIL8mGE2rB nJf8VzFNiVXVyZySPElpcahFRzEYVPVtH6GrKHc8x3l9clVAsozr3qrXTex9FoK22c rEtJu+3AwyB/5oPsRlPUBk2chJ3KA8UqGhXzSHXR/UwJyTlzV+CfcC4nnSbKjjXiQ5 0zOWE36bKrtOjmPNFKsZPZZL3wBeMHNnlBDeOxuBm9fZJDW4APrdUTsCguXl/J4Slr g7laSz7PWEcqA== Received: by simark.ca (Postfix) id DD75C1E0EC; Sat, 17 Jan 2026 01:03:36 -0500 (EST) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 4/5] gdb/dwarf: rename some abbrev-related things in debug_names writer Date: Sat, 17 Jan 2026 01:02:34 -0500 Message-ID: <20260117060335.691691-5-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260117060335.691691-1-simon.marchi@polymtl.ca> References: <20260117060335.691691-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 17 Jan 2026 06:13:00 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi I think it would be clearer for some of these things to be called "abbrev", rather than "idx". Change-Id: Ic128a77dc7ce14a6179c049a2de21f3f9636405d --- gdb/dwarf2/index-write.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index 39910cd3f71c..c4bd424d4340 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -720,17 +720,17 @@ class debug_names if (parent != nullptr && (parent->flags & IS_SYNTHESIZED) != 0) parent = nullptr; - int &idx = m_indexkey_to_idx[index_key (entry->tag, - kind, - entry->flags, - entry->lang, - parent != nullptr)]; - if (idx == 0) + int &abbrev = m_indexkey_to_abbrev[index_key (entry->tag, + kind, + entry->flags, + entry->lang, + parent != nullptr)]; + if (abbrev == 0) { - idx = next_abbrev++; + abbrev = next_abbrev++; /* Abbrev number and tag. */ - m_abbrev_table.append_unsigned_leb128 (idx); + m_abbrev_table.append_unsigned_leb128 (abbrev); m_abbrev_table.append_unsigned_leb128 (entry->tag); /* Unit index. */ @@ -790,7 +790,7 @@ class debug_names gdb_assert (offset_inserted); /* Write the entry to the pool, starting with the abbrev number. */ - m_entry_pool.append_unsigned_leb128 (idx); + m_entry_pool.append_unsigned_leb128 (abbrev); /* Unit index. */ const auto it = m_cu_index_htab.find (entry->per_cu); @@ -1107,8 +1107,8 @@ class debug_names debug_str_lookup m_debugstrlookup; /* Map each used .debug_names abbreviation tag parameter to its - index value. */ - gdb::unordered_map m_indexkey_to_idx; + abbrev value. */ + gdb::unordered_map m_indexkey_to_abbrev; /* .debug_names abbreviation table. */ data_buf m_abbrev_table; -- 2.52.0