From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qYn4G1gma2m+SgcAWB0awg (envelope-from ) for ; Sat, 17 Jan 2026 01:04:08 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=oMz2eQWk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6F5F51E0DD; Sat, 17 Jan 2026 01:04:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B8D5A1E08D for ; Sat, 17 Jan 2026 01:04:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 40E334BA23E0 for ; Sat, 17 Jan 2026 06:04:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40E334BA23E0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=oMz2eQWk Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 45B374BA2E2D for ; Sat, 17 Jan 2026 06:03:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45B374BA2E2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45B374BA2E2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768629823; cv=none; b=MkB9B7o6vAImEIK28Jbv6exK2mG+iRfTRe0Mf9ledcisfZpRKSg7Tr2Rf7tldogyuQp7bdVyKTAWKNpFWtSDjhNn5vD91psEMXj+78HSTmUwqivh7LpTeY3mNlwCrvlw604RuvRJMX6FcRbgJbanz60Q/D91+P6CiOZUf68KqUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768629823; c=relaxed/simple; bh=XjnFRs3XFbnVR1h3TloJR/+bCRngs/U6XhRPjEiZKko=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=idyKv9Bsx/3YEh6/yhuW5yLjs62xRu0HvEf3q123FGorWjaFnqXeKA0B1nVDznbvLsDshCDnNMRLZHrNPcb4rmykB5fa4NowXH7MVuCqmiXutaPvpn1v2hSYNI/D2KYGlQ1l5m0Xwi5IrJyO8Su7o1/5mxCW0bOxcYDTRQo2euQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45B374BA2E2D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 60H63aib096118 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Jan 2026 01:03:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 60H63aib096118 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1768629821; bh=QEaE4iI6VQnEffEkCOkzt43X1DO5XRfqyq9xue6+Xwk=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=oMz2eQWkr1MOkkBeUYF/jb7QR2YC6sBGF4KTpyKVvPfG8j/159mOVq8Fa27tjZS3V Muu4wjXBffhs45s75+CEN4aIqanZJkvmdGgTgAHsL5DUZ45rdEbsepZYkAQYP8CNEJ qi/guTuTFo05NvHRFTjAfqu9QGv7eZyvHVABxhCShOBdQd+K6StKnZDaVpwbMojWCq ntyRUWiRxZxYmnPPtZFUTHcBXlL9MC3BwE/lJa27D7yPzwB5p7wKqcVBFXS1ayqt4D zolSC5NWhZsurQ/VQ+DbT6ki444xQxD1+smixGOeFOYCvFo7ysozZpdp7n+2meV400 maWRgvTXm1OoQ== Received: by simark.ca (Postfix) id C55471E0E7; Sat, 17 Jan 2026 01:03:36 -0500 (EST) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 3/5] gdb/dwarf: add comments to debug_names::build Date: Sat, 17 Jan 2026 01:02:33 -0500 Message-ID: <20260117060335.691691-4-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260117060335.691691-1-simon.marchi@polymtl.ca> References: <20260117060335.691691-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 17 Jan 2026 06:03:36 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi These help me follow what is going on, when following with the spec on the side. Change-Id: I0da0047eefd233e8f7635118d67622f07c29ce01 --- gdb/dwarf2/index-write.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index d31e7b631b86..39910cd3f71c 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -728,33 +728,49 @@ class debug_names if (idx == 0) { idx = next_abbrev++; + + /* Abbrev number and tag. */ m_abbrev_table.append_unsigned_leb128 (idx); m_abbrev_table.append_unsigned_leb128 (entry->tag); + + /* Unit index. */ m_abbrev_table.append_unsigned_leb128 (kind == unit_kind::cu ? DW_IDX_compile_unit : DW_IDX_type_unit); m_abbrev_table.append_unsigned_leb128 (DW_FORM_udata); + + /* DIE offset. */ m_abbrev_table.append_unsigned_leb128 (DW_IDX_die_offset); m_abbrev_table.append_unsigned_leb128 (DW_FORM_ref_addr); + + /* Language. */ m_abbrev_table.append_unsigned_leb128 (DW_IDX_GNU_language); m_abbrev_table.append_unsigned_leb128 (DW_FORM_udata); + + /* Internal linkage flag. */ if (!tag_is_type (entry->tag) && (entry->flags & IS_STATIC) != 0) { m_abbrev_table.append_unsigned_leb128 (DW_IDX_GNU_internal); m_abbrev_table.append_unsigned_leb128 (DW_FORM_flag_present); } + + /* Main subprogram flag. */ if ((entry->flags & IS_MAIN) != 0) { m_abbrev_table.append_unsigned_leb128 (DW_IDX_GNU_main); m_abbrev_table.append_unsigned_leb128 (DW_FORM_flag_present); } + + /* Linkage name flag. */ if ((entry->flags & IS_LINKAGE) != 0) { m_abbrev_table.append_unsigned_leb128 (DW_IDX_GNU_linkage_name); m_abbrev_table.append_unsigned_leb128 (DW_FORM_flag_present); } + + /* Parent offset. */ if (parent != nullptr) { m_abbrev_table.append_unsigned_leb128 (DW_IDX_parent); @@ -773,19 +789,23 @@ class debug_names .second); gdb_assert (offset_inserted); - /* Write the entry to the pool. */ + /* Write the entry to the pool, starting with the abbrev number. */ m_entry_pool.append_unsigned_leb128 (idx); + /* Unit index. */ const auto it = m_cu_index_htab.find (entry->per_cu); gdb_assert (it != m_cu_index_htab.cend ()); m_entry_pool.append_unsigned_leb128 (it->second); + /* DIE offset. */ m_entry_pool.append_uint (dwarf5_offset_size (), m_dwarf5_byte_order, to_underlying (entry->die_offset)); + /* Language. */ m_entry_pool.append_unsigned_leb128 (entry->per_cu->dw_lang ()); + /* Parent offset. */ if (parent != nullptr) { m_offsets_to_patch.emplace_back (m_entry_pool.size (), parent); -- 2.52.0