From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id maYiIXGRammzqgYAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 14:28:49 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=h1Y4uJCE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 83E861E0DD; Fri, 16 Jan 2026 14:28:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C75C71E08D for ; Fri, 16 Jan 2026 14:28:48 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E7D604BA2E35 for ; Fri, 16 Jan 2026 19:28:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E7D604BA2E35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=h1Y4uJCE Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id EF4344BA2E29 for ; Fri, 16 Jan 2026 19:11:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF4344BA2E29 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF4344BA2E29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590697; cv=none; b=sdNQ8c6gOnT4qQN05NphCu2/VO6+pNRMAj2fgWvm86bNJ/QR8GZ93xDoqq0vDkMQk9gvR+QX/kPyHU4FfeAld4qXZ8xmTV1wTI68j08ondxyIARuXNsQ27+H/3CYOzCWauMPKtAhR8HYN0AahIkj+bWnGsKmjIo7vADXxX1TBfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768590697; c=relaxed/simple; bh=Wy22AKDh13zYbotiKdRnm/FPjhIS+nXaYo3EhePjuc8=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=r8zOaYpbAUYjU5xARjeHUNFxwfbwY2BQjapfOBmccGeTfxMsIHSuxccQR8mjX4b63mbTi13tSK6LOJp9hmKwFYRy5EailwlbaCA05srigGcmE6u/pSPbHEy8ScGfp4YpcHulm5suIKH9xSSOqlmOgIW/sgq2N8o1FWULyDzcx2w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF4344BA2E29 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-7cfdf0c8908so833255a34.0 for ; Fri, 16 Jan 2026 11:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1768590691; x=1769195491; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s1ZgP0QZ9g+2Cpi1Mh3kp2E5ZoS8ZCE/jWgAtXMuI7c=; b=h1Y4uJCENoDCYZyidzYS9tdtOhlLxtbNtEWMkqtvC8y4Bvl5J2meXwT62jIIy/XLYq M7OwlpL6ZGMgSkk0bkzO4sCmmb10VdR62O5WLYFtcYJJTcWt+L2bJaiwfxS/0ur3hovC jrXCAkiKpCVA5NpKnPo5vIz+7dbdwwTImjKc85A8RqsNoo8r/clAcV2SWdebavtaTpqY AunD1947enTjf7Sr8gw9z54Mq/h0t6T+dCqalGZrqXqeUt8L1GqYvaL9ksfCjNAjPQVT uZuJTJNjrH3ubWvwgTWSIJIuPlEnXf+cqmpLPdB2JuI2UIDAJ/dc4IFq60bE5j0Pnf1I YuFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768590691; x=1769195491; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=s1ZgP0QZ9g+2Cpi1Mh3kp2E5ZoS8ZCE/jWgAtXMuI7c=; b=Zm+4pd9XUQ9OWGmWHwFFTF8O9pSY50+bG1WoHjdNYERTGzjQM/zmiax4p87hOlG9jJ UiV/5U0b0T/bFC07jpxJNO95dDoHMbqy8nnnqtWPb4bWWNUCxmrureoiSP+NrgnMQQnq 5Du3NbZdkK0ZTnTY9wfWsNkpoOgOi0jpnyaJU4kS2o3HKv+BTFXz+EDdnTJPO+kqImhv 0NRV7jnviaePNKBA334Qx/K3jFqiMp3LESglFEPbjfuMv+CgADXARGWgkcYrQkmHb9n4 +nOlsHo5D1Al4ZTa2nWdyMttSSVJ3QAG0APLenji8bB4DsB12nBysb7KLmooGBT3hzEh NK2w== X-Gm-Message-State: AOJu0Yz2c/qD4VU6otx7EXvO1j6k4PxNq4+ec8gH5VI+5WXbfr1DRybg LNLE5pPsY62DFIEW0/AsR/wDl029p3NANJWNc01/U8Jmh8pCYUVe5f1EyIzjFo4IOw== X-Gm-Gg: AY/fxX7QMXwzbeVeXt3KNqYqrpwFaJH8vkD69YnVBYFKt8VlmiODxph8rYzBF9lYDbR 2jYbxPY0oZiz5cF9yzSgYA5mbDZL82lEbtnzR9nNAPA6oinlEBsn/Y1MG8w5N7IDzbb9glKGExR hymqJ4EP3E64/64HVjnCSuSBLt6H6Z4Jw6JbaAGb+e84M3bvs78BuWZ8+My68pwOv+ohL1m7Jfi jWJy0IZYBmhj1tRPc/46G4xJo7Jq2CCgxSW9tF/LxIhhfu7d1xTqU6mt6qnxb2Y1pOjtgnyR+20 bjFuebkTRP6pdJrDfY54p7oNubi1V/J8DcI3WFgo0NVIUv24dMeMJwWtewXGXFRjqmvgOL9ghTv j4eDD1BXiudVZ7wyltItk1miw38EXZ5RBAtQ+wf0954mAJr+Gsqm/REbE08Xnd8RkjVTSwxa8uE qfXvRBIh/hyly2A6bFhV07VipoA7zv6ULD24g7iFaJsQ== X-Received: by 2002:a05:6830:370e:b0:7cf:da7d:539d with SMTP id 46e09a7af769-7cfdeec608fmr1981082a34.37.1768590691307; Fri, 16 Jan 2026 11:11:31 -0800 (PST) Received: from [192.168.0.26] (97-122-114-32.hlrn.qwest.net. [97.122.114.32]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf0db2c1sm2196681a34.5.2026.01.16.11.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:11:30 -0800 (PST) From: Tom Tromey Date: Fri, 16 Jan 2026 12:11:29 -0700 Subject: [PATCH 01/10] Constify coffread.c:getsymname MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260116-coffread-cleanups-v1-1-4d46090fad69@adacore.com> References: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> In-Reply-To: <20260116-coffread-cleanups-v1-0-4d46090fad69@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that the symbol name in coffread.c can be const. --- gdb/coffread.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index 18641aafd18..dc5550af4a2 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -71,7 +71,7 @@ static int pe_file; struct coff_symbol { - char *c_name; + const char *c_name; int c_naux; /* 0 if syment only, 1 if syment + auxent, etc. */ CORE_ADDR c_value; @@ -86,7 +86,7 @@ static long stringtab_length = 0; /* Used when reading coff symbols. */ static int symnum; -static char *getsymname (struct internal_syment *); +static const char *getsymname (struct internal_syment *); static int init_stringtab (bfd *, file_ptr, gdb::unique_xmalloc_ptr *); @@ -636,11 +636,11 @@ init_stringtab (bfd *abfd, file_ptr offset, gdb::unique_xmalloc_ptr *stora return 0; } -static char * +static const char * getsymname (struct internal_syment *symbol_entry) { static char buffer[SYMNMLEN + 1]; - char *result; + const char *result; if (symbol_entry->_n._n_n._n_zeroes == 0) { -- 2.52.0