From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qRuCDzElaWmxDgUAWB0awg (envelope-from ) for ; Thu, 15 Jan 2026 12:34:41 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=YFfiANMW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3D3AF1E070; Thu, 15 Jan 2026 12:34:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFD7D1E070 for ; Thu, 15 Jan 2026 12:34:40 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 65EE94BA2E1D for ; Thu, 15 Jan 2026 17:34:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 65EE94BA2E1D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=YFfiANMW Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 51F274BA2E1D for ; Thu, 15 Jan 2026 17:33:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51F274BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 51F274BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768498401; cv=none; b=STN/Zux8KKHN4sw9mIJc2sg9rzSNaUgJKcHx/AbWSy5qHftExJVXbEa0ISuL6mWU0kiVmCzh7iGfuKKMrfCx3SsnRmXHwU5DdHR3fO9SfVasqxidTHwwPsSCYeZt2vjH9JuJFS7knch3i2eDr613NnsXkqD9tzAENOyWw5oOB38= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768498401; c=relaxed/simple; bh=b+2lvUybG3l+/hnj84tp3eZXTDAjGUOpK6FAJotvp5E=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=O8oc3NjXr8LRO0uztNLtQSXeFcXsh8B7ZpfgMGxiQfPAPcwGvjJRWXjFl9q7pH79X3dXtLZAyaZrS75DOJEndmr09o00SCS4QxOARFKZ+wqnl7kjrU7I/tX3s+7/rsBlImJkkfFBdIQY4scBRO1mCqMu7gpVtFcX/rZC4skkeb8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51F274BA2E1D Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7cfd2423793so814588a34.2 for ; Thu, 15 Jan 2026 09:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1768498400; x=1769103200; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=9bVmS0WIhqdI2Uefp6lZnWn0jisubTGtIvIxK453pEk=; b=YFfiANMWeTBJDoNk7QRkx8wnE9L5U1Ps6HkqrmkdIl5DJjGuGGuQcZANLHCyXC2NUQ DNQ+42T+ljH74OqIrqmBxoHIzDnfEcH7nYuW5d3Y2AmQWlQAmXiH45HQryt39k3CR9MG rVveGHfWZYhzvC8XhxYNxftockEplZ6UFiekrm3Z5Q7tICcMFmwSNUAOQWG+nsD3K8AD H+mRFDzWtVkc9TPs7WA7Xfg4QHII7sALBazkoIoFPP8zEgiKP9rIYewBQCBfReWCNfPf 6hWeqR3quJwKB8xjI8c3PfIXtlGIdHLhjRWZ2plj/PBtkab+QisoSrkSDJHNJ1RSSL5V ZKBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768498400; x=1769103200; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9bVmS0WIhqdI2Uefp6lZnWn0jisubTGtIvIxK453pEk=; b=nZ4krV8PBLaiDDVVc118Sh3MKDkNZvQ/YkLGYnM1bzCoG/Pyziiz5jhSai2GqsxUuR dD58N2GuuRnDxvRQRolqRtDDduXjAwAtoqUS4Qy4/7NrYrvo8qsNkseUg5xXePn1Gbub iaQla/swkNUadU8+TztcwWqx0kjxP+wFd0/crzGOQMO3ZGCJ4SFbjM/RW9OcIdCXlIOe U3IE2AzKJW28FxKfKWKevMgjl+xe2zybbwGza+4scGexv/h3ebk36rXyEXCJjY2Lgi71 Fs71E+qFx/jng2eqJNo+AJHbd/iFJwgsUiwv+H3sszY6hC29PqM2sQslNmXfmN7Wb6eZ WiMA== X-Gm-Message-State: AOJu0Yz82f3Ydl1fE7Ex1rkWGgtrQyM8ootIwdoPKWkND0XZl1IMMbNf T/cKHNamAhcHnQ/yBoc0qFXni+ANRjPI/bLlOdRfoCMVNBnqFaGFVIGN3H9JJIxykJhvHaT4uDw U7Is= X-Gm-Gg: AY/fxX4+Pgy9W2Nl2WnAalSSTtLgZs4PBwRf2+oWiWdkR/LPCNwHEMfg+zr2QZqVtV9 WOWCCCluUnn3HjH0kgkeG7hafeq00uBl0NiNezPIplIVWCcWrHuGGAvVn7bguFAFlwOE7AGzGp7 hGoavWH51eTcDppfts2g/mOM6fHyCee0Xt9ppPkG8wweZDOozszdXdbC7hGo6J2Nl34dzcryANZ DmcGMr4y/alBny9K63wgty9mErfYqJg919Ytyu+0RsHsZAFNoHDSpgvBF3BOaE+NUsXIm8zp1BO +juarowDIZYdF+GCR+s11+ypuUjYYAnNaFGnWQeJxH4E9owS9yCemaVZKC9x8mnKrwJjGW3otqZ P8hbYKsfU9oq9ZLV5DqnsY+Weul9TXxBdvNcth5M5mBNRhEBgoUAmBkaMPlt1f5fxqf69wjY8z/ LR958pQoDpm4uR8LKHNhcvWZXT7XCpWdhF3TYLPynmZA== X-Received: by 2002:a05:6830:82ba:b0:7cf:d168:1f3e with SMTP id 46e09a7af769-7cfded4dea5mr167970a34.3.1768498400613; Thu, 15 Jan 2026 09:33:20 -0800 (PST) Received: from [192.168.0.26] (97-122-114-32.hlrn.qwest.net. [97.122.114.32]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf0e92d3sm67743a34.9.2026.01.15.09.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 09:33:20 -0800 (PST) From: Tom Tromey Subject: [PATCH 0/2] More uses of make_unique_xstrdup Date: Thu, 15 Jan 2026 10:33:17 -0700 Message-Id: <20260115-xstrdup-v1-0-72e13ba99851@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAN0kaWkC/x3MwQqDMBCE4VeRPTeYtRiwr1J6SHSqezDKrhZBf PemPX7wz5xkUIHRozpJ8RGTJRfwraJ+inmEk6GYGt8Ez9y6wzYd9tV5j3TvUmBwoFKvircc/6f nqzhFg0sacz/99ovKKLmeo21Quq4vGGihBXkAAAA= X-Change-ID: 20260115-xstrdup-00eb39b61e16 To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This replaces some uses of '.reset(xstrdup())' with '= make_unique_xstrdup()'. I think explicit uses of reset should be avoided when possible. Regression tested on x86-64 Fedora 41. Signed-off-by: Tom Tromey --- Tom Tromey (2): Use make_unique_xstrdup in more places Use make_unique_xstrdup in tracepoint gdb/breakpoint.c | 4 ++-- gdb/buildsym.h | 8 +++++--- gdb/cli/cli-dump.c | 2 +- gdb/mi/mi-cmd-env.c | 2 +- gdb/python/py-framefilter.c | 2 +- gdb/python/py-function.c | 2 +- gdb/python/py-lazy-string.c | 5 ++++- gdb/python/py-param.c | 2 +- gdb/solib.c | 4 ++-- gdb/source.c | 4 ++-- gdb/stack.c | 16 +++++++++++----- gdb/tracectf.c | 4 ++-- gdb/tracepoint.c | 10 ++++------ gdb/tracepoint.h | 12 ++++++------ 14 files changed, 43 insertions(+), 34 deletions(-) --- base-commit: 44c39324673cd9bb18db67234253f288497d66a1 change-id: 20260115-xstrdup-00eb39b61e16 Best regards, -- Tom Tromey