Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Speed up gdb.base/tls-dlobj.exp
Date: Wed, 14 Jan 2026 11:26:13 -0700	[thread overview]
Message-ID: <20260114112613.39cb4e6c@f42-mesa-1> (raw)
In-Reply-To: <20260110095224.4041403-1-tdevries@suse.de>

On Sat, 10 Jan 2026 10:52:24 +0100
Tom de Vries <tdevries@suse.de> wrote:

> In test-case gdb.base/tls-dlobj.exp we use breakpoints to step through the
> executable.  The breakpoints are used only once, but they are permanent,
> so we end up with 11 breakpoints, 10 of which of the form $srcfile:$n.
> 
> The executable loads and unloads shared libraries, triggering solib
> events in gdb, which will re-set the breakpoints.
> 
> Setting a breakpoint of the form $srcfile:$n triggers a filename search
> that iterates over all CUs in all objfiles for which we have debuginfo.
> 
> In case glibc debuginfo is installed, and in case we have a slow gdb, for
> instance because of building with -O0 and Address Sanitizer, this might
> become noticeable.
> 
> While it's a good idea to try to speed up this search (see for instance
> PR33781), measuring this speed is not the point of this test-case, so fix
> this by making the breakpoints temporary.
> 
> Tested on x86_64-linux.

I like this better than the earlier approach.

Approved-by: Kevin Buettner <kevinb@redhat.com>


      reply	other threads:[~2026-01-14 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10  9:52 Tom de Vries
2026-01-14 18:26 ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114112613.39cb4e6c@f42-mesa-1 \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox