From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id likCGikHYGk5IjMAWB0awg (envelope-from ) for ; Thu, 08 Jan 2026 14:36:09 -0500 Received: by simark.ca (Postfix, from userid 112) id 2C7D61E0B3; Thu, 08 Jan 2026 14:36:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6392F1E0B3 for ; Thu, 08 Jan 2026 14:36:07 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id EAAD84BA2E1E for ; Thu, 8 Jan 2026 19:36:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAAD84BA2E1E Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 57A194BA2E1E for ; Thu, 8 Jan 2026 19:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57A194BA2E1E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57A194BA2E1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767900911; cv=none; b=buK04vHd3syKyDrqXlJ6e3+9Zu86yvbDQKy9OAcXC2/gW+KUdagiX6zFgIbPU+5vnIbPXqPtxbODWQSoqU+dilN8P1tSU4bAnUMkD7vGqX2DsNc898pD7M8aJvwl5//5Q/o/zpIsu+Uf3Opy4fZyK+VqTsxKwCOlhrzjjdnUBI8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767900911; c=relaxed/simple; bh=WXHSUscMWr/2cYN6av2ph2lTy9JyRixrJ20bRMPrazE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=of+M9ydUn9nyoxHvlI6oLkGWc1zAI8EW1qXwLG4+qJsP2ZkC2Q6tHlTnRhu9EHTDL/79mcalJ3p7U8+z48IEjdNCeIRhmL82kQdeY2iYK/AfI2hDPj0ZYa5kBk7hEO187qtMlan4sAm1BFBqI9E9JTV2yyY/be55sVFOJsbp6G4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57A194BA2E1E Received: by simark.ca (Postfix) id 745601E0C3; Thu, 08 Jan 2026 14:35:09 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 5/8] gdb/xcoffread: allocate symbol table using vector in scan_xcoff_symtab Date: Thu, 8 Jan 2026 14:33:23 -0500 Message-ID: <20260108193507.553779-6-simon.marchi@efficios.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260108193507.553779-1-simon.marchi@efficios.com> References: <20260108193507.553779-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The symbol table content is only needed for the duration of scan_xcoff_symtab, so it's not necessary to allocate it on the objfile obstack. Switch to using a vector that is freed at the end of the function. Change-Id: Ib5acdea460969300a92816a3e71b7d82c80faebf --- gdb/xcoffread.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 0f3470cae45d..7dd0f29cb107 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -166,14 +166,14 @@ scan_xcoff_symtab (struct objfile *objfile) unsigned int num_symbols = bfd_get_symcount (abfd); size_t size = coff_data (abfd)->local_symesz * num_symbols; - char *symtbl = (char *) obstack_alloc (&objfile->objfile_obstack, size); + gdb::char_vector symtbl (size); /* Read in symbol table. */ - if (int ret = bfd_read (symtbl, size, abfd); + if (int ret = bfd_read (symtbl.data (), size, abfd); ret != size) error (_("reading symbol table: %s"), bfd_errmsg (bfd_get_error ())); - char *sraw_symbol = symtbl; + char *sraw_symbol = symtbl.data (); ssymnum = 0; while (ssymnum < num_symbols) { -- 2.52.0