From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QW71EG16OGksTikAWB0awg (envelope-from ) for ; Tue, 09 Dec 2025 14:37:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 420891E0B3; Tue, 09 Dec 2025 14:37:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8FB001E08D for ; Tue, 09 Dec 2025 14:37:15 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 11AF34BA23C1 for ; Tue, 9 Dec 2025 19:37:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11AF34BA23C1 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BE1B14BA2E07 for ; Tue, 9 Dec 2025 19:36:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE1B14BA2E07 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE1B14BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765308977; cv=none; b=Icf6DCZKr+7hrOEmLZtZMEnBlrF5ZDx8MBOrNlKaPn/dNE/64hTrIyMN6u7QFvgY+K3ifZEhenslIYyg/aW4t9uCaY803R+Esfm+ov3hUXbETeIqSZVcI/6nYhTMvH4I7ydNHmegTzrUqg37B3M4DicaOpK3xdHftkvs26lx1No= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765308977; c=relaxed/simple; bh=vqtrADpalQSW+wDnRPmvX/FOs+klVnR78PB2kDNqkCk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=JtiyFgej4SZb+QGBOPtDkQc0I2lEC4ORBtmo0OE+sxp5b854ej23Pvq48B6Nk/b+oGs0Wrg8vOS13yli1uut9L4S5P6w1CjDmZoxy6XFNkJzrJU3+4mYAr3q+8iOI7j++OV0YLMO5WCqfWwJn4JTYDwE7mNfJba3shCNevM+mQY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE1B14BA2E07 Received: by simark.ca (Postfix) id 944C81E0C3; Tue, 09 Dec 2025 14:36:15 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 05/11] gdb: de-constify some methods of solib_ops Date: Tue, 9 Dec 2025 14:32:09 -0500 Message-ID: <20251209193610.296085-6-simon.marchi@efficios.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251209193610.296085-1-simon.marchi@efficios.com> References: <20251209193610.296085-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The following commit moves the ROCm solib data from a registry to the rocm_solib_ops object itself. This requires making some methods non-const, and it then cascades to a bunch of things. This will have to be done one day or another, when (I suspect) we'll move more solib_ops data out of registries and into the solib_ops objects themselves. Do it in this separate patch to avoid polluting that patch. No behavior change expected. Change-Id: Icb5e921a82e235817f8817a3aa3c20b2c9dc959f --- gdb/progspace.h | 2 +- gdb/solib-aix.c | 12 ++++++------ gdb/solib-darwin.c | 12 ++++++------ gdb/solib-dsbt.c | 8 ++++---- gdb/solib-frv.c | 8 ++++---- gdb/solib-rocm.c | 20 ++++++++++---------- gdb/solib-svr4.c | 14 +++++++------- gdb/solib-svr4.h | 14 +++++++------- gdb/solib-target.c | 2 +- gdb/solib-target.h | 2 +- gdb/solib.c | 8 ++++---- gdb/solib.h | 14 +++++++------- gdb/windows-tdep.c | 4 ++-- 13 files changed, 60 insertions(+), 60 deletions(-) diff --git a/gdb/progspace.h b/gdb/progspace.h index 498a5b460f12..bb4d6c79d16c 100644 --- a/gdb/progspace.h +++ b/gdb/progspace.h @@ -269,7 +269,7 @@ struct program_space { return std::move (m_solib_ops); } /* Get this program space's solib provider. */ - const struct solib_ops *solib_ops () const + struct solib_ops *solib_ops () const { return m_solib_ops.get (); } /* Return the list of all the solibs in this program space. */ diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c index 5076d7e2f063..a29e8639b3cd 100644 --- a/gdb/solib-aix.c +++ b/gdb/solib-aix.c @@ -31,9 +31,9 @@ struct aix_solib_ops : public solib_ops using solib_ops::solib_ops; void relocate_section_addresses (solib &so, target_section *) const override; - void create_inferior_hook (int from_tty) const override; - owning_intrusive_list current_sos () const override; - gdb_bfd_ref_ptr bfd_open (const char *pathname) const override; + void create_inferior_hook (int from_tty) override; + owning_intrusive_list current_sos () override; + gdb_bfd_ref_ptr bfd_open (const char *pathname) override; }; /* See solib-aix.h. */ @@ -430,7 +430,7 @@ solib_aix_get_section_offsets (struct objfile *objfile, } void -aix_solib_ops::create_inferior_hook (int from_tty) const +aix_solib_ops::create_inferior_hook (int from_tty) { const char *warning_msg = "unable to relocate main executable"; @@ -459,7 +459,7 @@ aix_solib_ops::create_inferior_hook (int from_tty) const } owning_intrusive_list -aix_solib_ops::current_sos () const +aix_solib_ops::current_sos () { std::optional> &library_list = solib_aix_get_library_list (current_inferior (), NULL); @@ -503,7 +503,7 @@ aix_solib_ops::current_sos () const } gdb_bfd_ref_ptr -aix_solib_ops::bfd_open (const char *pathname) const +aix_solib_ops::bfd_open (const char *pathname) { /* The pathname is actually a synthetic filename with the following form: "/path/to/sharedlib(member.o)" (double-quotes excluded). diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c index a6f550464f10..961b1099f45e 100644 --- a/gdb/solib-darwin.c +++ b/gdb/solib-darwin.c @@ -41,9 +41,9 @@ struct darwin_solib_ops : public solib_ops void relocate_section_addresses (solib &so, target_section *) const override; void clear_solib (program_space *pspace) const override; - void create_inferior_hook (int from_tty) const override; - owning_intrusive_list current_sos () const override; - gdb_bfd_ref_ptr bfd_open (const char *pathname) const override; + void create_inferior_hook (int from_tty) override; + owning_intrusive_list current_sos () override; + gdb_bfd_ref_ptr bfd_open (const char *pathname) override; }; /* See solib-darwin.h. */ @@ -214,7 +214,7 @@ find_program_interpreter (void) } owning_intrusive_list -darwin_solib_ops::current_sos () const +darwin_solib_ops::current_sos () { type *ptr_type = builtin_type (current_inferior ()->arch ())->builtin_data_ptr; @@ -474,7 +474,7 @@ darwin_solib_read_all_image_info_addr (struct darwin_info *info) } void -darwin_solib_ops::create_inferior_hook (int from_tty) const +darwin_solib_ops::create_inferior_hook (int from_tty) { /* Everything below only makes sense if we have a running inferior. */ if (!target_has_execution ()) @@ -609,7 +609,7 @@ darwin_solib_ops::relocate_section_addresses (solib &so, } gdb_bfd_ref_ptr -darwin_solib_ops::bfd_open (const char *pathname) const +darwin_solib_ops::bfd_open (const char *pathname) { int found_file; diff --git a/gdb/solib-dsbt.c b/gdb/solib-dsbt.c index 23042b4158e9..de18aef6ecdd 100644 --- a/gdb/solib-dsbt.c +++ b/gdb/solib-dsbt.c @@ -128,8 +128,8 @@ struct dsbt_solib_ops : public solib_ops void relocate_section_addresses (solib &so, target_section *) const override; void clear_solib (program_space *pspace) const override; - void create_inferior_hook (int from_tty) const override; - owning_intrusive_list current_sos () const override; + void create_inferior_hook (int from_tty) override; + owning_intrusive_list current_sos () override; bool in_dynsym_resolve_code (CORE_ADDR pc) const override; }; @@ -530,7 +530,7 @@ lm_base (void) we provide values for. */ owning_intrusive_list -dsbt_solib_ops::current_sos () const +dsbt_solib_ops::current_sos () { bfd_endian byte_order = gdbarch_byte_order (current_inferior ()->arch ()); CORE_ADDR lm_addr; @@ -864,7 +864,7 @@ dsbt_relocate_main_executable (void) The shared library breakpoints also need to be enabled. */ void -dsbt_solib_ops::create_inferior_hook (int from_tty) const +dsbt_solib_ops::create_inferior_hook (int from_tty) { /* Relocate main executable. */ dsbt_relocate_main_executable (); diff --git a/gdb/solib-frv.c b/gdb/solib-frv.c index 9d36b0fd4edf..39ed0e8b731a 100644 --- a/gdb/solib-frv.c +++ b/gdb/solib-frv.c @@ -36,8 +36,8 @@ struct frv_solib_ops : public solib_ops void relocate_section_addresses (solib &so, target_section *) const override; void clear_solib (program_space *pspace) const override; - void create_inferior_hook (int from_tty) const override; - owning_intrusive_list current_sos () const override; + void create_inferior_hook (int from_tty) override; + owning_intrusive_list current_sos () override; bool in_dynsym_resolve_code (CORE_ADDR pc) const override; }; @@ -323,7 +323,7 @@ lm_base (void) } owning_intrusive_list -frv_solib_ops::current_sos () const +frv_solib_ops::current_sos () { bfd_endian byte_order = gdbarch_byte_order (current_inferior ()->arch ()); CORE_ADDR lm_addr, mgot; @@ -796,7 +796,7 @@ frv_relocate_main_executable (void) enabled. */ void -frv_solib_ops::create_inferior_hook (int from_tty) const +frv_solib_ops::create_inferior_hook (int from_tty) { /* Relocate main executable. */ frv_relocate_main_executable (); diff --git a/gdb/solib-rocm.c b/gdb/solib-rocm.c index 5560a6035184..953d31d6c77b 100644 --- a/gdb/solib-rocm.c +++ b/gdb/solib-rocm.c @@ -212,11 +212,11 @@ struct rocm_solib_ops : public solib_ops { return std::move (m_host_ops); } /* The methods implemented by rocm_solib_ops. */ - owning_intrusive_list current_sos () const override; - void create_inferior_hook (int from_tty) const override; - gdb_bfd_ref_ptr bfd_open (const char *pathname) const override; + owning_intrusive_list current_sos () override; + void create_inferior_hook (int from_tty) override; + gdb_bfd_ref_ptr bfd_open (const char *pathname) override; void relocate_section_addresses (solib &so, target_section *) const override; - void handle_event () const override; + void handle_event () override; /* Implement the following methods just to forward the calls to the host solib_ops. We currently need to implement all the methods that @@ -267,7 +267,7 @@ struct rocm_solib_ops : public solib_ops private: owning_intrusive_list - solibs_from_rocm_sos (const std::vector &sos) const; + solibs_from_rocm_sos (const std::vector &sos); solib_ops_up m_host_ops; }; @@ -305,7 +305,7 @@ rocm_solib_ops::relocate_section_addresses (solib &so, static void rocm_update_solib_list (); void -rocm_solib_ops::handle_event () const +rocm_solib_ops::handle_event () { /* Since we sit on top of a host solib_ops, we might get called following an event concerning host libraries. We must therefore forward the call. If @@ -321,7 +321,7 @@ rocm_solib_ops::handle_event () const /* Create solib objects from rocm_so objects in SOS. */ owning_intrusive_list -rocm_solib_ops::solibs_from_rocm_sos (const std::vector &sos) const +rocm_solib_ops::solibs_from_rocm_sos (const std::vector &sos) { owning_intrusive_list dst; @@ -336,7 +336,7 @@ rocm_solib_ops::solibs_from_rocm_sos (const std::vector &sos) const objects currently loaded in the inferior. */ owning_intrusive_list -rocm_solib_ops::current_sos () const +rocm_solib_ops::current_sos () { /* First, retrieve the host-side shared library list. */ owning_intrusive_list sos = m_host_ops->current_sos (); @@ -677,7 +677,7 @@ rocm_bfd_iovec_open (bfd *abfd, inferior *inferior) } gdb_bfd_ref_ptr -rocm_solib_ops::bfd_open (const char *pathname) const +rocm_solib_ops::bfd_open (const char *pathname) { /* Handle regular files with SVR4 open. */ if (strstr (pathname, "://") == nullptr) @@ -765,7 +765,7 @@ rocm_solib_ops::bfd_open (const char *pathname) const } void -rocm_solib_ops::create_inferior_hook (int from_tty) const +rocm_solib_ops::create_inferior_hook (int from_tty) { get_solib_info (current_inferior ())->solib_list.clear (); diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index b21987544a78..7fd067ff38ab 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -1064,7 +1064,7 @@ svr4_solib_ops::clear_so (const solib &so) const /* Create the solib objects equivalent to the svr4_sos in SOS. */ owning_intrusive_list -svr4_solib_ops::solibs_from_svr4_sos (const std::vector &sos) const +svr4_solib_ops::solibs_from_svr4_sos (const std::vector &sos) { owning_intrusive_list dst; @@ -1258,7 +1258,7 @@ svr4_current_sos_via_xfer_libraries (struct svr4_library_list *list, linker, build a fallback list from other sources. */ owning_intrusive_list -svr4_solib_ops::default_sos (svr4_info *info) const +svr4_solib_ops::default_sos (svr4_info *info) { if (!info->debug_loader_offset_p) return {}; @@ -1457,7 +1457,7 @@ svr4_solib_ops::current_sos_direct (svr4_info *info) const /* Collect sos read and stored by the probes interface. */ owning_intrusive_list -svr4_solib_ops::collect_probes_sos (svr4_info *info) const +svr4_solib_ops::collect_probes_sos (svr4_info *info) { owning_intrusive_list res; @@ -1474,7 +1474,7 @@ svr4_solib_ops::collect_probes_sos (svr4_info *info) const method. */ owning_intrusive_list -svr4_solib_ops::current_sos_1 (svr4_info *info) const +svr4_solib_ops::current_sos_1 (svr4_info *info) { owning_intrusive_list sos; @@ -1501,7 +1501,7 @@ svr4_solib_ops::current_sos_1 (svr4_info *info) const /* Implement the "current_sos" solib_ops method. */ owning_intrusive_list -svr4_solib_ops::current_sos () const +svr4_solib_ops::current_sos () { svr4_info *info = get_svr4_info (current_program_space); @@ -2149,7 +2149,7 @@ svr4_solib_ops::disable_probes_interface (svr4_info *info) const standard interface. */ void -svr4_solib_ops::handle_event () const +svr4_solib_ops::handle_event () { struct svr4_info *info = get_svr4_info (current_program_space); struct probe_and_action *pa; @@ -3326,7 +3326,7 @@ svr4_relocate_main_executable (void) their symbols to be read at a later time. */ void -svr4_solib_ops::create_inferior_hook (int from_tty) const +svr4_solib_ops::create_inferior_hook (int from_tty) { struct svr4_info *info; diff --git a/gdb/solib-svr4.h b/gdb/solib-svr4.h index 7b38ff4483a5..28b27675f529 100644 --- a/gdb/solib-svr4.h +++ b/gdb/solib-svr4.h @@ -99,14 +99,14 @@ struct svr4_solib_ops : public solib_ops void relocate_section_addresses (solib &so, target_section *) const override; void clear_so (const solib &so) const override; void clear_solib (program_space *pspace) const override; - void create_inferior_hook (int from_tty) const override; - owning_intrusive_list current_sos () const override; + void create_inferior_hook (int from_tty) override; + owning_intrusive_list current_sos () override; bool open_symbol_file_object (int from_tty) const override; bool in_dynsym_resolve_code (CORE_ADDR pc) const override; bool same (const solib &gdb, const solib &inferior) const override; bool keep_data_in_core (CORE_ADDR vaddr, unsigned long size) const override; void update_breakpoints () const override; - void handle_event () const override; + void handle_event () override; std::optional find_solib_addr (solib &so) const override; bool supports_namespaces () const override { return true; } int find_solib_ns (const solib &so) const override; @@ -135,7 +135,7 @@ struct svr4_solib_ops : public solib_ops void free_probes_table (svr4_info *info) const; CORE_ADDR find_r_brk (svr4_info *info) const; CORE_ADDR find_r_ldsomap (svr4_info *info) const; - owning_intrusive_list default_sos (svr4_info *info) const; + owning_intrusive_list default_sos (svr4_info *info); int read_so_list (svr4_info *info, CORE_ADDR lm, CORE_ADDR prev_lm, CORE_ADDR debug_base, std::vector &sos, int ignore_first) const; @@ -144,10 +144,10 @@ struct svr4_solib_ops : public solib_ops CORE_ADDR lm_addr_check (const solib &so, bfd *abfd) const; CORE_ADDR read_r_next (CORE_ADDR debug_base) const; CORE_ADDR read_r_map (CORE_ADDR debug_base) const; - owning_intrusive_list collect_probes_sos (svr4_info *info) const; - owning_intrusive_list current_sos_1 (svr4_info *info) const; + owning_intrusive_list collect_probes_sos (svr4_info *info); + owning_intrusive_list current_sos_1 (svr4_info *info); owning_intrusive_list solibs_from_svr4_sos - (const std::vector &sos) const; + (const std::vector &sos); void disable_probes_interface (svr4_info *info) const; void update_full (svr4_info *info) const; int update_incremental (svr4_info *info, CORE_ADDR debug_base, diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 36654a76fc3e..9707596725d4 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -232,7 +232,7 @@ solib_target_parse_libraries (const char *library) #endif owning_intrusive_list -target_solib_ops::current_sos () const +target_solib_ops::current_sos () { owning_intrusive_list sos; diff --git a/gdb/solib-target.h b/gdb/solib-target.h index 4b8f2d6ad5cb..e3c1d87684f6 100644 --- a/gdb/solib-target.h +++ b/gdb/solib-target.h @@ -29,7 +29,7 @@ struct target_solib_ops : solib_ops using solib_ops::solib_ops; void relocate_section_addresses (solib &so, target_section *) const override; - owning_intrusive_list current_sos () const override; + owning_intrusive_list current_sos () override; bool in_dynsym_resolve_code (CORE_ADDR pc) const override; }; diff --git a/gdb/solib.c b/gdb/solib.c index ac674f4e9720..cc587aa8158b 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -467,7 +467,7 @@ solib_bfd_open (const char *pathname) } gdb_bfd_ref_ptr -solib_ops::bfd_open (const char *pathname) const +solib_ops::bfd_open (const char *pathname) { return solib_bfd_open (pathname); } @@ -718,7 +718,7 @@ notify_solib_unloaded (program_space *pspace, const solib &so, void update_solib_list (int from_tty) { - const solib_ops *ops = current_program_space->solib_ops (); + solib_ops *ops = current_program_space->solib_ops (); if (ops == nullptr) return; @@ -1318,7 +1318,7 @@ clear_solib (program_space *pspace) void solib_create_inferior_hook (int from_tty) { - if (const solib_ops *ops = current_program_space->solib_ops (); + if (solib_ops *ops = current_program_space->solib_ops (); ops != nullptr) ops->create_inferior_hook (from_tty); } @@ -1383,7 +1383,7 @@ update_solib_breakpoints (void) void handle_solib_event (void) { - if (const solib_ops *ops = current_program_space->solib_ops (); + if (solib_ops *ops = current_program_space->solib_ops (); ops != nullptr) ops->handle_event (); diff --git a/gdb/solib.h b/gdb/solib.h index 92a485dbca4c..512fdf7bce96 100644 --- a/gdb/solib.h +++ b/gdb/solib.h @@ -62,7 +62,7 @@ struct solib : intrusive_list_node OPS is the solib_ops implementation providing this solib. */ explicit solib (lm_info_up lm_info, std::string original_name, - std::string name, const solib_ops &ops) + std::string name, solib_ops &ops) : lm_info (std::move (lm_info)), original_name (std::move (original_name)), name (std::move (name)), @@ -70,7 +70,7 @@ struct solib : intrusive_list_node {} /* Return the solib_ops implementation providing this solib. */ - const solib_ops &ops () const + solib_ops &ops () const { return *m_ops; } /* Free symbol-file related contents of SO and reset for possible reloading @@ -131,7 +131,7 @@ struct solib : intrusive_list_node private: /* The solib_ops responsible for this solib. */ - const solib_ops *m_ops; + solib_ops *m_ops; }; /* A unique pointer to an solib. */ @@ -173,7 +173,7 @@ struct solib_ops /* Target dependent code to run after child process fork. Defaults to no-op. */ - virtual void create_inferior_hook (int from_tty) const {}; + virtual void create_inferior_hook (int from_tty) {}; /* Construct a list of the currently loaded shared objects. This list does not include an entry for the main executable file. @@ -182,7 +182,7 @@ struct solib_ops inferior --- we don't examine any of the shared library files themselves. The declaration of `struct solib' says which fields we provide values for. */ - virtual owning_intrusive_list current_sos () const = 0; + virtual owning_intrusive_list current_sos () = 0; /* Find, open, and read the symbols for the main executable. If FROM_TTY is non-zero, allow messages to be printed. @@ -198,7 +198,7 @@ struct solib_ops { return false; }; /* Find and open shared library binary file. */ - virtual gdb_bfd_ref_ptr bfd_open (const char *pathname) const; + virtual gdb_bfd_ref_ptr bfd_open (const char *pathname); /* Given two solib objects, GDB from the GDB thread list and INFERIOR from the list returned by current_sos, return true if they represent the same library. @@ -226,7 +226,7 @@ struct solib_ops solib_add is called. Defaults to no-op. */ - virtual void handle_event () const {}; + virtual void handle_event () {}; /* Return an address within the inferior's address space which is known to be part of SO. If there is no such address, or GDB doesn't know diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c index 68d40b8373af..e2dfe4a8c93e 100644 --- a/gdb/windows-tdep.c +++ b/gdb/windows-tdep.c @@ -831,7 +831,7 @@ struct windows_solib_ops : target_solib_ops { using target_solib_ops::target_solib_ops; - void create_inferior_hook (int from_tty) const override; + void create_inferior_hook (int from_tty) override; void iterate_over_objfiles_in_search_order (iterate_over_objfiles_in_search_order_cb_ftype cb, objfile *current_objfile) const override; @@ -848,7 +848,7 @@ make_windows_solib_ops (program_space *pspace) /* Implement the "solib_create_inferior_hook" solib_ops method. */ void -windows_solib_ops::create_inferior_hook (int from_tty) const +windows_solib_ops::create_inferior_hook (int from_tty) { CORE_ADDR exec_base = 0; -- 2.52.0