From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2V0vIqFwNGl0Cx8AWB0awg (envelope-from ) for ; Sat, 06 Dec 2025 13:06:25 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AsSdSB5e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 740E71E0B3; Sat, 06 Dec 2025 13:06:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: *** X-Spam-Status: No, score=3.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 71D9D1E08D for ; Sat, 06 Dec 2025 13:06:19 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC7A34152B4D for ; Sat, 6 Dec 2025 18:06:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC7A34152B4D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AsSdSB5e Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 8D9F64152C4B for ; Sat, 6 Dec 2025 18:05:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D9F64152C4B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D9F64152C4B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765044351; cv=none; b=g5XaeIeN3gjmkF/CuisYNIoUnKzdQ5Dg+6GcIeQs1QfUTJFrevWNsevrH+kkf+I4YZigaNnP5M1MWiZHpXS4nVTSRHlS0eNF6G/Bl+b+bXu8wGe/OPVvEl4NtOfXu1Z2YA5Ee0CF8YuhMm/GYqCGeM/A9a5KSgp3o6LMTT2loCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765044351; c=relaxed/simple; bh=QMvTZNYXUI1ctLb1jVd+RnnTuoUT+P/ThAiyhBWWELc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UkdZ+z1x30J+5vl5eSOv/h0vH5HVYTwB5AVlGdjavhx3MIjARDq4AaUD36e+wrm/jeZFTYlrO/PQF06VuyZ2iwa+eDU0FZ1FGshzF2sCKazBv6Cl9xsYngteq9KL//X06E/qdrcnaKem3mlObevS4IPS9e0zL9A1Iei0oFlZJgQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D9F64152C4B Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id RqyTv5i4EVCBNRwfFvX22g; Sat, 06 Dec 2025 18:05:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id RwfEvNUTKjAxuRwfEv7iUX; Sat, 06 Dec 2025 18:05:48 +0000 X-Authority-Analysis: v=2.4 cv=EoDSrTcA c=1 sm=1 tr=0 ts=6934707c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=VDrObqYXZVFmS-109I8A:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/L0sLxGGCVBCT2mjXK66LIjundUB4D2DarqLKy71n3Y=; b=AsSdSB5emcxMFN8RbcOVJX72sQ /QObA3KNPbIcelMFgMEbatpR5A+JWw7H6OIFG8pijd/90eg17pKXtcMhL/ysUcih3zAuFgcspupxA oOULKM0Lwo82WgE7TLarVV7sP; Received: from [65.132.217.2] (port=40420 helo=prentzel..) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vRwfD-000000027A5-0Qx8; Sat, 06 Dec 2025 11:05:47 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Unconditionally pass is_a_field_of_this in c-exp.y Date: Sat, 6 Dec 2025 12:05:41 -0600 Message-ID: <20251206180541.189881-1-tom@tromey.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 65.132.217.2 X-Source-L: No X-Exim-ID: 1vRwfD-000000027A5-0Qx8 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel..) [65.132.217.2]:40420 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfC5Xc+uN6GNMOX10CNjqeAgwNo37jklQ60sOCbLeVNDjxYOlX7UcQCGem5FuZm4m5Wu1A6cN04OsdV5TtjWS9P9k8dq8x1qSDq1NubXucTdMIpd163SI GrGy9ngfTEyhAWLls0Sw/B5DofFQ+itxP9WlXxFpUJc+/rSd1dGOytnbeBNelKCd1a91FDE0Gr34Gq9yxMHF1EmhswyA22c0oMA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In a review to a different patch of mine, Simon asked for this change. The idea here is that there's no need to pass null as the "field of this" parameter, as lookup_language_this checks the language anyway. --- gdb/c-exp.y | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/c-exp.y b/gdb/c-exp.y index 829058027f3..4ea60fe54f6 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -3071,10 +3071,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) if (lookup_symbol (copy.c_str (), pstate->expression_context_block, - SEARCH_VFT, - (par_state->language ()->la_language - == language_cplus ? &is_a_field_of_this - : NULL)).symbol + SEARCH_VFT, &is_a_field_of_this).symbol != NULL) { /* The keyword is shadowed. */ @@ -3136,8 +3133,7 @@ classify_name (struct parser_state *par_state, const struct block *block, std::string copy = copy_name (yylval.sval); bsym = lookup_symbol (copy.c_str (), block, SEARCH_VFT, - par_state->language ()->name_of_this () - ? &is_a_field_of_this : NULL); + &is_a_field_of_this); if (bsym.symbol && bsym.symbol->loc_class () == LOC_BLOCK) { -- 2.49.0