From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uJUqOlirKWnVhD4AWB0awg (envelope-from ) for ; Fri, 28 Nov 2025 09:02:00 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=hanM3wdg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DC9B21E08D; Fri, 28 Nov 2025 09:02:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F0791E08D for ; Fri, 28 Nov 2025 09:02:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB57B3858C2D for ; Fri, 28 Nov 2025 14:01:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB57B3858C2D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=hanM3wdg Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id DE7AA3858D2A for ; Fri, 28 Nov 2025 13:51:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE7AA3858D2A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE7AA3858D2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764337877; cv=none; b=DGCdHnM9/epnrfZ2I/nW0c+tGH84Qs0TP88ajJeR8TjhgrtE/QbhilGv0Y93O2W57+0j7uKd16oKT9o8n1KSywZpdzluXLlxDPmYRAduErQQjRgRPrUl82gEKCatFRHN+sK1zhIU6fsnKy/MquytxVB7KuoF4MIHnfr6/yafo1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764337877; c=relaxed/simple; bh=0dtGHnAOyTWpaZWRQSkkHDjeLeSrZdVJobbOtPrulZg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Xd4Nka33hNaUmPXXUM2KBXXr4qyMsMk9+cNNN2XLlUQ0FdDFs2a5lbySYkgMKnYrpHy7rwSrKfWFiW++jhBmsQVVpw++t8KzO41qrv0R8SS9Av+LHUb1DxzjTdvDHE1EX+EFlHdClUeemqJc/Z/Lxd4kQ4PaStxzqtF0ErfkVes= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE7AA3858D2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1764337876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUOJgEmnkfoYjufQvlD7oafpEKWJDcqYiiSRxcPcNwk=; b=hanM3wdg4cveTdXmP83fwMhdlTweDnxNvNIaXfKLzd2AFV6KSv/7lvD+R2H5xigCAHm1p5 pHy5/7ho7ixMMcDn3sA2UuFWReGpxG1U/OU2u/1JMLv6MlYcfvzVnzM0UIB0OVrDL20is3 lzHrDbTmshhVJqFX242XJGWeZuIDWAw= Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11021121.outbound.protection.outlook.com [52.101.52.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-qz_7iTh6NKiKWefuBDXjDA-2; Fri, 28 Nov 2025 08:51:15 -0500 X-MC-Unique: qz_7iTh6NKiKWefuBDXjDA-2 X-Mimecast-MFC-AGG-ID: qz_7iTh6NKiKWefuBDXjDA_1764337875 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by SA1PR17MB5476.namprd17.prod.outlook.com (2603:10b6:806:1c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 13:50:16 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9388.003; Fri, 28 Nov 2025 13:50:16 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany Subject: [pushed] gdb: update is_addr_in_objfile to support "dynamic" objfiles Date: Fri, 28 Nov 2025 13:49:50 +0000 Message-ID: <20251128134950.1763596-4-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251128134950.1763596-1-jan.vrany@labware.com> References: <20251128134950.1763596-1-jan.vrany@labware.com> X-ClientProxiedBy: LO4P123CA0439.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::12) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|SA1PR17MB5476:EE_ X-MS-Office365-Filtering-Correlation-Id: 265ce02c-8c2f-4565-afbf-08de2e850fdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FBMRBj+Zg0N3cZ58D5jWxTEIe2/fz2O3MLSDV9UiZWrbTXuXyyAZ8BYRym7A?= =?us-ascii?Q?fY8kJnmgjsUYu2MN9a94vQoxVklB8MYdNA/JdJnGLsf/rhVVa/aDWrnDapOE?= =?us-ascii?Q?4m21QH5s3QxjublEu/EZbwrBJDBhlFZ6jtE9GSm7JqdAImSPezYFLaRkW5e0?= =?us-ascii?Q?JXZ9FMze/QmQdN+Ea7lnQM1stPhmkgUfP9clW4bTK0Y8d+hJTO3kPy8boZWD?= =?us-ascii?Q?yDi4kGIaw4OmhkLGfpr9aBWnbcV3ZSfUb+lFhXHODXZMAb6v3XCv8A3rSNtE?= =?us-ascii?Q?mPdticUqRG2LFH0t/45BDOt6/Xi2ppA/0wgNmRpUWQDziXOzv9To0QhYBPK5?= =?us-ascii?Q?8dy0ZacAA2z0gxoSXvRai05abUlRjc4Lk0NkSK25oML6z9HI4ZiTtq3PO0Xe?= =?us-ascii?Q?9tYgVHvASXA6fHKy4DG6eFKJu6D1wyyqC0/Kpyhuk/RyAOfmdHgYMSSlCGJ6?= =?us-ascii?Q?Vw86dN81XBnh2lX7x+f4BfBRFYbVM23LS22Uy82wGVn2UqHw3/HEFQ17QCTT?= =?us-ascii?Q?3et/X9IFfxgRT8rc/nc49c/SUgSyKGL8aw/vpLZsIUUVXIfrT/CN5hYiZ91O?= =?us-ascii?Q?Qck/dq8i3ukD2a4IN3qYeybwctasz9zo1BlDM7BxrwbG/Ufz/35zgxGoqisT?= =?us-ascii?Q?DUM8mH+Kg+w/auqGTESzV9abpOFUOndeaoyIkewfRNKAwWwEAYjHfpRP6XjI?= =?us-ascii?Q?gBhxMCDu8sE5eglEu3bYlK50e99mgEjyMZ1REPyej97jxjMScFtvEmsu7pt3?= =?us-ascii?Q?lgUe64YQDkj35dX7wTaVAdq/A/wpU7IcjtgjQxE95wPe4hiDdCujHDjgvCZs?= =?us-ascii?Q?wbBMkw71A9nQN4+MGAaoJOF1DtoML3AstONCxWIQWxoUcTJa/nxOV28xk1vI?= =?us-ascii?Q?OwQR2hbp2smA9IbQmCzNXB20kVtqs48qPMY5HN+VUK2YyCqNKk4K+svmCe0O?= =?us-ascii?Q?Vcc7iYgyR2KT1oLvvk9UXMdTqlJbEWJMBp23VDm+3kUdEcX1VVra8NfVyOdO?= =?us-ascii?Q?+Madj33VpFM2MH8k2isjuXD0TGqHahmWG/8vKCqfyYNMZoYwpFNd+ZlYYT4X?= =?us-ascii?Q?6lsr0hRFQzD95SX+z7jcxtUAPS+ROElhXNp+qHGl8uzm2hvJuYcswZolv+Jp?= =?us-ascii?Q?1PX4OOWBiEBCtTmGWJJfjDijKwFfWOudbJHliVNCXCJ3EhH1LBVNWntL+ZGV?= =?us-ascii?Q?WXJc+LoTh+pntA8OJn/qJOqta6vNYQD+MCJvI7fEZJlniWqqnC7ilWIUMfyj?= =?us-ascii?Q?6tsvgwCyggiVMX6pY/B/Pi/Y64dYK1cwqfF/watyUB9D3aLio/MdfX93GpDe?= =?us-ascii?Q?GNmvLiMR9uEOYj7xw2mAVcH6KCg0dCrJ6pqkDjsCjuS/QTzwnF70BeAP/b8n?= =?us-ascii?Q?6zTFg0VfN04Cy1JKfBSZK8+4+wBOCXSCTH9UoizccfN33kbIlDppDiyiUXfn?= =?us-ascii?Q?gQFPr42rJIvwpAQ3vY8d8ddV1r/rGnjX?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?40l0zUsDhBe3oD4Y2zrKPSQwSb4d2t4/aQDJfzlfmaLFKTyjMAg4dn/tp65u?= =?us-ascii?Q?/jE/poeomnsRRAWkxKaWFmQcfuS+mORh+NmKR3ei5hLdEpADRrZQ2DLuqiqR?= =?us-ascii?Q?1hbvjvRhKvlyT+Wr/zgx4lkpoLbxsiUpg/GZKkZWmMypBGF/qkc7gI0xjuIs?= =?us-ascii?Q?lRUDaTCfCMVCYVFVWOqnXYPuuAG97/9TVuwfcHeGN9ymVeR2AXSFNvl3IXu5?= =?us-ascii?Q?nqZ5nbXe7q6FAVPclg3nv+LqsWU2IF4O/CzS1+qauFLX25+ggmzQMTDaF5ml?= =?us-ascii?Q?ZCCiEqNKqOlfrW68ZevOp8xCLHPu5bWbiJHg5e62USvNSnoi6fAQkLqAb4Uu?= =?us-ascii?Q?jfbu2UTJwrWPGR6fGkiTow6nN0AI9/KW8l8ZO0J2UkOE9pZo2dN+b4dGnN67?= =?us-ascii?Q?LrN8K6ye7pTxvPuPMj1aB/kgeuEpm2jCSsk/jMLP29mXjFppeWIUi0gERsyZ?= =?us-ascii?Q?umQyh3onSvWqWy26vZU+8QJHUkBm8nHBsfB3YUp3gmj9Y0yC+CtJO5AYEeNV?= =?us-ascii?Q?DWjvh5dx+vKgbdpxlLpBlYD92qHRffFpLpBg/zUnILE08yak7RJGHhi+i+Hn?= =?us-ascii?Q?QjiuDqtNIeLSvpddgDi4LZZ5qcBEfJMx+F8VA/h2A21+Za6XHYBX/IbaTXYY?= =?us-ascii?Q?exGKAYY9SjndFwOGKYeFiFEPXWMcQOutk8BLPREgZRfyo4i96ytK/XFH19/v?= =?us-ascii?Q?e7jT3ugzDpAfnxx6K/BSFpKgS9wK2UJtS0zEf5cem2L3Rh28prmtElkEVqkF?= =?us-ascii?Q?xEXJsgYAWPU7qGOFKDNRbAoGAAnfFcz7xbTMl3Q7L3YsOaa+QfZ5S5tzSq7V?= =?us-ascii?Q?kz46QlPmJ8/DtBv957Sg/9ZASW22Q554fHGQ8QpaXyMg+WTf4j23UfH60vi2?= =?us-ascii?Q?mXw7UzMEowyWcgoJfC12JTnhU82bC0aIyOiIMml5i+8t3CbUsgw9OB39oJBv?= =?us-ascii?Q?ypqns770I5kVx4R5GIgCE/VoDD78VbYnTZvjcOVGKOzZzAqsKX5tmtsO1dUH?= =?us-ascii?Q?EHTofc7JACzg5+r5DE0GViLEpcR+9pizt6XG1O9jMnmhstXN3MwS/IR3xJ0s?= =?us-ascii?Q?bCDvc06VqP1zWUJT1IvdVlHtPByHAltFUbQKG7dp2WapHdr18UUWPZWjfw1U?= =?us-ascii?Q?fl0b76ugYMV9JPf2Y8SgBmL6xWWAfBeAxfmlNGRB6nDzt6fl/SLHHsOsnBgw?= =?us-ascii?Q?JwT44qLTWr1Bs/v9hVMwAFcCkV9M2jJTZIRTIl/0ubfQp91SZJ4RkR8hzBuH?= =?us-ascii?Q?bKlYoza+qNvZGG88SepCetkyTMDMeAOaOMmXou2r4c9gvENF5C3o71p9mvou?= =?us-ascii?Q?inhK7ro3SbH8fR8ACkB9zpMp4IqjZXnPhlzxW5Ztmg4Ogr+Cb3SsyeECEbsw?= =?us-ascii?Q?c3yW9f7pJ0Nf/kJoZGUFkxKttDiHjIEV6jM6JRGl+7aFefc9qKLeOjdQBB3r?= =?us-ascii?Q?yV0ietxeJOtB7S1sI8tzQY07lh7t3Q1U9lDLQ6nJKyOfYogKcYcy0NkEP46z?= =?us-ascii?Q?ShPHPn83Ut4+BOiFI+bL2ekgl2XaEkpIhMOsfgDrtBCnRasmjMgtyakasbU2?= =?us-ascii?Q?FH2Kp9EcYTzoumyg0M0EGcVcKp0W12xSBjJW8Lo2?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 265ce02c-8c2f-4565-afbf-08de2e850fdb X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 13:50:16.5317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DaPXrsA4RbQXEMPw80rxJXJPdKVq9JnRBCHEQNKoHoFMlvLgAf0HDx0RZiJqt/cc1QA+/5dtM6HuAisB1QjDJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR17MB5476 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: II7GEQh8-b50bZZ8N1ujsi5lNstkFfbgrHNARYLbyQU_1764337875 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While working with objfiles in Python I noticed that gdb.Progspace.objfile_for_address () does not return "dynamic" objfiles created by (for example) GDB's JIT reader API. This is because is_addr_in_objfile() checks if a given address falls into any (mappped) section of that objfile. However objfiles created by JIT reader API do not have sections. To solve this issue, this commit updates is_addr_in_objfile() to also check if the address fall into any compunit in that objfile. It does so only if the objfile has no sections. --- gdb/objfiles.c | 24 +++++++++++++++++++----- gdb/objfiles.h | 2 +- gdb/symtab.c | 8 ++++++++ gdb/symtab.h | 3 +++ gdb/testsuite/gdb.base/jit-reader.exp | 9 +++++++++ 5 files changed, 40 insertions(+), 6 deletions(-) diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 0d166ceec4c..5c5b04c6458 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -1084,14 +1084,28 @@ is_addr_in_objfile (CORE_ADDR addr, const struct ob= jfile *objfile) if (objfile =3D=3D NULL) return false; =20 - for (obj_section &osect : objfile->sections ()) + if (objfile->sections_start =3D=3D nullptr) { - if (section_is_overlay (&osect) && !section_is_mapped (&osect)) -=09continue; + /* Objfiles created dynamically by the JIT reader API (and possibly = by +=09 other means too) do not have sections. For such "dynamic" objfiles +=09 walk over all compunits and check if any of them contains given +=09 ADDR. */ + for (const compunit_symtab &cu : objfile->compunits ()) +=09if (cu.contains (addr)) +=09 return true; + } + else + { + for (obj_section &osect : objfile->sections ()) +=09{ +=09 if (section_is_overlay (&osect) && !section_is_mapped (&osect)) +=09 continue; =20 - if (osect.contains (addr)) -=09return true; +=09 if (osect.contains (addr)) +=09 return true; +=09} } + return false; } =20 diff --git a/gdb/objfiles.h b/gdb/objfiles.h index 0dd3fafac03..f65f3bde930 100644 --- a/gdb/objfiles.h +++ b/gdb/objfiles.h @@ -476,7 +476,7 @@ struct objfile : intrusive_list_node /* A range adapter that makes it possible to iterate over all compunits in one objfile. */ =20 - compunit_symtab_range compunits () + compunit_symtab_range compunits () const { auto begin =3D compunit_symtab_iterator (compunit_symtabs.begin ()); auto end =3D compunit_symtab_iterator (compunit_symtabs.end ()); diff --git a/gdb/symtab.c b/gdb/symtab.c index 701aa5d0007..5754d944b6c 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -513,6 +513,14 @@ compunit_symtab::symbol_at_address (CORE_ADDR addr) co= nst =20 /* See symtab.h. */ =20 +bool +compunit_symtab::contains (CORE_ADDR addr) const +{ + return blockvector ()->contains (addr); +} + +/* See symtab.h. */ + compunit_symtab::compunit_symtab (struct objfile *objfile, =09=09=09=09 const char *name_) : m_objfile (objfile), diff --git a/gdb/symtab.h b/gdb/symtab.h index 33cf0a6c229..45aca07bc36 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -1964,6 +1964,9 @@ struct compunit_symtab : intrusive_list_node for ADDR are considered. */ struct symbol *symbol_at_address (CORE_ADDR addr) const; =20 + /* True if ADDR is in this compunit_symtab, false otherwise. */ + bool contains (CORE_ADDR addr) const; + /* Object file from which this symtab information was read. */ struct objfile *m_objfile; =20 diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base= /jit-reader.exp index cd844ca75d2..df2dd74a6ab 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -234,6 +234,15 @@ proc jit_reader_test {} { =09=09gdb_test "python print( \[o for o in gdb.objfiles() if o.filename.st= artswith('<< JIT compiled code')\]\[0\].build_id )" \ =09=09 "None" \ =09=09 "python gdb.Objfile.build_id" + +=09=09# Check that Progspace.objfile_for_address () finds "jitted" +=09=09# objfile +=09=09gdb_test "frame 0" \ +=09=09 "#0 $hex in jit_function_stack_mangle ()$any" \ +=09=09 "select frame 0" +=09=09gdb_test "python print( gdb.current_progspace().objfile_for_address(= gdb.parse_and_eval('\$pc')) )" \ +=09=09 ">>" \ +=09=09 "python gdb.Progspace.objfile_for_address" =09 } =09} } --=20 2.51.0