From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gajrN4eqKWkQgT4AWB0awg (envelope-from ) for ; Fri, 28 Nov 2025 08:58:31 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=M+c5ilzN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C57031E0B6; Fri, 28 Nov 2025 08:58:31 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16FFC1E08D for ; Fri, 28 Nov 2025 08:58:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4BCA73858C41 for ; Fri, 28 Nov 2025 13:58:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BCA73858C41 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=M+c5ilzN Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id 97D463858CDA for ; Fri, 28 Nov 2025 13:51:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97D463858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97D463858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764337876; cv=none; b=OKZB4RGKrk7RQAppn1BK3wvrqBhCaFEnRayT51aYBJkEFZ4gjSMjV+E4dGRnjoqqokBOj0tO2elz7K7MInQDnRgdKWPxo/uHu9szTBIDZjieN4/Tq+gy4khRwV4+Aqlu/DE2ftHk1qisvWxur1Y2JmNeckUy48eiapt5/pxrrdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764337876; c=relaxed/simple; bh=gJev9IwY2Abzena6Ob+1/Zi6JFpVgSlAE0HD+8s4JnM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HVyT8sVXGnor/eacP+gR75dqEhQDAtFR325E3OvWNOXu9TY9iaYYocvYr0bH0w8l3sXfF0qlB3Bbg8PUYif5BQf6lvaG9q+OXp7dFWRVRqZ4qCYIIKGPMUwZhpfBXj5Ol1iBbWm8ainczs3sYz8nisZ/pZbIJq9YOfL4xKyPYVM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97D463858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1764337876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p2VsQh/N4ahAaj5pkg5bvrEg1yV7wN4/WG0ewwIpBlU=; b=M+c5ilzN7wPSxXzQGYUc0AHkjJ16pfPtaenzTBcEOZl4bUqImJArBCo6yd7X+ROcmOa0ip D6LY4/WhUlggYWM8bd2GICd/PcvcDiP4MJ19J09WKXCzACx6eJeBsi4hGxGvyDtNadtdcF I9Q3vJ61IaUcsRdI3W56+QUILd2h3SM= Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11021121.outbound.protection.outlook.com [52.101.52.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-qR1RRLqEOQiZF_V0y1x9Zg-1; Fri, 28 Nov 2025 08:51:15 -0500 X-MC-Unique: qR1RRLqEOQiZF_V0y1x9Zg-1 X-Mimecast-MFC-AGG-ID: qR1RRLqEOQiZF_V0y1x9Zg_1764337874 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by SA1PR17MB5476.namprd17.prod.outlook.com (2603:10b6:806:1c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 13:50:12 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9388.003; Fri, 28 Nov 2025 13:50:12 +0000 From: Jan Vrany To: gdb-patches@sourceware.org CC: Jan Vrany , Simon Marchi Subject: [pushed] gdb: add unittests for blockvector lookup functions Date: Fri, 28 Nov 2025 13:49:49 +0000 Message-ID: <20251128134950.1763596-3-jan.vrany@labware.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251128134950.1763596-1-jan.vrany@labware.com> References: <20251128134950.1763596-1-jan.vrany@labware.com> X-ClientProxiedBy: LO4P123CA0437.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::10) To SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR17MB5365:EE_|SA1PR17MB5476:EE_ X-MS-Office365-Filtering-Correlation-Id: a506f363-d948-4950-7c18-08de2e850d7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Vrsick2E77nsEDdfLEef84b1rEpB8OBIleD22053Mk/KPDeHeR3sezyfHYm7?= =?us-ascii?Q?fo/Hmt1E0ef4dKJaKrEfHGXbJQJGyhS7evdZof3S+e6XV0KEoaU53q0DfXNV?= =?us-ascii?Q?cTTX1Qwrbhvrsaj5mIWzZvlqABJS54Tt/s6l5Jm3uYIJP7/IncgMATfEW/6h?= =?us-ascii?Q?2xln74F4ww7BPogu7e6lsRT2zChnLBOSmbZ0rkpmh6TyjKSJPgkTHi8MxJGG?= =?us-ascii?Q?5l9DwW6QcuR6KYpUMtcHCwBFbIoBULQDOQkqnZzzdsRYiOlqx3gK/g1WUU8a?= =?us-ascii?Q?BgQo7otCH2HNdr6k5YsAmJ0lwpj4tiFd1drsqQ9QoJqa0OUrkPmfa7CbRMg3?= =?us-ascii?Q?ulkz/N1Np4pNnYDtO5bBWukqSfLHDq9HU7ZhUmNECWaT7H8fpMFmh2Xwm7iG?= =?us-ascii?Q?kWmhSeSRn51RsjSxTq50BaRvgxzk8MPcZaDeU/U8WyYS8G0EvVVwG2kQRLD4?= =?us-ascii?Q?UI9linTc/FTTNVmG12tnBEv9lJpn6IFXQDlqBdRkaytpkhR59TTui57VeFja?= =?us-ascii?Q?MSvHPeWwpf90BtxwlRDe09rBvXNQqOM537VPbYQB/jyg8W0P5rCA/bawpZVO?= =?us-ascii?Q?+8lZ8c3cxkzNU4AKUb2soQ7XzV0xItK5AcywpgIrHif/4zCBaxA4ZMjzRoqf?= =?us-ascii?Q?tSivKJiHQjHgazyJsCLZSwcKrGPRl9+1b/j8HQkKQt0L4i5biqpq8MrIr8ju?= =?us-ascii?Q?2ZXk27U6UVXAYBYFbG63iW0ka9K/6woZ3f+gv71Nn6x5qAPVlKU96p7kMF5Z?= =?us-ascii?Q?nwY2wRxBXl2AQ7w26CxiCbXbnl+0i1MGNQUmEMYh97oBha7YPcR+7IVufxy2?= =?us-ascii?Q?E/ncvlbnKXQtTxtovwjSEQQy6m90VK5yU1mMZa2sK4yAp1ZI8vFPtgIJGaKQ?= =?us-ascii?Q?1pk8sbkDBjSBqUFFf217wfcIJAoU9pON4jeaGKh7vyyHEF732s8YNHQcwE8q?= =?us-ascii?Q?0vi6n191aZR6hsWGBiFxNRa2jwRV8x9VWbmjh/dvLbdQ4YKxBjiH0iJl3AWI?= =?us-ascii?Q?aXq1i+/nY6bXj92Hx7WglT/ElO83b17WAu3flkA68SvuG8BAXv/oU9Rem/J4?= =?us-ascii?Q?G+Oehu82GXaVyunhCtLrU4kt2N2cHgtyJQLsf+09gbjhNO8gpJNBiDawcdgT?= =?us-ascii?Q?fMoWMK4fKOwpXWt9iEE8l4HYB5Ad52wjeaLvCmju0IWcM7oNBbkHB7n04cVx?= =?us-ascii?Q?cs40b0dE2uEBJHUzpRiVK8zsENHtRexQ519NPJdgftIX79qpJuVSpyiqloYz?= =?us-ascii?Q?KUNNAxrtWddz6KhSOqsGZGPiE3u4/0mWHHVKVHoMGSraGGHA4PfisLcc3Nmf?= =?us-ascii?Q?KNpTuBzaL1V+xsI8OOT7ucUB6mvNvBQKs4cMVmEnmiUtiKajQxsYluUIdLGy?= =?us-ascii?Q?V3ORVR60ZDeq44HeTT6Ovr7dj/xfIXZPqWr5r7wa5aOoT1UzW4NNZbfHBq1T?= =?us-ascii?Q?QJ0kQdy0m+9T0VpOjIKxS6sPDnM0TZCX8RO1CIOO7eZhhskanXDFjw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dL5a7SovALhdsK9RNk3XOGQGgY1ojWLjVQ/9uveDH2OZxeDYyaahNfDXCUNz?= =?us-ascii?Q?Mc94t6W3jrWMkFpkUxqf8yIqo0l9uI5PHUOl5FDY1mP8n+Cs6Y5ZZDxZtfa0?= =?us-ascii?Q?lVC2TSXON6kQalqOQlrY9F0rwS+w5TYHCoY9rOfUARFGvmMTPSKQuBkRcFND?= =?us-ascii?Q?TXQGEqAaj2BDzZKlp4VP021qWKBsOy4P8kur2e+597EH7txgmLlw3PWmyvGC?= =?us-ascii?Q?nIFJW0X98AVmvq5MaFZej6XdaYKVajcO4kXr1m6CDrou4wfPaiX/eSN4GfBg?= =?us-ascii?Q?bHvnDM1HRjX3xdzn7L/wOLEa9FmMiLttP1y4DgXaaD0pErwg/QbBKCg6NG3w?= =?us-ascii?Q?nByYP0thaZaChSFeYoDtCfRU7C8zEaYJF8y9FALCfVF4j3XyDe2MVB2FpdUQ?= =?us-ascii?Q?oQ0AZkYYM2+3X1TBc3cgai9DWRCG4ZrM+6gVd71eI5fLUG3Pk8tPuRZEPcp/?= =?us-ascii?Q?mGwMk3Kh/nH6w+Cl3RzNEKvmGfQxpejN1uR3jBxhhHdB5X0b8lzzCwAHhPXZ?= =?us-ascii?Q?3VqOquodtmHAzUGhaElrQzztal6ApwQVuxyOzOEoc/9iwIRiBGBDs+7R4r5/?= =?us-ascii?Q?J1nJ0mVuCgvCkH6A+qIuUxmFep3eLke4qdamT2j1eacvfi3ApC2EOaO733Iu?= =?us-ascii?Q?7p7Y9spcKIhH/dY5aZwYrzzy0dtmErNlNrCQ/i1KP5oEg58Kxx4OAd9wkTfR?= =?us-ascii?Q?e5cFawID7oh/DlhpFkxwS+KJ0LTJTsW6SPndde/lHnLEii4II74O0N1cLvmQ?= =?us-ascii?Q?ZpBBdzd/2mqtoEnwa5pNO+PGR8MEruoYbM0AwF5pYm1p8p2/2OVR9I7rgwxc?= =?us-ascii?Q?cMedrXxGkmMuRcGnr3vK+ZQ2AsY8TPG6flM7fO3QwGg3ZNqloBnD/BiR2HEC?= =?us-ascii?Q?xamZFb3a2d6ORmGrzjvv/zQtfi6MHFGGcHcFnqpbfMxm9Lxj9Hz6OlAmVxrs?= =?us-ascii?Q?MQ/CRn3PFFRW7sfUkX6bFZUQrcHB4jyEQUy46J5UiwihL0i76JeP/yip5ILY?= =?us-ascii?Q?S+hVA0PWl7vLZbkyWu8s6ghl35tQ1WdIxKJHP2yGdYkxZFVX2mAmaPZ3LmgJ?= =?us-ascii?Q?SWyJbmQ54VVgZPUh28h6eZAjkgEHlIIYxG59qFssgrVJrQp+lBhNKWzGEqDd?= =?us-ascii?Q?EDZEBu900iH7hgaJMT8B91peZJxKWeaYsNSwm4JibfZ2lZelcMYanDR64f4b?= =?us-ascii?Q?kRv6GX/BhECR2Fxx6BinHQLVdABZKYr0wVkht7hKYD20u/VpRsnHcMPQbfal?= =?us-ascii?Q?9cvsDdedHb+JQw5+s/JtxujKbijxVrU3Ke6UHRv+39L8twJLjwZFvvQUqZWl?= =?us-ascii?Q?RVRerrC14Y50D/j1Ff83jlH8bb0qzSovi2WtY7Cmc2YfBwgL5c7m0SWzkK89?= =?us-ascii?Q?bQfF7XUvt8YuKIkWbnBBW3dvYnXPo9i4oLgIRly96u6+vGc/8F9zIMitTMCR?= =?us-ascii?Q?UMpXRE9BbxbNwxPXly+sCwhqRUSCoMZp0Dsu7BSFMivFj7zP6MepmglsQ29t?= =?us-ascii?Q?WRiGM8ldYjuIFt42lmoFPS8VX2tYjU45c1EOivX8u9gR1USgV6G7X8vr7GuM?= =?us-ascii?Q?2aPeVELrpSENJOm+NJKiJCJ8YaBPfLj9ttvZUilo?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: a506f363-d948-4950-7c18-08de2e850d7a X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 13:50:12.5460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nHYNyUFrdsJjHRcif+2iGfjb7rMh7YVbLLMQ1Sh+ISoHMBZt/5UEJ0k8ftF27k6yrOf0IWgR3ZTFL9RxnMWz4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR17MB5476 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pij-aolfyd68YDMLOUkKtyycZo8ezm09naE-Uss5A3Y_1764337874 X-Mimecast-Originator: labware.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=WINDOWS-1252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit adds new unittest - blockvector-lookup - that tests blockvector::lookup () and blockvector::contains (). Approved-By: Simon Marchi --- gdb/Makefile.in | 1 + gdb/block-selftests.c | 128 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 129 insertions(+) create mode 100644 gdb/block-selftests.c diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 538d10a824d..ed29f1703cd 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -451,6 +451,7 @@ SUBDIR_PYTHON_LDFLAGS =3D SUBDIR_PYTHON_CFLAGS =3D =20 SELFTESTS_SRCS =3D \ +=09block-selftests.c \ =09disasm-selftests.c \ =09gdbarch-selftests.c \ =09selftest-arch.c \ diff --git a/gdb/block-selftests.c b/gdb/block-selftests.c new file mode 100644 index 00000000000..f5883f18660 --- /dev/null +++ b/gdb/block-selftests.c @@ -0,0 +1,128 @@ +/* Self tests for blockvectors + + Copyright (C) 2025 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . = */ + +#include "gdbsupport/selftest.h" +#include "block.h" +#include "addrmap.h" + + +namespace selftests { + +/* Create and add new block to given blockvector. */ +static struct block * +make_block (struct blockvector &bv, struct obstack &ob, CORE_ADDR start, +=09 CORE_ADDR end, struct block *superblock =3D nullptr) +{ + auto b =3D new (&ob) struct block; + b->set_start (start); + b->set_end (end); + b->set_superblock (superblock); + b->set_multidict (mdict_create_linear_expandable (language_unknown)); + + bv.append_block (b); + + return b; +} + +/* A helper to create and set address map given a blockvector. */ +static void +make_map (struct blockvector &bv, struct obstack &ob) +{ + struct addrmap_mutable map; + + for (int i =3D bv.num_blocks () - 1; i > STATIC_BLOCK; i--) + { + auto b =3D bv.block (i); + map.set_empty (b->start (), b->end () - 1, b); + } + + bv.set_map (new (&ob) addrmap_fixed (&ob, &map)); +} + +/* Create and return blockvector with following blocks: + +=09B0 0x1000 - 0x4000 (global block) +=09B1 0x1000 - 0x4000 (static block) +=09 B2 0x1000 - 0x2000 +=09=09=09=09(hole) +=09 B3 0x3000 - 0x4000 + + If USE_MAP is true, then also set blockvector's address map. +*/ +static blockvector_up +make_blockvector (struct obstack &ob, bool use_map) +{ + auto bv =3D std::make_unique (0); + + auto global_block =3D make_block (*bv.get (), ob, 0x1000, 0x4000); + auto static_block =3D make_block (*bv.get (), ob, 0x1000, 0x4000, +=09=09=09=09 global_block); + make_block (*bv.get (), ob, 0x1000, 0x2000, static_block); + make_block (*bv.get (), ob, 0x3000, 0x4000, static_block); + + if (use_map) + make_map (*bv.get (), ob); + + return bv; +} + +static void +test_blockvector_lookup_contains () +{ + for (bool with_map : { false, true }) + { + /* Test blockvector without an address map. */ + auto_obstack ob; + blockvector_up bv =3D make_blockvector (ob, with_map); + + /* Test address outside global block's range. */ + SELF_CHECK (bv->lookup (0x0500) =3D=3D nullptr); + SELF_CHECK (bv->contains (0x0500) =3D=3D false); + + /* Test address falling into a block. */ + SELF_CHECK (bv->lookup (0x1500) =3D=3D bv->block (2)); + SELF_CHECK (bv->contains (0x1500) =3D=3D true); + + /* Test address falling into a "hole". If BV has an address map, +=09 lookup () returns nullptr. If not, lookup () return static block. +=09 contains() returns false in both cases. */ + if (with_map) +=09SELF_CHECK (bv->lookup (0x2500) =3D=3D nullptr); + else +=09SELF_CHECK (bv->lookup (0x2500) =3D=3D bv->block (STATIC_BLOCK)); + SELF_CHECK (bv->contains (0x2500) =3D=3D false); + + /* Test address falling into a block above the "hole". */ + SELF_CHECK (bv->lookup (0x3500) =3D=3D bv->block (3)); + SELF_CHECK (bv->contains (0x3500) =3D=3D true); + + /* Test address outside global block's range. */ + SELF_CHECK (bv->lookup (0x4000) =3D=3D nullptr); + SELF_CHECK (bv->contains (0x4000) =3D=3D false); + } +} + +} /* namespace selftests */ + + +INIT_GDB_FILE (block_selftest) +{ + selftests::register_test ("blockvector-lookup-contains", +=09=09=09 selftests::test_blockvector_lookup_contains); +} --=20 2.51.0