From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2SwJH5/sJmnQFTIAWB0awg (envelope-from ) for ; Wed, 26 Nov 2025 07:03:43 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=htecgroup.com header.i=@htecgroup.com header.a=rsa-sha256 header.s=selector1 header.b=sSXl/75S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A4D71E0B3; Wed, 26 Nov 2025 07:03:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7EC71E08D for ; Wed, 26 Nov 2025 07:03:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A03823857C4F for ; Wed, 26 Nov 2025 12:03:42 +0000 (GMT) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021128.outbound.protection.outlook.com [52.101.70.128]) by sourceware.org (Postfix) with ESMTPS id B48403858D38 for ; Wed, 26 Nov 2025 12:03:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B48403858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=htecgroup.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=htecgroup.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B48403858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.70.128 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764158587; cv=pass; b=agPGp4tkxiqJrpMWaHpeMmgRd/k/dsFo8xPfnBURIp+KOtP/H0ZNGBFOu56mM+mvbpAwrM1xfRVk14IaaoXkMP9KsJRo5Z28GMk69iiwy1HfIktT4WE/0YFyQCTvIi84eLg1jZtpM87RB0u0spq3kXC/Ua9x8oORHrIIQTre+Hk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1764158587; c=relaxed/simple; bh=epNEnZROEMYHZYULcCLMr/NqNZyzgWiOwZwkeqgFSZE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=C52LCBoNpg7+lU3dr4iWD+flsv1BEQUyULuf52DL01xrPYf6ukaJIh2cqz/SX+n+4086IfN/k0wSiMOAli0KuL7WMnFTpLT4Uwbr5DImAIn1JxajUaHKldXCYUvh+jep1aph0ycJfYs8TD6SoodBqa9+7tlfbQE5ArHCFLEYHRw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iNLQI4VNc3mSKoT0O3PnfCAiW1ijIL9dIWGwtAf7FhjwOMqk/DNT3OMUAHsOyvnZsgnG4CD7/SIQa4yVCrgEc4Sx95f6DVSxdsom+3QvhA3ncIoBRlcjhMVxsJj3SUbdsggriVX74Ru6keH4CJBJWdAkvyrrfG8LDqMXiI1lsY0CjgKRCGChzrN/LVtqDou6uEHFYXQzeZXJHbwjpb6/6JQaGJtzts03aUZhXY0eosP5RQrj1WRCerk8AMF9HfHvlPHCa2P2SKNj+r+r2g2gM+rk3fSa4henUwE7E/X0eqyE06hHLbCfxrovTcugOKCvzVhEQyg2tGAJskCKYQjTvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eiDb1YyjLDKKpqWP1w0LZV+itFYOt6szgqumdGcwAGo=; b=BackcFwmwPguvL/jTLpKK04cQOC0IWaFLBGA+t7P5FStXNikFi0Q6V9F7edeouRgfWws1NQ+3qPUj8++EWEMQ3Suju3RN6XR/PHcr+VqigZPAAnpLw7HMoqBn9/fTjsvaGjjZE3Cbb/QzQayHDLRfm38Zyy1K0+LyxL1YUnqqErdGmeQ38KQ6MgseHfIiji5IQVHCA1B4/iWte/QV20GywHldk3H+N9hGI8ggY9IpTw03DblyreoY0TJKPDHSQtms5MLphe544wN9KdW55LadZJX/7zVzTqNSkNKP5AMYe44TOwD3M4HLq5TM+4Mvelwj5Rlb9eUsrU8gO1W5Rjnfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=htecgroup.com; dmarc=pass action=none header.from=htecgroup.com; dkim=pass header.d=htecgroup.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=htecgroup.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiDb1YyjLDKKpqWP1w0LZV+itFYOt6szgqumdGcwAGo=; b=sSXl/75SWc1i28nmVzJrx5xSSmXMyn3VTB7t5634hDm6Z8uPt3i91biPLQGyc1xPG9YGqduqHBX8wEcSJZ1okCKKDdfkTNzxTg78WSDtjdGOT0e5g6+uFUs6J5p+H1xG0iY/yWAzITJ0XukEKwT1WSuX6cd3uy4kPUetG9/fI9CZ62iHfEfjrSWSw9GYPnKJ3D/9oprBFcnD9KX84uzdtjzl1D85BsKrpfmTVGizaDUPyyuFpiVTD7aZ4I1CEl/CtHB9noK0C94Kvd3FkYCMqG7rhrUt0w774eBWMbLqnxL5YqdIN5yAO2Z6mDVlEWszyzZoUfHn47oNS+dbdC5L7w== Received: from DBBPR09MB3477.eurprd09.prod.outlook.com (2603:10a6:10:d7::21) by DBBPR09MB4537.eurprd09.prod.outlook.com (2603:10a6:10:1f5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.12; Wed, 26 Nov 2025 12:02:55 +0000 Received: from DBBPR09MB3477.eurprd09.prod.outlook.com ([fe80::a339:e3f8:fe9b:112e]) by DBBPR09MB3477.eurprd09.prod.outlook.com ([fe80::a339:e3f8:fe9b:112e%7]) with mapi id 15.20.9343.016; Wed, 26 Nov 2025 12:02:55 +0000 From: Daniel Knezevic To: "gdb-patches@sourceware.org" CC: Tom Tromey , Pedro Alves , Simon Marchi , Daniel Knezevic Subject: [PATCH 0/3 v4] gdb: Make printing enum types prettier Thread-Topic: [PATCH 0/3 v4] gdb: Make printing enum types prettier Thread-Index: AQHcXsyZz1ox+m+pbk+XvpKsIk+4Rw== Date: Wed, 26 Nov 2025 12:02:55 +0000 Message-ID: <20251126120210.919813-1-daniel.knezevic@htecgroup.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=htecgroup.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBBPR09MB3477:EE_|DBBPR09MB4537:EE_ x-ms-office365-filtering-correlation-id: fb909fcd-f366-454b-1d62-08de2ce3bbaf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?Sc152PV/Z6EAhNrZY04apOXoM4xEo2N8iHGI7/5Gsu/vWBZzUpFqmDaDLg?= =?iso-8859-1?Q?xXo748dzsDm3mbMylMkuoh8QqvNJPj8drPs+QpGDMN+MPrCEVRTdMNd0R5?= =?iso-8859-1?Q?o331oe5m4WhgaDVqMKJDSsJowGzNh5Dj4GGnCkM3bYZNLzd76XlU4/hJ4A?= =?iso-8859-1?Q?VdNP5+YtiH6kfbWU+SHba/lgkE63UfBFB/Im+uotJTath6T210u5+Hj1YH?= =?iso-8859-1?Q?faCop/ag2UNhPcG32n4FihvVeaZDjgwfPJDd42+6cwxXQyCx+U2Bqr6bQg?= =?iso-8859-1?Q?JWk0S7cbvzWvyvrjA8oQY+yyE8ZHBqaMhpiyD9nc8cHQI0El1v8d2Umc8r?= =?iso-8859-1?Q?rzDeRZnTTUTl3WS3taNo2NBpm/I0utyq/g+gqA0KePWYW8j/+8rnKdblYb?= =?iso-8859-1?Q?e6KxQGD1OD3ZeK+NCj1wH8PD7fd3/4Q5LJ7k6XCmDMt+QnEJoUaj2d+cJR?= =?iso-8859-1?Q?0TxjkJWMALlc+ocTwQBrVcQUREOkBF6ej6l8HSb4M32I76sKZwivHUT2+M?= =?iso-8859-1?Q?zS9yCWQuu+B4cC1ZV/e4xQ66Bbmm/FBvpxjh6TshjAFKFXgoeWCFrORzHR?= =?iso-8859-1?Q?mbeZ6mYmGuRRcoLyP6Oa4uVuu0etgWOYzBTSaH30aV3T9J6mS1k4pFVqjX?= =?iso-8859-1?Q?C3Ikh7XHn7BXsnDGoUZm9quCJc8orpAKmNeDJZ3frbRzuonA8oAUPAH05m?= =?iso-8859-1?Q?U74w08fUnY342UCfDr/rE86z5GcDlEU0BYO+u/Dqch54kOWR8bTtdMb+OE?= =?iso-8859-1?Q?wMguQ00VZs0v/A28XBZDIpAanDa/F2PiQcwXQJGbQPrBLGqGTJGev5FV+i?= =?iso-8859-1?Q?Ou1KpFXWuX1zm9NV300qJ0jqkyJaf91UDRIFmnm71v5/PQkQ9DVSoXltCr?= =?iso-8859-1?Q?dhH+V3dk7zLwKlEiFCPEw0DUa0Y3EtqN6ivY8a8fVvRBEnzaMWzNbRuqkR?= =?iso-8859-1?Q?GblNFVkTMHEcLc2e0WXgkjF4HUXKTx+Ns0U9nB9KQAzKrQDbmqwP6w220v?= =?iso-8859-1?Q?r0jLwDQXDx6AMSMAROtU1kSyRU6c8vppH8IV34mls7H7p7fGRZKeVmj29l?= =?iso-8859-1?Q?gMw0AN8zDQI3+nNXxzh0S1aWhNKLrAVrl5yq0wf2/z6JUt26M1Od5FbB8r?= =?iso-8859-1?Q?XIVIKStGaCqB/VIOG0IccTt6MasoHUNBMoWzz5QaF8vUux0VWPxStv2XeT?= =?iso-8859-1?Q?06619Q+oe1TCEWH3y5+WJrHsZqWP31cKoo3tzgaY1rAciOBdqJEYlVy34s?= =?iso-8859-1?Q?O3BSbtP3eldD7US6iKGdhXbiraOLABnMSymHF/ycq26BntGubtpLPTjPem?= =?iso-8859-1?Q?MGCEFvqzAWPBi0RDJ2rcKiJWLWBwgjB3hz1J/aK6bDXp/KLuWlklor2dTS?= =?iso-8859-1?Q?QRlalAltEQ6UYSKQ4hJ0OFo9wVgIvAKzSs3nMNm4iGUpb2uLY1bQpOmTI9?= =?iso-8859-1?Q?FwuVkwY9lp+R3I8WXDj/lyxFad8y7F6mgXST73t42P9UmK0vF8ifGXde9/?= =?iso-8859-1?Q?olPJu3khogqOReeUa1nmVlOTH4M60cHu6TuHyQOEPYlGjjZJlZTBt+Fo+4?= =?iso-8859-1?Q?6QaOYU/DTSBGgFQfLzGBmCIsN+Bg?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR09MB3477.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?WDQPGaJmPnwcG6TQAEWUGE0rehUxuLNx7tL2Onzh7Hith1lSEwNM9d9D57?= =?iso-8859-1?Q?LWRBVNA7ZalIin9bNTTuJZ+C1342J52syfyC6NnntXss+bjuqVGPHu6tzx?= =?iso-8859-1?Q?smneqdnWKz6UleYl+8qA6c7fNdBbJX6Ue4YguC8akQNCdg9/+jcQpG8bKb?= =?iso-8859-1?Q?3MUmlImw/ULPLqbsTuFPC9sykb5lLNeVF/xhFo4YK7WWmCveEDc7o2xLw7?= =?iso-8859-1?Q?VM61XoIARaTWRZgCIHnOr5HkUpxlwGt42fAfwjb6uX+pdZrQtnrqBffDes?= =?iso-8859-1?Q?eM3awTSKMpn039gjRoMhTzciLm/72dWwIWnWzM2ftq+k7VlmvqpakVUqbp?= =?iso-8859-1?Q?hvXv2cCQNt6FKL8yq9MVuybXbUa0r5unnkIJSxnpe06A5IhvqoGkQ2enJ8?= =?iso-8859-1?Q?L/oP+iAQYwnZa1ybGtZ65q6HGlhtRH3VbbELuGZAfOyenZjOnH65T/FJkC?= =?iso-8859-1?Q?0MRiTopx/OxQkHPnYE4yZm1eHVoemkbiv1SmnYkXG7ivHrgyBM/6Vzaqav?= =?iso-8859-1?Q?StVOsBt1mCUhuFHrMIA1KB47g+/L275KkTnulbCjzjnLzShoEsJtZw6GgC?= =?iso-8859-1?Q?eVvAnEFOGG9xJ2+b3sZ7ZmFMHVeA33wkntlj8bT+C1pxj8qWCTsOWhdETU?= =?iso-8859-1?Q?mFLz02qUiPelH+OL/dlM2sE7U+Og362Ob7aciMQCUdDTnOQRYRZrA5DCgy?= =?iso-8859-1?Q?EXjV8xsx01mpglMhfYWDC0Q70jdWYk/58Sb+IO7PNHJzp7WqwQO7gSTLGC?= =?iso-8859-1?Q?B3LcifmDb75p3y3mxMlmYnhkx1sMJqbc3ZrhUi/vIhipHbk7Xtklul30os?= =?iso-8859-1?Q?CxJAEHJluhNlkxkUIgWRT4auSHpd6XPSM1UdAE/hnOHTb/suZq5grgwHkX?= =?iso-8859-1?Q?USb4p1ZojRY6A15l61jue9zBR/9OtAXVeT0KvcbAMXI0Zja8l0WlCTiTMn?= =?iso-8859-1?Q?MUNqMg1jDQL5VFmqnNliK9ybFozwFTmtEDEoLLcbWgnLq6kr8n1CAOdjW6?= =?iso-8859-1?Q?LO63lat5woJwqO7NinOPTPN1MubSv6jWs2MCRTgI3aQMJ51BjOZVh20F3r?= =?iso-8859-1?Q?at5GRozqPcD63CVK4JQZloxp0LgiJ1G0ePhXT+80nRiGqpMFRg36TvogFi?= =?iso-8859-1?Q?tDcCzUVeNlBprqsh8B0cVedB73BjcVZUM0R68R2NuKT4bHaCjv4AN/lTEr?= =?iso-8859-1?Q?UKuuP4JYDlPeY6Mop4Rf1mhPFHxoMHLHt6irp828dyflTetclkXomJn2G4?= =?iso-8859-1?Q?NqJN3AnwstCRTVSV+o6Gi3lVSbc7JPNU5PW/kXhzmJheyok0AY+VDIOkCH?= =?iso-8859-1?Q?YI4weHaJgdYyAew+6lBZ13+BMtm8meXFt0vrZYaXLw2Vny7PtIKseJMSC0?= =?iso-8859-1?Q?FUP9cI7t1+DpbreQwc2X7FKUCKMYOnnoely1Pcu1oc0FS6PiWgS1YcVWkV?= =?iso-8859-1?Q?ctUA4s2sZMbO1ncPr5CGK9Dy8r/xmpA4m2J1DSC9sbz+DtD8gzi3+OLeUP?= =?iso-8859-1?Q?8EA9i3Yb6Mzbiw2Ev8vyv88MPkpzE4NAmg6jY5ymPvKg+d+s641/C0Mgp8?= =?iso-8859-1?Q?tprXHlnkX1sJ0VR/Drpe+Utd+jxL1H9XEQXQUkEpqLinbVMhJsvMaFe1ju?= =?iso-8859-1?Q?EKptJ/ayfirsmzTUecoosN6SvpARpiH0KaoAxmBYzzhysy7ONtY1IT3Hx0?= =?iso-8859-1?Q?i1ZTtdUhYMeWSQI9LWo=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: htecgroup.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR09MB3477.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb909fcd-f366-454b-1d62-08de2ce3bbaf X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2025 12:02:55.1034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9f85665b-7efd-4776-9dfe-b6bfda2565ee X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yoOeFPLLbzV6ILBFmMinld6tEkj8wqLDEUX1UGQ03qC7QgwRcMefVAljZbASrsgd9e646/m7VnLt8CZVdojd2x/SSejEPuWxtkeVB0334fg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR09MB4537 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is v4 of: https://inbox.sourceware.org/gdb-patches/20251124132726.325366-1-daniel.k= nezevic@htecgroup.com/ Patch 1: - A preparation patch, as suggested by Simon, that moves logic for printing enums to a helper function. Patch 2: - Updates tests to use multi_line as a preparation step for future changes related to enum printing. =20 Patch 3: - Implements the new way of printing enums and updates tests using enums. - I tried to reduce the number of print calls to minimum by using fprintf_s= tyled function. When printing =3D two print calls are used. The reason for this is maintain printing in the right style (keep t= he same color scheme as before). The first fprintf_styled prints a colored (styled) variable name, then the gdb_printf prints out the value in defau= lt color. Daniel Knezevic (3): gdb: Move logic for printing enums to a helper function gdb: Replace \r\n with multi_line to make tests more readable gdb: Make printing enum types prettier. gdb/c-typeprint.c | 151 +++++++------- gdb/testsuite/gdb.base/call-sc.exp | 11 +- gdb/testsuite/gdb.base/ctf-ptype.exp | 181 ++++++++++++++--- gdb/testsuite/gdb.base/ptype.exp | 186 +++++++++++++++--- .../gdb.base/whatis-ptype-typedefs.exp | 8 +- gdb/testsuite/gdb.cp/classes.exp | 27 ++- gdb/testsuite/gdb.cp/empty-enum.exp | 24 ++- gdb/testsuite/gdb.cp/enum-class.exp | 6 +- gdb/testsuite/gdb.cp/nested-types.exp | 6 +- gdb/testsuite/gdb.dwarf2/enum-type.exp | 14 +- gdb/testsuite/gdb.xml/tdesc-regs.exp | 39 +++- gdb/testsuite/lib/cp-support.exp | 39 +++- 12 files changed, 529 insertions(+), 163 deletions(-) --=20 2.43.0