From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SagKI7Z7GmkBuQoAWB0awg (envelope-from ) for ; Sun, 16 Nov 2025 20:34:46 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v0vQRHtS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8AF441E0AB; Sun, 16 Nov 2025 20:34:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C43E21E08D for ; Sun, 16 Nov 2025 20:34:45 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 702A13858C54 for ; Mon, 17 Nov 2025 01:34:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 702A13858C54 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v0vQRHtS Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 1543F3858D21 for ; Mon, 17 Nov 2025 01:28:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1543F3858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1543F3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763342907; cv=none; b=BUzkH02MDKnG5a5zYJkDyv8tQMn1BDghAD9hRsILyvTftq0hG8G6bJjo0rfvNs/4kkuP2XBiyKAAiWQNf8c860Utr8Bf7OxewqXX0fd+8UVwb2tIq9BDM9CD1TaEkwemhGDSWkHjgJBozoxmLbw2lmHUlTxs7SvcFPvB6oUeY4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763342907; c=relaxed/simple; bh=xudyp32u8RQCBRwP66T9ZqySSj3FWXhPtWVs7ql4m7E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wCMC8ViHkO0oIUTqI91ZnHHzTroNJhVB/hbKQmiOu6yedoGo9pudCSmFOH65Pubma2i+Zk8KLTwOfSQeLW5aZIR7mOn2zrOkAPEioVp2kVAe1yDGilktbR5gc7EhDKZQo/u5oZ0nrOBMD3CKGZhuK07AzPLlZtZDr1fuczseQ2o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1543F3858D21 Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id Kn4SvhhwtVCBNKo2XvwTfL; Mon, 17 Nov 2025 01:28:21 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ko2Wvvtg04jBOKo2WvI8Iy; Mon, 17 Nov 2025 01:28:20 +0000 X-Authority-Analysis: v=2.4 cv=ap2yCTZV c=1 sm=1 tr=0 ts=691a7a34 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=1F9Zqkq4We43AFo5d3QA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wP/sX7RFZeDYXIE4BhlheTMFCangqBSbP/dJbpw23UA=; b=v0vQRHtS5Nvw9Shvus4NvpVsvo Fq6P/U+ZJ5LgHPkgMjl+VrmT0a7BWXDtsK1AEHo3bzlhleBokLZ407UhLunkJMorUhYZyGCyxgPRK mT5wfbpu97ZZaV+lQbglLjjpQ; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:41170 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vKo2S-00000000Q3v-2EqZ; Sun, 16 Nov 2025 18:28:16 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 3/7] Minor fixes to make gdb.objc tests pass Date: Sun, 16 Nov 2025 18:27:02 -0700 Message-ID: <20251117012752.2657208-4-tom@tromey.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251117012752.2657208-1-tom@tromey.com> References: <20251117012752.2657208-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vKo2S-00000000Q3v-2EqZ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (localhost.localdomain) [97.122.120.205]:41170 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNZ/W8JLlzS4QZfa1M07uOEBYTLvAwgOoL8VME1xfq+aPW+j7vNwIhH+a1+vZyuJArNt5SB5ouxjHWKZIkAc8HAl0BTFGCdLC+VII+C5Wubg5PIn0iX2 nOfpKkSYgBDYZsznT1fObT+Si+idN+QOLcaVDS1pMTk9VBrzTOb1FlHI8X8oufd/+18BpS7IJQkSqgmBDkk1VbAolocgO+3iAb0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Once the gdb.objc tests compile, you can see that they do not pass. The issue is primarily that they are over-strict about line numbers. This fixes the problem by replacing these line numbers with $decimal. --- gdb/testsuite/gdb.objc/basicclass.exp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/testsuite/gdb.objc/basicclass.exp b/gdb/testsuite/gdb.objc/basicclass.exp index d1fb64a42de..2be5b2e83ef 100644 --- a/gdb/testsuite/gdb.objc/basicclass.exp +++ b/gdb/testsuite/gdb.objc/basicclass.exp @@ -89,36 +89,36 @@ do_objc_tests gdb_test "set breakpoint pending off" "" "set breakpoint pending" gdb_test "break doIt" \ - "Breakpoint.*at.* file .*$srcfile, line.29.*" \ + "Breakpoint.*at.* file .*$srcfile, line $decimal.*" \ "breakpoint method" gdb_test "break takeArg:" \ - "Breakpoint.*at.* file .*$srcfile, line.34.*" \ + "Breakpoint.*at.* file .*$srcfile, line $decimal.*" \ "breakpoint method with colon" gdb_test "break newWithArg:" \ - "Breakpoint.*at.* file .*$srcfile, line.22.*" \ + "Breakpoint.*at.* file .*$srcfile, line $decimal.*" \ "breakpoint class method with colon" # # Continue until breakpoint (test re-setting breakpoint) # gdb_test continue \ - "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass takeArg:. \\(self=.*, _cmd=.*, arg=.*\\) at .*$srcfile:34.*" \ + "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass takeArg:. \\(self=.*, _cmd=.*, arg=.*\\) at .*$srcfile:$decimal.*" \ "continue until method breakpoint" # # Test resetting breakpoints when re-running program # gdb_run_cmd -gdb_test "" "Breakpoint \[0-9\]+,.*main .*argc.*argv.* at .*$srcfile:.*" "resetting breakpoints when rerunning" +gdb_test "" "Breakpoint .+,.*main .*argc.*argv.* at .*$srcfile:.*" "resetting breakpoints when rerunning" # # Continue until breakpoint (test re-setting breakpoint) # gdb_test continue \ - "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass takeArg:. \\(self=.*, _cmd=.*, arg=.*\\) at .*$srcfile:34.*" \ - "continue until method breakpoint" + "Continuing\\..*Breakpoint .+, -.BasicClass takeArg:. \\(self=.*, _cmd=.*, arg=.*\\) at .*$srcfile:$decimal.*" \ + "continue until method breakpoint again" # # Test printing objects @@ -139,7 +139,7 @@ gdb_test "print \*self" \ # Break in a category # gdb_test "break hiddenMethod" \ - "Breakpoint.*at.* file .*$srcfile, line.61." \ + "Breakpoint.*at.* file .*$srcfile, line $decimal." \ "breakpoint in category method" @@ -147,7 +147,7 @@ gdb_test "break hiddenMethod" \ # Continue until breakpoint (test re-setting category breakpoint) # gdb_test continue \ - "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass\\(Private\\) hiddenMethod. \\(self=.*, _cmd=.*\\) at .*$srcfile:61.*" \ + "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass\\(Private\\) hiddenMethod. \\(self=.*, _cmd=.*\\) at .*$srcfile:$decimal.*" \ "continue until category method" # -- 2.49.0